Collectible Card Game Headquarters

Sloth wrote:I'm currently testing the branch and Necrotic Ooze was working as expected with Brain Weevil.

So the big task to do is adding "References$ XY" to all activated abilities that use SVars with Count. Are there any other unsolved problems we can help with/think about?

Sweet. And you've been hard at work, I see. Thanks!

Yep, that's the big bit. Ways to make the system more elegant is always nice too, of course. I'd like to make the code in StaticAbilityContinuous more in-line with how the other static ability-granting works.Maybe rework Costs to avoid the wart that is "Cost.setSpellAbility()" but that might be too much work for too little gain.

ArsenalNut wrote:I haven't given up on the script idea yet. I don't really understand the changes to the syntax you're making yet. I want to see some examples before I can really decide if a script is worth the effort.

Abyssal Hunter, Copper-Leaf Angel and Painbringer in the branch were converted for testing purposes.

I had a little time yesterday and was going to try to merge in trunk changes but I could not for the life of me commit the changes made.. There were conflicts(not unexpected, especially in AbilityMana) that I managed to resolve but on commit Subclipse complained about conflicts on the res/Images folder that I can't seem to resolve.(There was no mention of this conflict in the merge report,either) Will try again this weekend, if nothing else.

EDIT:Welp,now I know about tree conflicts...Take 2 tonight possibly.

Hellfish wrote:I had a little time yesterday and was going to try to merge in trunk changes but I could not for the life of me commit the changes made.. There were conflicts(not unexpected, especially in AbilityMana) that I managed to resolve but on commit Subclipse complained about conflicts on the res/Images folder that I can't seem to resolve.(There was no mention of this conflict in the merge report,either) Will try again this weekend, if nothing else.

EDIT:Welp,now I know about tree conflicts...Take 2 tonight possibly.

I used TortoiseSVN to merge the Trunk changes r15523-r15685 into AbilityWork branch. It's got a nice interface to handle conflicts as they pop up during a merge. I tested Experimental Kraj and it seemed to work.

Thanks for the assist! I'mma start cleaning up and adding the References parameter.

Hellfish wrote:Thanks for the assist! I'mma start cleaning up and adding the References parameter.

Do you still need to convert hardcoded X svars to fetching arbitrary svars, or did the final system find a way around those issues? I have an idea what I'm doing there now after making the change for ActivationLimit so might be able to help.

Not sure what you mean. What's needed for right now is adding the References$ parameter to all card scripts where an ability references an XCount SVar. I just committed all 'A' cards, you can check one of those out to see what I mean.

Apologies for my poor explanation, what I was talking about was allowing the various parameters that call xCount (such as NumDmg etc) to use arbitrary names instead of just X (or other hardcoded ones like MaxDmg), so that the svars could all have unique names. I'm guessing its not an issue anymore though seeing as you're adding all the References already.

I'm just finishing up some work then will check out the branch and start at Z.

Oh,that.

That shouldn't be an issue since the References parameter causes the svars to be stored and grabbed from the SpellAbility rather than the Card so each copy of an ability with assistant svars carreis those svars on itself rather than copying them to Experiment Kraj or whatever and possibly overwriting similarly named svars.

Thanks (and thanks to Sloth) for the assistance, it is mind-numbing work.

Seeing as Sloth covered X-Z already I've jumped in at M. Came across a situation I'm not sure how to handle. Do etbCounter:X keywords need a References$X or does it fall outside of the purpose of these?

Edit: Nevermind. I see Balduvian Hydra doesn't have it so I'll do likewise.

Is there a reason why cards like Avalanche only reference X, not MaxTgts as well? Is it because TargetMax$MaxTgts is hardcoded to grab that specific svar, or was it just an oversight?

moomarc wrote:Is there a reason why cards like Avalanche only reference X, not MaxTgts as well? Is it because TargetMax$MaxTgts is hardcoded to grab that specific svar, or was it just an oversight?

Good catch, that's an oversight.

moomarc wrote:Seeing as Sloth covered X-Z already I've jumped in at M. Came across a situation I'm not sure how to handle. Do etbCounter:X keywords need a References$X or does it fall outside of the purpose of these?

Edit: Nevermind. I see Balduvian Hydra doesn't have it so I'll do likewise.

etbCounter:X is an issue all it's own that I hope to get a handle on before the weekend is out.

Hellfish, for cards like Minions' Murmurs where X is referenced by the main ability and it's subability, do we need to add the references param to both lines or just the root ability?

Just the main ability would be logical, but all of the chain would be clearer, maybe? Right now the entire chain needs the parameter,though I'm open to change that.

Hey, Marc, I was probably a bit unclear about where References$ is needed, sorry about that

Static abilities and Trigger lines do not need References$ (The ability part of triggers do, though), only AB,SP and DB abilities do, including those inside SVars.

Gonna merge in the trunk changes then keep on trucking.