Running checkStaticAbilities before ETB triggers happen

by **Sloth** » 13 Sep 2012, 20:28

Here is a post by Jaedayr

Jaedayr wrote:I have Creakwood Liege and Sigil Captain in play. At the beginning of my upkeep I get a 3/3 token wurm with 2 +1/+1 counters on it making it 5/5. I ran across this and wonder if this is a bug in Forge or not.

http://forums.mtgsalvation.com/showthre ... wood+liege

We currently don't run checkStaticAbilities before the triggers happen, if i remember correctly only because this causes "leaves the battlefield" triggers to go wrong. So my idea is to run checkStaticAbilities exclusively if it is a changezone trigger with destination battlefield.

Or was there another reason to not run checkStaticAbilities before triggers?

by **Hellfish** » 14 Sep 2012, 19:20

I *remember* no reason, no. Then again, I havn't messed with the trigger system since fixing Adaptive Automaton+Type Changers.

by **Sloth** » 16 Sep 2012, 20:42

Whenever i try to fix something related to triggers something else related to triggers breaks. I've commited the change, let's see what fails this time.

by **Hellfish** » 16 Sep 2012, 21:05

*Crosses fingers*
The old gal is getting a bit rusty in the wheel arches.

If another glut of free time falls into my lap I'll see about getting it all up to code.