It is currently 10 Sep 2025, 23:21
   
Text Size

NameChanger - what is it and why we keep it?

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

NameChanger - what is it and why we keep it?

Postby Max mtg » 08 Oct 2012, 11:40

Subj.

The named class contains some ugly code and seems of no practival use to me, given that there is even no input file for it in the /res folder

I suggest its removal.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: NameChanger - what is it and why we keep it?

Postby Chris H. » 08 Oct 2012, 12:33

I first discovered this app back in 2008 when I came across an app named "Card Warrior 2". I played a few games and the game seemed familiar but the cards had the wrong name. This lead me to find the actual Forge app which included correctly named cards.

"Card Warrior 2" was an attempt to avoid cr issues I guess.

The NameChanger method caused some problems as Dennis and Rob were adding in new cards. I found the code and figured out that commenting out a line of code would prevent the NameChanger code from changing the card names.

It would be nice to have all of the old name changer code removed from the project.

If anyone is interested, I have attached the cardwarrior archive and the name-mutator.txt file that I still have in my possession.
 
Attachments
01-05-cardwarrior.zip
(975.54 KiB) Downloaded 183 times
name-mutator.txt.zip
This file appears to be a fixed version, the original can be found in the card warrior archive
(4.82 KiB) Downloaded 179 times
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: NameChanger - what is it and why we keep it?

Postby Max mtg » 08 Oct 2012, 12:44

Chris H. wrote:It would be nice to have all of the old name changer code removed from the project.
Done

And thank you for information
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: NameChanger - what is it and why we keep it?

Postby Chris H. » 08 Oct 2012, 12:58

Max mtg wrote:Done

And thank you for information
 
Thank you.

Oh, it appears that the name-mutator.txt file that I included was a fixed replacement file and the one attached to this message comes form the card warrior archive.
 
Attachments
name-mutator.txt.zip
This version is from the card warrior archive
(6.62 KiB) Downloaded 204 times
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 49 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 49 users online :: 0 registered, 0 hidden and 49 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 49 guests

Login Form