Collectible Card Game Headquarters

5. Major changes/submissions to the code base that may be disruptive should be merged into the SVN on the weekend following a beta release. This will give people a chance to find and to fix any problems which may become apparent after a merge. It may be difficult to predict which merges are disruptive and which ones are safe. It could be viewed as something of a crap shoot.

6. Minor new material and bug fixes can be submitted at all times between beta releases. Granted, what is meant to be a minor submission or a minor bug fix could leave the code base in a problematic state. Stuff happens.

7. Major changes to the code base should be discussed with other members of the dev team on the dev topic in advance to submitting the changes to the SVN.

Sloth wrote:I'm still in favor of a beta release soonish. Most of the bugs posted in the 1.3.0 beta topic have been fixed already and it tires me to read them again and again.

If tomorrow is too soon to fix the remaining bugs RumbleBBU has posted (one of which has been around long before the 1.3.0 beta), maybe at the start of next week?

Agetian wrote:The bug with the restricted X mana pool is fixed, by the way, thanks for catching it!

- Agetian

moomarc wrote:

Agetian wrote:The bug with the restricted X mana pool is fixed, by the way, thanks for catching it!

- Agetian

Excellent! Thanks Speedy!

moomarc wrote:I like the idea of the unlock token. Would you still have to pay as well, seeing as you get a starter and booster (or whatever the base pack was)? It's a great idea becuase you don't have to worry about missing your unlock by a handful of credits. Thanks!

Code: Select all


        IStorageView<BoosterData> starters = Singletons.getModel().getTournamentPacks();
        IStorageView<BoosterData> boosters = Singletons.getModel().getBoosters();
        qData.getFormat().unlockSet(unlockedSet.getCode());

        List<CardPrinted> cardsWon = new ArrayList<CardPrinted>();

        if (starters.contains(unlockedSet.getCode())) {
            UnOpenedProduct starter = new UnOpenedProduct(starters.get(unlockedSet.getCode()));
            cardsWon.addAll(starter.open());
        }
        else if (boosters.contains(unlockedSet.getCode())) {
            UnOpenedProduct booster = new UnOpenedProduct(boosters.get(unlockedSet.getCode()));
            cardsWon.addAll(booster.open());
            cardsWon.addAll(booster.open());
            cardsWon.addAll(booster.open());
        }

        qData.getCards().addAllCards(cardsWon);
        final CardListViewer cardView = new CardListViewer(unlockedSet.getName(), "You get the following bonus cards:", cardsWon);
        cardView.show();
        qData.save();
    }

Code: Select all

        final ReadPriceList prices = new ReadPriceList();
        final Map<String, Integer> mapPrices = prices.getPriceList();
        final List<ImmutablePair<CardEdition, Integer>> setPrices = new ArrayList<ImmutablePair<CardEdition,Integer>>();

        for (CardEdition ed : getUnlockableEditions(qData)) {
            int price = 7500;
            if (mapPrices.containsKey(ed.getName() + " Booster Pack")) {
                price = Math.max( 50 * mapPrices.get(ed.getName() + " Booster Pack"), 7500 );
            }
            setPrices.add(ImmutablePair.of(ed, price));
        }

Max mtg wrote:commited some different brains for quest sets unlocks.

A set unlock token is awarded for each 20 wins. They are 'kept' in inventory and can be used at any time.
Number of wins doesn't really matter - might change it to 12 or 60, I don't care for now.

NPE mentioned above does not happen anymore.

As for me releasing a beta tomorrow would be better than doing so on Monday.