Collectible Card Game Headquarters

RumbleBBU wrote:http://svn.slightlymagic.net/websvn/dif ... &peg=17789

Code: Select all

    /**
     * Empty the whole list.
     */
    public void emptyAllowedSets() {
        if (allowedSetCodes != null) {
            while (!allowedSetCodes.isEmpty()) {
                allowedSetCodes.remove(0);
            }
        }
    }


A whole function instead of allowedSetCodes.clear();

make it final:

Code: Select all

private final List<String> allowedSetCodes = new ArrayList<String>();

and you will never have to check for allowedSetCodes != null

http://svn.slightlymagic.net/websvn/dif ... &peg=17789

There are already all decks loaded in memory. If you are giving user freedom to choose his deck, then should not restrict on sealed. If you want him to use limited mode only decks - then do use Singeltons.gteModel().getDecks().get(Draft-or-Sealed) to give a list to choose from.

1. The unnecessary loop: good catch. Missed that one when cleaning up my files before the commit.

2. The null check: I have a habit of putting in paranoia checks like this (even when they are technically unnecessary, i.e., when they should always be false). It's a habit that is difficult to unlearn.

3. The decks in memory: you're probably right. I'll change that when I have time.