Collectible Card Game Headquarters

I don't know whose code that is but I am definetelly quite unhappy to find such masterpieces in our project.

Code: Select all

        // Show or hide the set unlocking button
        if (qCtrl.getFormatNumberUnlockable() > 0) {
            view0.getBtnUnlock().setVisible(true);
        } else {
            view0.getBtnUnlock().setVisible(false);
        }


why don't just write

Code: Select all

view0.getBtnUnlock().setVisible(qCtrl.getFormatNumberUnlockable() > 0)

?

How do we get sorted list of all magic edtions? I have seen a solution!

Code: Select all

TreeMap<Integer, CardEdition> sortedMap = new TreeMap<Integer, CardEdition>();
        for (CardEdition ce : Singletons.getModel().getEditions()) {
           sortedMap.put(new Integer(ce.getIndex()), ce);
        }

        List<CardEdition> sortedEditions = new ArrayList<CardEdition>(sortedMap.values());


meanwhile CardEdition implements Comparable and you can get sorted list in 2 steps:

Code: Select all

List<CardEdition> editions = Lists.newArrayList(Singletons.getModel().getEditions());
Collections.sort(editions);