Page 8 of 16

Re: Implementing variants

PostPosted: 08 Dec 2012, 11:54
by Hellfish
Alright,I'll see about reintegration when I get home tomorrow :)

Re: Implementing variants

PostPosted: 09 Dec 2012, 20:52
by Hellfish
Oh, for the love of... Anybody else care to reintegrate? My computer refuses to recognize my modem so unless I can mooch off the gf's laptop I won't be coding much for a while. (Unless someone knows of an svn-app for android.. :/ )

Re: Implementing variants

PostPosted: 09 Dec 2012, 23:55
by friarsol
Hellfish wrote:Oh, for the love of... Anybody else care to reintegrate? My computer refuses to recognize my modem so unless I can mooch off the gf's laptop I won't be coding much for a while. (Unless someone knows of an svn-app for android.. :/ )
I use rabbitvcs at work for Linux. It's like tortoise svn, but not quite so good.

Re: Implementing variants

PostPosted: 10 Dec 2012, 08:47
by Hellfish
There's about 5 svn apps on the Play-store and 4 of them are view-only and the last one does not support merge.. I guess I'm out for a while. :/

Re: Implementing variants

PostPosted: 10 Dec 2012, 19:44
by Sloth
I will try to reintegrate the branch.

Re: Implementing variants

PostPosted: 13 Dec 2012, 08:39
by Sloth
The "Download LQ Set Pictures" function currently skips all Schemes ("Skipped Download for: res\preferences\..\pics\ARC\Your Will Is Not Your Own.full.jpg"). Does anyone know why?

Re: Implementing variants

PostPosted: 13 Dec 2012, 10:36
by moomarc
Sloth wrote:The "Download LQ Set Pictures" function currently skips all Schemes ("Skipped Download for: res\preferences\..\pics\ARC\Your Will Is Not Your Own.full.jpg"). Does anyone know why?
I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.

Re: Implementing variants

PostPosted: 13 Dec 2012, 12:33
by Sloth
moomarc wrote:I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.
That's not the issue here. Downloading the Set pictures is trying to get them from magiccards.info not cardforge.org.

Code: Select all
SVar:Picture:http://www.cardforge.org/fpics/lq_schemes/your_will_is_not_your_own.jpg
SetInfo:ARC|Common|http://magiccards.info/extras/scheme/archenemy/your-will-is-not-your-own.jpg
I haven't tried the non-set LQ pictures.

Re: Implementing variants

PostPosted: 13 Dec 2012, 13:36
by moomarc
Sloth wrote:
moomarc wrote:I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.
That's not the issue here. Downloading the Set pictures is trying to get them from magiccards.info not cardforge.org.

Code: Select all
SVar:Picture:http://www.cardforge.org/fpics/lq_schemes/your_will_is_not_your_own.jpg
SetInfo:ARC|Common|http://magiccards.info/extras/scheme/archenemy/your-will-is-not-your-own.jpg
I haven't tried the non-set LQ pictures.
Why on earth would it do that? Sets are always grabbed from cardforge. Maybe it has something to do with the separation of traditional cards and extras? But then, Vanguard shouldn't download either, surely.

Re: Implementing variants

PostPosted: 14 Dec 2012, 05:42
by moomarc
Turns out it was the name of the decrypted cardforge files that was causing problems. Should be working now.

Re: Implementing variants

PostPosted: 21 Dec 2012, 07:04
by swordshine
For some Vanguard avatars, e.g. Goblin Warchief avatar, pics from different urls have different informations about the hand size or life modifier.
http://www.cardforge.org/fpics/vgd-lq/goblin_warchief_avatar.jpg
http://magiccards.info/extras/other/vanguard-mtgo/goblin-warchief.jpg
Which one is correct?

Re: Implementing variants

PostPosted: 21 Dec 2012, 07:11
by moomarc
swordshine wrote:For some Vanguard avatars, e.g. Goblin Warchief avatar, pics from different urls have different informations about the hand size or life modifier.
http://www.cardforge.org/fpics/vgd-lq/goblin_warchief_avatar.jpg
http://magiccards.info/extras/other/vanguard-mtgo/goblin-warchief.jpg
Which one is correct?
If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.

EDIT: just checked oracle text on gatherer and +1/+2 is the correct modifier.

Re: Implementing variants

PostPosted: 21 Dec 2012, 07:22
by swordshine
moomarc wrote:If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.
Thanks, the life modifier from both pictures of Royal Assassin Avatar is -3, but the template gives +0.

Re: Implementing variants

PostPosted: 21 Dec 2012, 07:34
by moomarc
swordshine wrote:
moomarc wrote:If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.
Thanks, the life modifier from both pictures of Royal Assassin Avatar is -3, but the template gives +0.
Just checked oracle and the template wins again. ;) I'll modify the image later today some time. Thanks! (And thanks for all the new avatars. Been planning to get a few more done but with my wife being home for holiday, I don't get much forge time :mrgreen: )

Re: Implementing variants

PostPosted: 21 Dec 2012, 09:25
by swordshine
moomarc wrote:Just checked oracle and the template wins again. ;) I'll modify the image later today some time. Thanks! (And thanks for all the new avatars. Been planning to get a few more done but with my wife being home for holiday, I don't get much forge time :mrgreen: )
Enjoy yourself! Here in China, the winter solstice is also a triditional holiday :D and I'm gonna have a party with my friends.