High Quality Resources for Collectible Card Games and Home of the CCGHQ Team
https://www.slightlymagic.net/forum/
https://www.slightlymagic.net/forum/viewtopic.php?f=52&t=9147
Posted: 31 Dec 2012, 09:21Posted: 31 Dec 2012, 14:41I'm not sure how difficult this really is. We just need to expand CopySpell to also allow copying of abilities [Probably changing the name to CopySpellAbility?] and add a flag in "AbilityCast" to check if the Ability is a mana ability, which should be pretty straightforward.swordshine wrote:Illusionist's Bracers is also difficult because its ability is similar to Rings of Brighthearth.
Posted: 01 Jan 2013, 11:05
Posted: 02 Jan 2013, 07:17It is done. No changes needed to AbilityCast, it doesn't trigger on mana abilities anyway.friarsol wrote:I'm not sure how difficult this really is. We just need to expand CopySpell to also allow copying of abilities [Probably changing the name to CopySpellAbility?] and add a flag in "AbilityCast" to check if the Ability is a mana ability, which should be pretty straightforward.swordshine wrote:Illusionist's Bracers is also difficult because its ability is similar to Rings of Brighthearth
Posted: 02 Jan 2013, 08:30Thanks Hellfish. I found a bug when testing Rings of Brighthearth. The mana ability of Metalworker would trigger the copyability AF, you may pay 2 to copy it but nothing happened when it resolves.Hellfish wrote:It is done. No changes needed to AbilityCast, it doesn't trigger on mana abilities anyway.
Posted: 02 Jan 2013, 09:13
)while the mana portion of Metalworker's ability is a subability. I think I know a solution, I'll see if I can get a computer after work.Posted: 02 Jan 2013, 10:16The copied ability does not have the correct source now.706.10b A copy of an ability has the same source as the original ability. If the ability refers to its source by name, the copy refers to that same object and not to any other object with the same name. The copy is considered to be the same ability by effects that count how many times that ability has resolved during the turn.
Posted: 04 Jan 2013, 07:04Posted: 04 Jan 2013, 14:49There are a couple of issues with this change.Hellfish wrote:I also changed SpellAbility.isManaAbility() to also look at subabilities.
The first ability of Deathrite Shaman is not a mana ability because the it targets the card to exile.605.1a An activated ability is a mana ability if it meets three criteria: it doesn’t have a target, it
could put mana into a player’s mana pool when it resolves, and it’s not a loyalty ability. (See
rule 606, “Loyalty Abilities.”)
Posted: 04 Jan 2013, 15:09
Posted: 04 Jan 2013, 18:44Posted: 04 Jan 2013, 21:36Why is the branch a full copy of the trunk?Hellfish wrote:Branch created, go nuts.
Posted: 04 Jan 2013, 21:57
Sorry about that, cant fix from my phone. Good to hear it can be worked with at least.Posted: 04 Jan 2013, 22:00There's no need to change this. We can all just avoid commiting changes outside the cardsfolder.Hellfish wrote:A wizard did it. A very clumsy wizard.
Posted: 04 Jan 2013, 22:18Since it happens 4 times a year, maybe we should write up a small bit on the Wiki for Spoiler Season procedure?Sloth wrote:There's no need to change this. We can all just avoid commiting changes outside the cardsfolder.Hellfish wrote:A wizard did it. A very clumsy wizard.