Collectible Card Game Headquarters

http://svn.slightlymagic.net/websvn/dif ... &peg=19410

- Why is a random rare for winning a very hard challenge hardcoded? (why not to hold it in quest world options?)
- Why is difficulty hardcoded and compared against a string? (consider making an enum with custom valueOf overload to parse strings)


http://svn.slightlymagic.net/websvn/dif ... &peg=19410
- should be StringUtils.isBlank()


for the rest -
QuestEventDuels were not supposed to hold any special rewards. Why have you moved cardRewardList to base class? Why QuestEventChallenges able to hold special rewards don't suit you?

Max mtg wrote:http://svn.slightlymagic.net/websvn/diff.php?repname=forge&path=%2Ftrunk%2Fsrc%2Fmain%2Fjava%2Fforge%2Fgui%2Fmatch%2FQuestWinLose.java&rev=19410&peg=19410
- Why is a random rare for winning a very hard challenge hardcoded? (why not to hold it in quest world options?)
- Why is difficulty hardcoded and compared against a string? (consider making an enum with custom valueOf overload to parse strings)

This has been the case as long as I have known Forge...I didn't make this, I just moved it to a different place.

Max mtg wrote:for the rest -
QuestEventDuels were not supposed to hold any special rewards. Why have you moved cardRewardList to base class? Why QuestEventChallenges able to hold special rewards don't suit you?

Did you read the commit comment? That was the whole point of the commit (explained in more detail in the comment).