Commit r19539 "Where's my abilityfactory package?"
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
2 posts
• Page 1 of 1
Commit r19539 "Where's my abilityfactory package?"
by Max mtg » 12 Feb 2013, 05:41
I have renamed the package abilityfactory into just 'ability' for there's only one class in it representing the factory. The rest are ability effects, their ai and utility classes.
This name is shorter and better reflects the purpose of the package in question, so I hope that will contribute for better code understand-ability.
Some of you might have faced tree conflicts performing svn up. I'm sorry about that.
As Sol has rightfully noted, I have not discussed this change with the team (though I believe everyone will benefit from it) so you may blame on me here.
This name is shorter and better reflects the purpose of the package in question, so I hope that will contribute for better code understand-ability.
Some of you might have faced tree conflicts performing svn up. I'm sorry about that.
As Sol has rightfully noted, I have not discussed this change with the team (though I believe everyone will benefit from it) so you may blame on me here.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Commit r19539 "Where's my abilityfactory package?"
by Max mtg » 12 Feb 2013, 05:43
It also appears that packages forge.card.ability and forge.card.spellability might be merged.
What do you think of that?
What do you think of that?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
2 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 73 guests