Undefeated doesn't mean Alternate Win

[friarsol]

r19689
Max why did you revert my change in QuestWinLose. The quest preference that says "Alternative" (as in Alternative Win) is the preference should be used for a SpellEffect that wins a game (or cause an opponent to lose a game). The quest preference "Undefeated" means exactly what it says that the Player did not have any defeats when they won the match. Why do you think otherwise?

Here is the code that awards Undefeated bonus:

Code: Select all

        // Undefeated bonus
        if (hasNeverLost) {
            credUndefeated += Singletons.getModel().getQuestPreferences().getPreferenceInt(QPref.REWARDS_UNDEFEATED);
            final int reward = Singletons.getModel().getQuestPreferences().getPreferenceInt(QPref.REWARDS_UNDEFEATED);
            sb.append(String.format("You have not lost once! " + "Bonus: %d credits.<br>", reward));
        }


[Max mtg]

Ahh.... that REWARDS_UNDEFEATED has different sense here!

Well, my intention was to set up different rewards for winning by spell that reads "you win" and winning by spell texted "opponent loses". It's a pity that constant REWARDS_UNDEFEATED is used for a different purpose!

will have to rollback then.

[friarsol]

Well, my intention was to set up different rewards for winning by spell that reads "you win" and winning by spell texted "opponent loses".

Ahh gotcha. There's nothing saying that we couldn't add a different preference for that.

I think that level of granularity would be more useful if a) we had multiplayer quest challenges and b) we'd want to give a smaller value based on number of opponents (i.e. Coalition Victory grants 100 credits for winning by alternative means, but maybe for each Opponent you activated Door to Nothingness on you would get 100/X credits for, where X is the total number of opponents in the match).

[Max mtg]

you're right. that won't make any difference until mutiplayer matches are implemented in quest mode.