Page 1 of 1

Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 07:33
by Max mtg
Recently I made IPaperCard interface, and like the idea so much that would love to rename all out-of-game cards and tokens to Paper*.

Would you call this a good idea?

Re: Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 17:46
by moomarc
Max mtg wrote:Recently I made IPaperCard interface, and like the idea so much that would love to rename all out-of-game cards and tokens to Paper*.

Would you call this a good idea?
What is the purpose of renaming them all? Is it just because you find it would be easier to interperet the usage in the code, or is there another reason? If it's for easier code reading, I don't mind either way.

Re: Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 19:19
by Max mtg
I think new names reflect closer the essence of the class.

Re: Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 19:21
by friarsol
Max mtg wrote:I think new names reflect closer the essence of the class.
I'd say OracleCard and OracleToken would reflect it even better, since the card on paper for older cards isn't necessarily the state of the Card officially.

Re: Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 19:31
by Max mtg
friarsol wrote:
Max mtg wrote:I think new names reflect closer the essence of the class.
I'd say OracleCard and OracleToken would reflect it even better, since the card on paper for older cards isn't necessarily the state of the Card officially.
No, they are not Oracle cards. ArtIndex, foil - aren't properties of oracle card. It is CardRules that might be named OracleCard, though it's current name seems good enough for now.

Re: Do you want CardPrinted renamed into PaperCard?

PostPosted: 25 Feb 2013, 20:48
by friarsol
Max mtg wrote:No, they are not Oracle cards. ArtIndex, foil - aren't properties of oracle card. It is CardRules that might be named OracleCard, though it's current name seems good enough for now.
Ahh right, I always confuse those in my head for some reason. I'm pretty ambivalent here.