mtg-data.txt db faults =(
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
32 posts
• Page 1 of 3 • 1, 2, 3
mtg-data.txt db faults =(
by Max mtg » 08 Mar 2013, 16:05
mtg data file is not a very good database.
Besides it has inaccurate data for split cards, It also lists some cards as if they were issued in Starter 2000, though they were printed only in 6th edition.
ex: http://gatherer.wizards.com/Pages/Card/ ... seid=25514
and all basic lands! Gatherer and mtg-data.txt are sure that S00 had a couple of basic lands of each type, but there are none in scans folders and obviuosly the cards listed as 'starter 2000' also bear the VI edition code.
I am thinking of other sources of information...
* Magiccards.info is more accurate but we don't have their database downloaded. - Should somehow DL whole of their database.
* May also parse magic online database, I've datamined its format some time before. - Should parse and build up a table of card-to-editions matches and check it for errors.
Besides it has inaccurate data for split cards, It also lists some cards as if they were issued in Starter 2000, though they were printed only in 6th edition.
ex: http://gatherer.wizards.com/Pages/Card/ ... seid=25514
and all basic lands! Gatherer and mtg-data.txt are sure that S00 had a couple of basic lands of each type, but there are none in scans folders and obviuosly the cards listed as 'starter 2000' also bear the VI edition code.
I am thinking of other sources of information...
* Magiccards.info is more accurate but we don't have their database downloaded. - Should somehow DL whole of their database.
* May also parse magic online database, I've datamined its format some time before. - Should parse and build up a table of card-to-editions matches and check it for errors.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by Agetian » 08 Mar 2013, 16:14
Oh, good call! I was wondering about those S00 cards - was wondering if maybe I have an incomplete S00 set downloaded or something when I saw cards with missing pictures. And yeah, some setinfo's for the splits are inaccurate too. Would be very nice if you come up with an idea to compile a better database for Forge! Keep up the great work!
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: mtg-data.txt db faults =(
by friarsol » 08 Mar 2013, 16:15
Gatherer is the source which mtg-data grabs from. And Gatherer is the official source. If Gatherer incorrectly lists a card is being from a set, then it's a bug in Gatherer. Are you sure that the "official" source that lists a card as being from a set is incorrect, and the "unofficial" source that doesn't list the card is correct?Max mtg wrote:mtg data file is not a very good database.
Besides it has inaccurate data for split cards, It also lists some cards as if they were issued in Starter 2000, though they were printed only in 6th edition.
ex: http://gatherer.wizards.com/Pages/Card/ ... seid=25514
and all basic lands! Gatherer and mtg-data.txt are sure that S00 had a couple of basic lands of each type, but there are none in scans folders and obviuosly the cards listed as 'starter 2000' also bear the VI edition code.
If I remember correctly, Starter 2000 had a bunch of new cards in it (like Portal) which didn't have a Set Icon, but it also used cards from 6th edition (the set out in the time) and didn't reprint them, just grabbed them straight from 6th edition cards.
So your Starter cards could have a 6th edition set icon on them, if they were one of these reprints.
The official checklist released in 2000 even lists your examples: http://www.wizards.com/magic/generic/ca ... cklist.txt
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by Max mtg » 08 Mar 2013, 16:42
Sol, if the checklist is the most accurate, then the hq scans we have downloaded miss some 24 cards. So if we stick to the list, will have to fill the gaps in our downloaded collections...and all of players have to do so too.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by friarsol » 08 Mar 2013, 16:45
Isn't it much more likely that the HQ Picture team doesn't have a few scans of a set then the official check list of a set was incorrect?Max mtg wrote:Sol, if the checklist is the most accurate, then the hq scans we have downloaded miss some 24 cards. So if we stick to the list, will have to fill the gaps in our downloaded collections...and all of players have to do so too.
Edit: viewtopic.php?f=15&t=445&p=84217&hilit=starter+200#p84217
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by Max mtg » 08 Mar 2013, 17:01
So, what should we do?
Add some hardcodes meaning 'take 6ed for this card if it's missing in S00' or add any new options to setinfo?
Add some hardcodes meaning 'take 6ed for this card if it's missing in S00' or add any new options to setinfo?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by friarsol » 08 Mar 2013, 17:08
Maybe we can just copy the appropriate card pics into the S00 folder so they'll be available for everyone on download? That seems to be what the HQ Pics guy is suggesting for people, and most importantly doesn't require extra programming or script changes.Max mtg wrote:So, what should we do?
Add some hardcodes meaning 'take 6ed for this card if it's missing in S00' or add any new options to setinfo?
I do hope that Arch can resolve his new bugs with the Split Cards though, mtgdata has been pretty useful for us in the past.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by Max mtg » 08 Mar 2013, 17:26
That 'we' also includes all players who use downloaded CCGHQ images.
You'll have to explain it to them in the next release notes
You'll have to explain it to them in the next release notes
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by friarsol » 08 Mar 2013, 17:43
Haha. I was just thinking about the LQ Set images.. Wasn't even considering the other. It's definitely an odd scenario. Stupid Starter sets that aren't even a full set.Max mtg wrote:That 'we' also includes all players who use downloaded CCGHQ images.
You'll have to explain it to them in the next release notes
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by Max mtg » 08 Mar 2013, 19:04
So, are we agreed on hardcode, like if set==S00 and card image not found, try again with set=6ed?friarsol wrote:Haha. I was just thinking about the LQ Set images.. Wasn't even considering the other. It's definitely an odd scenario. Stupid Starter sets that aren't even a full set.Max mtg wrote:That 'we' also includes all players who use downloaded CCGHQ images.
You'll have to explain it to them in the next release notes
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by friarsol » 08 Mar 2013, 19:15
Sure, it's not great, but since Starter 2000 seems to work exactly this way, it's probably the right way to handle things.Max mtg wrote:So, are we agreed on hardcode, like if set==S00 and card image not found, try again with set=6ed?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by Chris H. » 09 Mar 2013, 03:14
friarsol wrote:If I remember correctly, Starter 2000 had a bunch of new cards in it (like Portal) which didn't have a Set Icon, but it also used cards from 6th edition (the set out in the time) and didn't reprint them, just grabbed them straight from 6th edition cards.
So your Starter cards could have a 6th edition set icon on them, if they were one of these reprints.
The official checklist released in 2000 even lists your examples: http://www.wizards.com/magic/generic/ca ... cklist.txt
I checked the listing and there appears to be 24 cards from 6th and 1 card form 8th (Rhox) that are missing.
The archive below contains HQ pics for these cards. They need to be run through the script/commands that will scale them down in size and saved at less than 100%. At that point they need to be added to the Starter 2000 cards folder at cardforge.
- Attachments
-
Missing Starter 2000 HQ pics.zip- (4.14 MiB) Downloaded 368 times
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: mtg-data.txt db faults =(
by Chris H. » 09 Mar 2013, 03:20
I attempted to download the new LQ card set pics that have been released to cardforge over the last year or so. This is the list of cards that as of today do not download.
- the list | Open
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: mtg-data.txt db faults =(
by myk » 09 Mar 2013, 05:53
I have a quick semi-related question: why is it that our set-specific LQ pics are on the cardforge server with base64-encoded names? Is this how we get them? Is this standard procedure?
Last edited by myk on 09 Mar 2013, 06:43, edited 1 time in total.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: mtg-data.txt db faults =(
by Max mtg » 09 Mar 2013, 06:26
There is no Rhox in online db at gatherer: http://gatherer.wizards.com/Pages/Searc ... anced&set=[%22Starter+2000%22]Chris H. wrote:
I checked the listing and there appears to be 24 cards from 6th and 1 card form 8th (Rhox) that are missing.
The archive below contains HQ pics for these cards. They need to be run through the script/commands that will scale them down in size and saved at less than 100%. At that point they need to be added to the Starter 2000 cards folder at cardforge.
Rhox from 8ed can by no chance get into starter 2000 boosters, because the new card design was launched in 2002 only.
It is also present in S00 folder of hq pictures provided by CCGHQ.
About planechase - I hand to rename my PCH folder from CCGHQ download into HOP.
I personally don't like that 'hop' abbreviation, because didn't find any confirmation on the net of this being official edition code. Magic online for instance calls them PC1 (first planechase) and PC2 (for 2012)
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
32 posts
• Page 1 of 3 • 1, 2, 3
Who is online
Users browsing this forum: No registered users and 67 guests