Page 1 of 1
About removing Global Ruin

Posted:
19 Mar 2013, 10:06
by Max mtg
We have a harcoded spell Global Ruin that is the only user of a field:
forge.card.spellability.SpellAbility.beforePayMana
If we remove both the spell and that field, the code will become somewhat simplier.
What do you think?
Re: About removing Global Ruin

Posted:
19 Mar 2013, 12:17
by friarsol
As much as I'd love to just remove cards that were hardcoded poorly, it could break any number of decks and any number of quest modes. I'll put Global Ruin on the top of my convert to script list. (It was already near the top for other reasons)
Re: About removing Global Ruin

Posted:
19 Mar 2013, 17:33
by Max mtg
That's a pity we can't throw away poorly coded cards.
I'll await your action on global ruin.
And thank you for dealing with championing ability, the code looks neater now.
Re: About removing Global Ruin

Posted:
20 Mar 2013, 01:37
by friarsol
That converted a lot easier than I expected it to. I didn't do any cleanup with beforePayMana or other related things.
Re: About removing Global Ruin

Posted:
20 Mar 2013, 04:40
by Max mtg
Thank you, Sol! I have removed all reference to beforePayMana in r20489