Drawcardlib revisited

[gmzombie]

cant wait to see all of these new updates to this.

[Sonic]

I've also added support for Planes, too, also pointing at Token. They currently seem to all use 1FFF for their New Types 1 instead of 1005, though, so they end up using whatever Internal is configured to instead of Plane.

When we originally added the schemes, as they were set up in the ct_all as special effects, we just used the '* Elder Dragon Highlander' entry as a template for the Manalink file entries.

I could add the (1005) card types and (8000) plane type codes to the Manalink entries if you require. I'd need to add additional codes to the plane types as currently it only has codes for 30 of the cards. But no problem, if needed.

[Korath]

So long as New Types 1 or New Types 2 is 1005, they'll be drawn with whatever's configured as the plane frame. Though that's currently token, same as Internal.

I don't think anything looks at the plane subtypes, either in Manalink or in the actual rules; but they'll be helpful if and when I get around to displaying the type line according to what the card currently is instead of what it was printed as.

[Sonic]

So long as New Types 1 or New Types 2 is 1005, they'll be drawn with whatever's configured as the plane frame. Though that's currently token, same as Internal.

I don't think anything looks at the plane subtypes, either in Manalink or in the actual rules; but they'll be helpful if and when I get around to displaying the type line according to what the card currently is instead of what it was printed as.

OK. I'll add STYPES codes for the missing cards to the Plane Type 0x8000 code, and set up the manalink entries New Types 1 as 1005h and New Types 2 as 80xxh.

[Sonic]

OK. Just to prove I'm not just twiddling my thumbs in-between data insertions. I've come up with some frames for the planes. What do you all think?



I'll probably release a full set of test frames for those the Drawcardlib will currently handle in the next few days.

@Korath - Note to the GIT.

Added the planes 'Expansion Rarity' entries to the manalink.csv file.

[Korath]

What maintenance is currently needed here? Off the top of my head, I can think of:

1. ☑ Move expansion categorization - the bit that tells drawcardlib that EXPANSION_MAGIC_2015 is a core set, EXPANSION_THEROS is an expert set, and EXPANSION_MODERN_MASTERS is a reprint set, for the purposes of figuring out which expansion symbol and frame to use - into configuration, so the dll doesn't need to be recompiled with each patch (which hasn't been getting done).
2. ☑ Deduce CARD_ID_RULES_ENGINE at runtime (probably by searching for its cardname), for the same reason as #1.
3. ☑ Make watermarks configurable, so someone sufficiently motivated can add the ten from the Tarkir block.
   • Question: Have there been any cards that have two different watermarks in two different printings yet? For instance, did any cards printed with the Azorius watermark in one of the Ravnica sets get reprinted with the Ojutai watermark in one of the Tarkir sets? Or a Myrran- or Phyrexian-watermarked card that showed up in Tarkir? (I know about the cards that got printed with both variants of a given Ravnica guild watermark. Besides those.)
4. ☑ Add two more framesets, for M15 cards and M15 planeswalker cards. (Again, I'll leave the actual artwork to someone more motivated and with more free time.)
   • Question: Do all expansions after Magic 2015, by the ordering in the first line of manalink.csv, use these frames? Or do any need hardcoded exceptions like how the four Masters Editions sets use the classic frames?

What else is most glaringly missing?

(Oh, and have the vanguard and planechase frames been blessed into the mainline patches yet? I haven't downloaded a recent one, but I see they're still unconfigured in git.)

[Aswan jaguar]

Welcome back,nice to hear from you!
About the vanguard and planechase frames they are not in CardArt nor in the main folder so I guess they have not been released.
Unfortunately,I don't know anything about the other stuff you ask.

[gmzombie]

Welcome back Korath..are you back or just checking in? I dont think i can recall watermarks that shouldnt be there but last i checked the artwork was classic edition on khans and not what it should be.

[Korath]

Mostly checking in. The classic frames on Khans of Tarkir and later sets will be fixed with #1 above (already done). The reason I ask about watermarks is because, if a given card can only have one kind of watermark no matter which set it's printed with, it makes the back end a lot easier.

[gmzombie]

i quickly just went through the khans set in deckbuilder and didnt see any watermarks. just different set symbols because it dosent show the khans set symbol..

[Sonic]

I've already made some M15 frames, including the token. I was going to release them as an add on for the Manalink3 Makeover 2014 over Christmas, but I've been so busy of late I didn't get the time.
As they are currently only the Planeswalker has the hologram - but all the frames have provisions to include the hologram if required.

To be honest, even though the text boxes are physically larger on the paper stock M15 - once adapted to the game with all the elements in place (hologram, P/T box, Loyalty box), there's actually less space for the text than the modern frames.

[Korath]

Maybe extend them to reach the bottom of the card? We're not likely to have artist information there anytime soon, and even less likely to have proper set/collector number. Plus, replacing the WOTC trademark/copyright notice with an ad for the forum will be taken as even more offensive than just omitting it, as we do currently.

Guess I should add a frameset for rare/mythic m15 frames, too. Any reason to think we'll need a non-hologram version of the planeswalker one?

And - not that this matters particularly - what's the most accepted name for the frameset? Just "M15"?

[Korath]

Here you go.

This requires configuration changes to Menus.txt and Duel.dat, or you'll get a bunch of annoying errors on startup (since the watermarks listed in watermark.csv, as distributed with the mainline patches, are no longer hardcoded). If you're just using the configurations distributed with the patches and recent (Theros and later) full installations without change, you can download the config zipfile below instead.

add to Menus.txt (near the end, before @MULTIDECKTYPES) | Open

@EXPANSIONCATEGORIES
140
None (B) Block Each line should start with "None", "Core", "Expert",
None (T1) Vintage "Portal", "Reprint", "Casual", "Promo", "Box", or
None (T1.M) Modern "Decks", optionally followed by whitespace and a
None (T1.X) Extended comment. The first 8 entries, corresponding to the
None (T2) Standard game-format expansions, are ignored. The expansion
None (HI) Highlander names are unnecessary; they're only included to make
None (EDH) Commander keeping track of which category is which easier.
None (HI/EDH) Legal as Commander
Promo Promo
Core Limited Edition Alpha
Core Limited Edition Beta
Core Unlimited Edition
Expert Arabian Nights
Expert Antiquities
Core Revised Edition
Expert Legends
Expert The Dark
Expert Fallen Empires
Core Fourth Edition
Expert Ice Age
Reprint Chronicles
Expert Homelands
Expert Alliances
Expert Mirage
Expert Visions
Core Fifth Edition
Promo Astral
Portal Portal
Expert Weatherlight
Expert Tempest
Expert Stronghold
Expert Exodus
Portal Portal Second Age
Expert Urza's Saga
Expert Urza's Legacy
Core Classic Sixth Edition
Expert Urza's Destiny
Portal Portal Three Kingdoms
Portal Starter 1999
Expert Mercadian Masques
Box Battle Royale Box Set
Expert Nemesis
Portal Starter 2000
Expert Prophecy
Expert Invasion
Box Beatdown Box Set
Expert Planeshift
Core Seventh Edition
Expert Apocalypse
Expert Odyssey
Expert Torment
Expert Judgment
Expert Onslaught
Expert Legions
Expert Scourge
Core Eighth Edition
Expert Mirrodin
Expert Darksteel
Expert Fifth Dawn
Expert Champions of Kamigawa
Expert Betrayers of Kamigawa
Expert Saviors of Kamigawa
Core Ninth Edition
Expert Ravnica: City of Guilds
Expert Guildpact
Expert Dissension
Expert Coldsnap
Expert Time Spiral
Expert Planar Chaos
Expert Future Sight
Core Tenth Edition
Reprint Masters Edition
Expert Lorwyn
Decks Duel Decks: Elves vs. Goblins
Expert Morningtide
Expert Shadowmoor
Expert Eventide
Box From the Vault: Dragons
Reprint Masters Edition II
Expert Shards of Alara
Decks Duel Decks: Jace vs. Chandra
Expert Conflux
Decks Duel Decks: Divine vs. Demonic
Expert Alara Reborn
Core Magic 2010
Box From the Vault: Exiled
Casual Planechase
Reprint Masters Edition III
Expert Zendikar
Decks Duel Decks: Garruk vs. Liliana
Decks Premium Deck Series: Slivers
Expert Worldwake
Decks Duel Decks: Phyrexia vs. the Coalition
Expert Rise of the Eldrazi
Casual Archenemy
Core Magic 2011
Box From the Vault: Relics
Decks Duel Decks: Elspeth vs. Tezzeret
Expert Scars of Mirrodin
Decks Premium Deck Series: Fire and Lightning
Reprint Masters Edition IV
Expert Mirrodin Besieged
Decks Duel Decks: Knights vs. Dragons
Expert New Phyrexia
Casual Magic: The Gathering-Commander
Core Magic 2012
Box From the Vault: Legends
Decks Duel Decks: Ajani vs. Nicol Bolas
Expert Innistrad
Decks Premium Deck Series: Graveborn
Expert Dark Ascension
Decks Duel Decks: Venser vs. Koth
Expert Avacyn Restored
Casual Planechase 2012
Core Magic 2013
Box From the Vault: Realms
Decks Duel Decks: Izzet vs. Golgari
Expert Return to Ravnica
Casual Commander's Arsenal
Expert Gatecrash
Decks Duel Decks: Sorin vs. Tibalt
Expert Dragon's Maze
Reprint Modern Masters
Core Magic 2014
Box From the Vault: Twenty
Decks Duel Decks: Heroes vs. Monsters
Expert Theros
Casual Commander 2013
Expert Born of the Gods
Decks Duel Decks: Jace vs. Vraska
Expert Journey into Nyx
Decks Modern Event Deck
Casual Magic: The Gathering - Conspiracy
Reprint Vintage Masters
Core Magic 2015
Box From the Vault: Annihilation
Decks Duel Decks: Speed vs. Cunning
Expert Khans of Tarkir
Casual Commander 2014
Expert Fate Reforged

Add to DuelArt/Duel.dat (new section before Frames) | Open

[Watermarks]
;Watermark metaconfiguration. (The way watermarks are actually displayed on
;cards is controlled by the [FullCard]Watermark* settings above.) Can't be
;overridden for individual framesets.
;
;Watermark images should be in CardArt\watermarks.pic and consist of
;equally-tall rows of five equally-wide images each. The name of each
;watermark, and its placement within watermarks.pic, are specified in this
;section.
;
;Which cards get which watermarks is determined by .\watermarks.csv. Each line
;should consist of a card id number (from manalink.csv), a semicolon, and a
;watermark name; optionally followed by a semicolon and comment. If a negative
;number is seen for the id, no further lines are read - useful for documenting
;e.g. split cards with different watermarks on each half that can't be fully
;displayed right now. (Of course, those could have been done by picking one
;half to display and documenting the other half in the comment, but I chose to
;leave them entirely unwatermarked for now.)
;
;A card can only have one watermark specified for it. If there are multiple
;lines for a single card, the earlier ones are overwritten by the last.
;
;There are always two special entries defined for watermarks.csv: "Timeshift"
;and "Nyx". "Timeshift" means that a given card should be drawn with the
;Timeshift frame if it's being displayed with a Planar Chaos expansion symbol,
;or the Futureshift frame if it's being displayed with a Future Sight expansion
;symbol. "Nyx" means that it should be drawn with a Nyx overlay (from the
;Theros block) when the card is displayed in the deckbuilder, library,
;graveyard, etc. - everything but in-hand and in-play, which can be deduced
;from the card's types. Unlike real watermarks, a card can have either or both
;of "Timeshift" and "Nyx" specified in addition to another watermark; to do so,
;have multiple lines for the same card in watermarks.csv, one with Timeshift in
;the second column, one with Nyx, one with a watermark, as appropriate.
;
;
;Number of rows in CardArt\watermarks.pic.
;Defaults NumRows=4.
NumRows=4
;Number of columns in CardArt\watermarks.pic.
;Defaults NumColumns=5.
NumColumns=5
;Individual watermark definitions.
;
;Each defined watermark needs a name (to be looked for in the second column of
;watermarks.csv), a row number in watermarks.csv ranging from 1 to NumRows
;(from top to bottom), and a column number in watermarks.csv ranging from 1 to
;NumColumns (from left to right). Their keys are Name#, Row#, and Col#
;respectively, where # is an integer from 1 to 255. If any of the three is
;left unset, then the whole watermark is ignored.
;
;Names must be a single word consisting only of letters and perhaps numbers,
;and must start with a letter. They're not case sensitive.
;
;Each watermark can also have a list of expansions that it may appear in. If
;Expansions# is unspecified for a given watermark, it's always drawn for each
;card set to it. If it's a whitespace-separated list of expansion numbers (as
;defined in src/Expansions.h), then it's only drawn if that expansion symbol
;is. If it's the name of a previously-defined watermark, it uses that
;watermark's Expansions value. The point is so that, for example, Disperse can
;be drawn with the Mirran watermark on its Scars of Mirrodins printing, but not
;on its original Morningtide printing or later Magic 2014 reprint.
;([FullCard]WatermarkOutsideSet above can override.)
;
;In this config, the first row has large mana symbols for basic lands.
Name1=Black
Row1=1
Col1=1
;
Name2=Blue
Row2=1
Col2=2
;
Name3=Green
Row3=1
Col3=3
;
Name4=Red
Row4=1
Col4=4
;
Name5=White
Row5=1
Col5=5
;The second and third rows are Ravnica block guild watermarks. They all got
;changed somewhat for the Return to Ravnica block. I suppose these variants
;should be supported. I couldn't find usable art when putting these together,
;though and I'm frankly tired of trying to get these to look reasonably good
;without including two dozen different variants of each watermark (one for each
;background they can appear on). They'd need better support anyway, since
;multiple watermarks can't be specified for a given card currently.
Name6=Azorius
Row6=2
Col6=1
;Ravnica:City of Guilds, Guildpact, Dissension, Duel Decks:Izzet vs. Golgari,
;Return to Ravnica, Gatecrash, Dragon's Maze, Modern Masters.
Expansions6=56 57 58 109 110 112 114 115
;
Name7=Dimir
Row7=2
Col7=2
Expansions7=Azorius
;
Name8=Rakdos
Row8=2
Col8=3
Expansions8=Azorius
;
Name9=Gruul
Row9=2
Col9=4
Expansions9=Azorius
;
Name10=Selesnya
Row10=2
Col10=5
Expansions10=Azorius
;Col 3.
Name11=Orzhov
Row11=3
Col11=1
Expansions11=Azorius
;
Name12=Golgari
Row12=3
Col12=2
Expansions12=Azorius
;
Name13=Simic
Row13=3
Col13=3
Expansions13=Azorius
;
Name14=Izzet
Row14=3
Col14=4
Expansions14=Azorius
;
Name15=Boros
Row15=3
Col15=5
Expansions15=Azorius
;The fourth row has the Phyrexian and Mirran watermarks for the Scars of
;Mirrodin block.
Name16=Phyrexian
Row16=4
Col16=1
;Scars of Mirrodin, Mirrodin Besieged, New Phyrexia
Expansions16=91 94 96
;
Name17=Mirran
Row17=4
Col17=2
Expansions17=Phyrexian

The names of the three new framesets are Magic2015, Magic2015holo, and Magic2015planeswalker; they're configured just like the other framesets in the [Expansions] setting. Since there's no actual artwork included here, they default to using the pre-existing Modern.dat, Modern.dat, and Planeswalker.dat config files.

[edited to fix Menus.txt config, also broken in the mainline patch - see here]

[Korath]

Oh, and here's the psd I used to build the standard watermarks.pic file, so that, when someone gets motivated to add the Tarkir watermarks, they can look consistent.

[Sonic]

I've made a start on setting up a running install for the new dll with Magic2015, Magic2015holo, Magic2015planeswalker, Plane, and Vanguard frames - I've even changed the 'offensive' text on the frames to the original WotC copyright text.

I'm not sure I've got it setup entirely correctly as the card redraw speed has taken a complete nose dive - so I suspect I may have missed something in updating the dat files for the new dll. But I'll keep on with it until I find what's going on.