My to do list

[drool66]

Adding this here for a couple of reasons: first, as a backup in case I ever lose my notes & to do list; second, to create a log and keep notes on my work; and third to give some transparency on what's happening behind the scenes with Manalink, at least for my part.

---

1. card_ext - check send_to_drawcardlib.dll for Shandalar's data here; move extra subtypes, flags, etc. here
2. Trigger cards
-to transfer:
*-deal_combat_damage()
*-allow_response/_impl()
-*ending_phase()
-*switch_phase() (4398C0)

-also figure out any just_died things/ reap_just_died()
-to add
-has_strigger() ?
-has_trigger_on_stack()

2b.
Win the game conditions (as opposed to lose the game) viewtopic.php?f=86&t=30053 (done with main_phase(), just needs implementation with cards now)
2c. Implement kill_card_by()
2d. Death triggers to actual triggers, not the legacy accumulate and fire method we have now
2e. Update all card code to use trigger cards
3. Pay mana, charge for free, etc.
4. Interrupts to instants, can target anything on stack
5. copy & counter any abilities, spells, & triggers
5. Granted Activated abilities
6. Stack-based everything?
7. Ability loss by timestamp
8. manage EVENT_REMOVED_FROM_GRAVE for multiple cards being removed from grave; cards that do this one-by-one (ie. dispatch the event too many times) use remove_card_from_grave() as opposed to remove_card_from_grave_to_destination()
9. Chandra Ablaze Ultimate ability (see notes in code)
10. Move all traps to global arrays (see shandalar/buffer_data.h.in)
11. Fix multiple combat effects

Single unified legacy for "exiled with a X counter", or implement exile_source[] (much better)

Dont ennumerate ids for DIALOG, use a special targeting function, so select a legacy, not a huge dialog function.
Dauthi Voidwalker, Kianne, Dean of Substance, the Karn with Silver counters,
Also, make Nicol Bolas Dragon God more like Kasmina Enigma Sage in the same way

Procedural check against checking get_card_instance() before checking event
viewtopic.php?f=86&t=31151&p=252180#p252171

Added Rebound, Feather the Redeemed

karmic justice

kaervek's torch (ie. targeting before charging mana)
Fix Jester's Scepter to exile face down

EVENT_CARDCONTROLLED doesn't fire with all change of control effects

Fix all manlands to use animate_self() has_subtype_if_animated_self()

Erebos's Titan - switch to an event-based ability

Rakshasa Vizier - hackery out, event in

Combine Hostage Taker's legacies

Full Art PWs & tokens

Fix "By Force"

Update attached_creature_deals_damage() - regen status?

Muraganda Petroglyphs

Quicken

Figure out what needs XTRIGGER_REPLACE_ETB - see Grumgully the Generous vs. test_enters_the_battlefield_with_counters()

Stalking Vengeance isn't the source of damage for its ability

Add Goad to creatures & effects that have it - it was skipped over as irrelevant in 2-player, but in 2-player it means that the creature must attack

Keep sp_keyword by iid lists up to date
sp_keyword2 & 3 to pump_ability()