It is currently 15 Jun 2019, 23:38
   
Text Size

Draft Development in ML 3.0

Discuss Upcoming Releases, Coding New Cards, Etc.
PLEASE DO NOT REPORT BUGS HERE!

Moderators: BAgate, drool66, stassy, Aswan jaguar, gmzombie, CCGHQ Admins

Draft Development in ML 3.0

Postby foolosopher » 07 Feb 2012, 15:15

Hi guys,
I opened this topic to discuss how draft should continue. I took over its development for the time being and adjusted to the new rarity.dat the first two options "Enforce and Ignore Rarity", which work, but they make 15card packs with 1R + 3U +11C when enforcing rarity. It doesn't handle differently expansions without rares like Arabian Nights, so this also needs to be fixed.
I was wondering whether I should create 8-packs for relevant sets, but then I would have to count cards or make a limit around 45 cards and add packs accordingly.
Since now there are many sets, they should probably be moved in sets.txt and be loaded from there, when draft starts, this is currently what I do , so that they are loaded according to expansions.h, but because not all expansions are coded yet :wink: , I will limit the options to existing ones and load custom sets last.
Do we have a file that shows how many cards are coded from each set directly (not like the manalink.csv)?
Another thing, the "Draft" card does not always come up, after playing a game, one has to change game mode and go back to draft again, so that the "Draft" card, shows up, can we fix this?
And a weird thing, program execution after set selection is somehow reversed or scrambled, case in point in order to initialise the tables I use (in_set1[], set_rs[]) I had to place them after set selection, otherwise the sets were loaded first, any clue why that happens?
I did some testing, but they may require some more.
So shoot your comments, suggestions and ideas here. I will update the wiki as soon as I have some time.
Attachments
draft-v1-2012-02-07.rar
(57.47 KiB) Downloaded 455 times
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby foolosopher » 13 Feb 2012, 14:12

Hi,
Here's another version of draft, where support for custom sets is enabled. Same rules apply, custom set is made as .dck file.
I haven't converted previous custom sets to manalink 3.0, so if anyone has them please tell-post where to find them.
functions.c and manalink.h have a few modified function definitions.
Rarity for custom sets is disabled, because it cannot be defined in which set the cards from the customized one refer to and therefore their rarity cannot be defined. A solution to this could be to search and get the rarity of the set, where each card first shows up, but I don't think it's worth the hassle for the time being.
A check is also added when loading a set whether it has sufficient coded cards ie. 11+ Commons, 3+ Uncommons, 1+ Rares, otherwise the draft is ended and you need to restart choosing other sets. I found that Homelands, have this problem where only 8 commons are coded.
A couple things, the window where the choice for sets in draft is shown cannot hold all sets, so one needs to expand it or tell me how to do it.
I haven't checked which sets have sufficient coded cards, so if anyone has such a file (like set Commons, Uncommons, Rares) where such info is gothered, it would be helpful (I know that this is in manalink.csv but per card).
It also seems, that the sealed can be modified according to the draft implementation, to have the new cards, so if that's of interest let me know. If anyone (Snacko? :-" ) could rip relevant functions from the exe, I will help recode. Otherwise we won't have the fancy sealed graphics :mrgreen:
Attachments
2012-02-13-draft-custom-sets-enforce-ignore-check-OK-clean.rar
(56.48 KiB) Downloaded 383 times
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby CirothUngol » 14 Feb 2012, 01:46

WooHoo! I'm glad to see that somebody's diligently attempting to correct draft... it's just about my favorite way to play Manalink. Thanx!
I haven't converted previous custom sets to manalink 3.0, so if anyone has them please tell-post where to find them.
If you're referring to the Draft Sets from the latest Manalink Update, I ran those through the PlayDeck Analyser and I'll post them below.
Do we have a file that shows how many cards are coded from each set directly (not like the manalink.csv)?
I haven't checked which sets have sufficient coded cards, so if anyone has such a file (like set Commons, Uncommons, Rares) where such info is gathered, it would be helpful
...maybe 3 seperate PlayDecks for each expansion containing coded common, uncommon and rare cards? I'm sure I could rig the PDAnalyser to do that, if it'd be helpful. I'll try to look into that...
Attachments
20120128_DraftSets.zip
Draft Sets converted to Manalink 20120128 Update
(23.77 KiB) Downloaded 303 times
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter


My MtG Folder on DropBox, or Google Drive.
User avatar
CirothUngol
Programmer
 
Posts: 430
Joined: 13 May 2009, 21:34
Location: Gulf Coast, Texas, USA
Has thanked: 106 times
Been thanked: 103 times

Re: Draft Development in ML 3.0

Postby foolosopher » 14 Feb 2012, 13:02

Hey, nice to hear that someone is actually interested in draft. Thanks for posting the decks also. What I mean with a file with rarities about sets is plain numbers of how many cards are coded from each rarity type, mostly to just include them in the available choices, no need for separate playdeck folders and such.
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby CirothUngol » 16 Feb 2012, 13:55

I've built an "Export CSV as ExpRarity" routine into the PlayDeck Analyser, just for you. ^_^
It's slower than Christmas, but rather efficient. Here are the results:
Code: Select all
Expansion/Rarity Counts for Coded Cards in F:\My Documents\Just BASIC\PlayDeckAnalyser\CSV\20120128.csv
Generated by Manalink PlayDeck Analyser v0.2 on Thursday, March 01, 2012

Expansion Name                          Land Common Uncommon Rare Mythic Total
------------------------------------------------------------------------------
Limited Edition Alpha .................. 5 .. 73 ... 94 ..... 114  0 .... 286
Limited Edition Beta ................... 5 .. 74 ... 94 ..... 115  0 .... 288
Unlimited Edition ...................... 5 .. 74 ... 94 ..... 115  0 .... 288
Arabian Nights ......................... 0 .. 26 ... 19 ..... 30 . 0 .... 75
Antiquities ............................ 0 .. 26 ... 36 ..... 21 . 0 .... 83
Revised Edition ........................ 5 .. 75 ... 95 ..... 121  0 .... 296
Legends ................................ 0 .. 51 ... 84 ..... 97 . 0 .... 232
The Dark ............................... 0 .. 39 ... 43 ..... 31 . 0 .... 113
Fallen Empires ......................... 0 .. 36 ... 30 ..... 36 . 0 .... 102
Fourth Edition ......................... 5 .. 121 .. 121 .... 121  0 .... 368
Ice Age ................................ 5 .. 38 ... 30 ..... 41 . 0 .... 114
Chronicles ............................. 0 .. 31 ... 29 ..... 39 . 0 .... 99
Homelands .............................. 0 .. 5 .... 8 ...... 12 . 0 .... 25
Alliances .............................. 0 .. 14 ... 20 ..... 19 . 0 .... 53
Mirage ................................. 5 .. 39 ... 34 ..... 56 . 0 .... 134
Visions ................................ 0 .. 26 ... 21 ..... 33 . 0 .... 80
Fifth Edition .......................... 5 .. 126 .. 106 .... 112  0 .... 349
Astral ................................. 0 .. 0 .... 0 ...... 0 .. 0 .... 0
Portal ................................. 5 .. 21 ... 18 ..... 22 . 0 .... 66
Weatherlight ........................... 0 .. 31 ... 34 ..... 30 . 0 .... 95
Tempest ................................ 5 .. 62 ... 41 ..... 72 . 0 .... 180
Stronghold ............................. 0 .. 22 ... 20 ..... 27 . 0 .... 69
Exodus ................................. 0 .. 20 ... 20 ..... 32 . 0 .... 72
Portal Second Age ...................... 5 .. 16 ... 13 ..... 11 . 0 .... 45
Urza's Saga ............................ 5 .. 41 ... 57 ..... 80 . 0 .... 183
Urza's Legacy .......................... 0 .. 21 ... 27 ..... 33 . 0 .... 81
Classic Sixth Edition .................. 5 .. 78 ... 77 ..... 83 . 0 .... 243
Urza's Destiny ......................... 0 .. 14 ... 26 ..... 34 . 0 .... 74
Portal Three Kingdoms .................. 5 .. 1 .... 7 ...... 11 . 0 .... 24
Starter 1999 ........................... 5 .. 26 ... 23 ..... 13 . 0 .... 67
Mercadian Masques ...................... 5 .. 25 ... 16 ..... 11 . 0 .... 57
Battle Royale Box Set .................. 5 .. 41 ... 23 ..... 6 .. 0 .... 75
Nemesis ................................ 0 .. 9 .... 3 ...... 10 . 0 .... 22
Starter 2000 ........................... 5 .. 25 ... 4 ...... 0 .. 0 .... 34
Prophecy ............................... 0 .. 5 .... 3 ...... 5 .. 0 .... 13
Invasion ............................... 5 .. 27 ... 16 ..... 20 . 0 .... 68
Beatdown Box Set ....................... 4 .. 34 ... 11 ..... 9 .. 0 .... 58
Planeshift ............................. 0 .. 3 .... 9 ...... 11 . 0 .... 23
Seventh Edition ........................ 5 .. 87 ... 82 ..... 90 . 0 .... 264
Apocalypse ............................. 0 .. 6 .... 5 ...... 11 . 0 .... 22
Odyssey ................................ 5 .. 18 ... 17 ..... 17 . 0 .... 57
Torment ................................ 0 .. 5 .... 6 ...... 6 .. 0 .... 17
Judgment ............................... 0 .. 2 .... 7 ...... 15 . 0 .... 24
Onslaught .............................. 5 .. 18 ... 11 ..... 28 . 0 .... 62
Legions ................................ 0 .. 3 .... 5 ...... 8 .. 0 .... 16
Scourge ................................ 0 .. 0 .... 10 ..... 10 . 0 .... 20
Eighth Edition ......................... 5 .. 109 .. 109 .... 102  0 .... 325
Mirrodin ............................... 5 .. 31 ... 25 ..... 16 . 0 .... 77
Darksteel .............................. 0 .. 6 .... 10 ..... 10 . 0 .... 26
Fifth Dawn ............................. 0 .. 5 .... 10 ..... 15 . 0 .... 30
Champions of Kamigawa .................. 5 .. 9 .... 7 ...... 14 . 0 .... 35
Betrayers of Kamigawa .................. 0 .. 3 .... 6 ...... 5 .. 0 .... 14
Saviors of Kamigawa .................... 0 .. 1 .... 0 ...... 7 .. 0 .... 8
Ninth Edition .......................... 5 .. 81 ... 80 ..... 87 . 0 .... 253
Ravnica: City of Guilds ................ 5 .. 17 ... 13 ..... 21 . 0 .... 56
Guildpact .............................. 0 .. 11 ... 3 ...... 9 .. 0 .... 23
Dissension ............................. 0 .. 11 ... 10 ..... 11 . 0 .... 32
Coldsnap ............................... 0 .. 9 .... 26 ..... 20 . 0 .... 55
Time Spiral ............................ 5 .. 20 ... 11 ..... 25 . 0 .... 61
Planar Chaos ........................... 0 .. 10 ... 9 ...... 21 . 0 .... 40
Future Sight ........................... 0 .. 5 .... 7 ...... 19 . 0 .... 31
Tenth Edition .......................... 5 .. 72 ... 85 ..... 80 . 0 .... 242
Masters Edition ........................ 5 .. 48 ... 54 ..... 58 . 0 .... 165
Lorwyn ................................. 5 .. 13 ... 11 ..... 20 . 0 .... 49
Duel Decks: Elves vs. Goblins .......... 2 .. 9 .... 9 ...... 2 .. 0 .... 22
Morningtide ............................ 0 .. 6 .... 5 ...... 13 . 0 .... 24
Shadowmoor ............................. 5 .. 4 .... 13 ..... 13 . 0 .... 35
Eventide ............................... 0 .. 2 .... 4 ...... 11 . 0 .... 17
From the Vault: Dragons ................ 0 .. 0 .... 0 ...... 12 . 0 .... 12
Masters Edition II ..................... 0 .. 36 ... 44 ..... 41 . 0 .... 121
Shards of Alara ........................ 5 .. 20 ... 25 ..... 17 . 10 ... 77
Duel Decks: Jace vs. Chandra ........... 2 .. 10 ... 8 ...... 2 .. 2 .... 24
Conflux ................................ 0 .. 8 .... 6 ...... 14 . 4 .... 32
Duel Decks: Divine vs. Demonic ......... 2 .. 15 ... 14 ..... 2 .. 2 .... 35
Alara Reborn ........................... 0 .. 7 .... 9 ...... 7 .. 4 .... 27
Magic 2010 ............................. 5 .. 69 ... 49 ..... 39 . 13 ... 175
From the Vault: Exiled ................. 0 .. 0 .... 0 ...... 0 .. 15 ... 15
Planechase ............................. 5 .. 35 ... 21 ..... 18 . 0 .... 79
Masters Edition III .................... 5 .. 38 ... 47 ..... 53 . 0 .... 143
Zendikar ............................... 5 .. 101 .. 58 ..... 51 . 14 ... 229
Duel Decks: Garruk vs. Liliana ......... 2 .. 15 ... 11 ..... 2 .. 2 .... 32
Premium Deck Series: Slivers ........... 5 .. 7 .... 8 ...... 2 .. 1 .... 23
Worldwake .............................. 0 .. 13 ... 10 ..... 20 . 7 .... 50
Duel Decks: Phyrexia vs. the Coalition . 5 .. 13 ... 16 ..... 9 .. 1 .... 44
Rise of the Eldrazi .................... 5 .. 21 ... 11 ..... 22 . 10 ... 69
Archenemy .............................. 5 .. 26 ... 28 ..... 14 . 0 .... 73
Magic 2011 ............................. 5 .. 101 .. 59 ..... 51 . 15 ... 231
From the Vault: Relics ................. 0 .. 0 .... 0 ...... 0 .. 15 ... 15
Duel Decks: Elspeth vs. Tezzeret ....... 2 .. 20 ... 13 ..... 5 .. 2 .... 42
Scars of Mirrodin ...................... 5 .. 101 .. 58 ..... 52 . 13 ... 229
Premium Deck Series: Fire and Lightning  1 .. 7 .... 14 ..... 6 .. 0 .... 28
Masters Edition IV ..................... 3 .. 51 ... 55 ..... 84 . 0 .... 193
Mirrodin Besieged ...................... 5 .. 59 ... 38 ..... 34 . 10 ... 146
Duel Decks: Knights vs. Dragons ........ 3 .. 11 ... 13 ..... 4 .. 2 .... 33
New Phyrexia ........................... 5 .. 60 ... 58 ..... 31 . 10 ... 164
Magic: The Gathering-Commander ......... 5 .. 45 ... 51 ..... 39 . 8 .... 148
Magic 2012 ............................. 5 .. 101 .. 59 ..... 51 . 15 ... 231
From the Vault: Legends ................ 0 .. 0 .... 0 ...... 0 .. 12 ... 12
Duel Decks: Ajani vs. Nicol Bolas ...... 5 .. 10 ... 19 ..... 5 .. 2 .... 41
Innistrad .............................. 5 .. 107 .. 67 ..... 61 . 17 ... 257
Premium Deck Series: Graveborn ......... 1 .. 4 .... 9 ...... 5 .. 1 .... 20
Dark Ascension ......................... 0 .. 0 .... 0 ...... 0 .. 0 .... 0
Duel Decks: Venser vs. Koth ............ 0 .. 0 .... 0 ...... 0 .. 0 .... 0
Promo .................................. 0 .. 0 .... 0 ...... 6 .. 0 .... 6
------------------------------------------------------------------------------
Completed in 7 min, 37.548 sec

Total Coded Cards: 4435
...hope it helps. This function will be included in the next release.

Edit: Previous chart was incorrect. Replaced with (hopefully) correct one. (thanx to Aswan jaguar for pointing that out)
Last edited by CirothUngol on 02 Mar 2012, 04:49, edited 2 times in total.
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter


My MtG Folder on DropBox, or Google Drive.
User avatar
CirothUngol
Programmer
 
Posts: 430
Joined: 13 May 2009, 21:34
Location: Gulf Coast, Texas, USA
Has thanked: 106 times
Been thanked: 103 times

Re: Draft Development in ML 3.0

Postby BlueTemplar » 17 Feb 2012, 01:12

After I select the 3 boosters the game hangs. It seems to do it regardless of which option I choose or which boosters I take.

Draft works fine with Manalink 2.0 patched with the "latest" patch from 2011-04-01.

Do you think your version could fix that?
User avatar
BlueTemplar
 
Posts: 99
Joined: 04 Feb 2012, 22:47
Has thanked: 56 times
Been thanked: 10 times

Re: Draft Development in ML 3.0

Postby gmzombie » 17 Feb 2012, 12:39

anything pre 2kfix will work. that is why he is fixing up draft, and why harry pitfall is i believe trying to fix up sealed deck. as for online play well thats another story. dont know when that will get fixed.
can I maze of ith your snowstorm?

http://home.comcast.net/~gmzombie/index.html old stuff in here. don't use this stuff right now till I get time to get back into it and readjust.
gmzombie
 
Posts: 855
Joined: 26 Feb 2009, 01:05
Location: Wyoming, Mi
Has thanked: 199 times
Been thanked: 50 times

Re: Draft Development in ML 3.0

Postby BlueTemplar » 17 Feb 2012, 15:45

You could even draft in multiplayer?
User avatar
BlueTemplar
 
Posts: 99
Joined: 04 Feb 2012, 22:47
Has thanked: 56 times
Been thanked: 10 times

Re: Draft Development in ML 3.0

Postby gmzombie » 17 Feb 2012, 18:28

no I was just making the statement that multiplayer didn't work
can I maze of ith your snowstorm?

http://home.comcast.net/~gmzombie/index.html old stuff in here. don't use this stuff right now till I get time to get back into it and readjust.
gmzombie
 
Posts: 855
Joined: 26 Feb 2009, 01:05
Location: Wyoming, Mi
Has thanked: 199 times
Been thanked: 50 times

Re: Draft Development in ML 3.0

Postby foolosopher » 18 Feb 2012, 01:09

Hi, thanks, Ciroth, it seems that there are bits from almost every set. Anyway, i 've put in some checks so there won't be any hang ups, but singleton will be available only for a few sets, since there are required 120 different cards at least for a set to be playable in singleton. Also for custom sets the card limit is 1000 cards per set.
The parts that I posted already are working but I guess they will be included in the next release.
Gargaroz what do you think about that?
I have completed singleton and some necessary rarity checks, but forgot the code in my other PC, so I guess I will post all together once I finish rotiserie, which should be in about a week from now and then bug fixing, although due to my supreme skills there shouldn't be any bugs :mrgreen: .
Oh #-o and update the wiki...
Has anybody tested anything that I posted yet?
I can provide a manalinkex.dll if you want, the only thing is that I 've been using the 20120128 update, so you 'll be using the cards available at that time.
Once I finish I 'll check with Harry if I can help with sealed, otherwise I 'll go to gmzombie and post 2k to see if there are any cards to disassemble and move to c.
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby foolosopher » 25 Feb 2012, 00:47

Hi,
I didn't have much time so rotiserie will be a bit delayed but here's singleton along with a few checks, as I said.
The dll is also included for anyone wanting to test and
it would be nice to know if you found any bugs.
Attachments
draft-v16-Rarity-checks-singleton-clean.rar
(417.7 KiB) Downloaded 367 times
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 25 Feb 2012, 10:12

Thanks for all your work foolosopher,please mention to your updates that all previous posted files are needed to make this work or better attach to your last update all files needed because I got confused I thought all I need is the last file and only when I got repeated errors in Singleton I downloaded the other files,too.
What I do wrong in Singleton only alpha,beta and unlimited seems to have enough cards is that correct?

The decks after draft are not saved it's not implemented yet or I am doing something wrong?
All files have to be in draft-sets?
Keep up the good work.
---
Just playtesting.
User avatar
Aswan jaguar
Super Tester
 
Posts: 6302
Joined: 13 May 2010, 12:17
Has thanked: 532 times
Been thanked: 274 times

Re: Draft Development in ML 3.0

Postby foolosopher » 25 Feb 2012, 23:45

Thanks for the feedback, the dll I posted was the one I use for testing, that's why you couldn't find your drafted decks. Try the new attached file.
The previous files are needed in case you try to recompile and produce the manalinkEh.dll on your own. Normally the dll should work with the latest .dat files, although I use the previous ones.
Aswan jaguar wrote:What I do wrong in Singleton only alpha,beta and unlimited seems to have enough cards is that correct?
Hmm... For me Legends and a few others work, apart from those you mention, the requirement here is that a set to be usable in Singleton has to have at least 120 (different) coded cards. Better check Ciroth's stats about sets.
Aswan jaguar wrote:The decks after draft are not saved it's not implemented yet or I am doing something wrong?
All files have to be in draft-sets?
Some times you need to go to the deck builder, open up a drafted deck and save it. Then all drafted decks appear (usually :roll: ).
In draft-sets, only the custom sets need to be, but you also have to add them in the .txt .
Only thing here is that the buffer reading draft-sets.txt has a fixed size, so if you add too many, it will hung (note: I need to make this bigger or dynamically allocate space...)
Try the new file and tell me how it goes
Attachments
ManalinkEh-draft-v16.rar
(411.29 KiB) Downloaded 359 times
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 26 Feb 2012, 10:39

In order to make more sets playable in Singleton can you make a window where we can choose draft with less players (human+5AI)=6 so there will be the need for only 90 different cards?

Also probably Jatill had made a clean draft decks button in switcher before, that cleaned up the draft decks after you played draft so you didn't do that manually can you make that.
---
Just playtesting.
User avatar
Aswan jaguar
Super Tester
 
Posts: 6302
Joined: 13 May 2010, 12:17
Has thanked: 532 times
Been thanked: 274 times

Re: Draft Development in ML 3.0

Postby foolosopher » 26 Feb 2012, 23:58

Hi, I see what you mean, 90 card limit, will allow playing with a few more sets. Maybe we should plan for the cards under development to reach this limit, Gargaroz, what do you think about that?
This is probably useful for sealed also.
It is doable, but will take some more time.

As for the button, this bit of functionality is a script, and shouldn't have changed (I didn't change it) so I guess I will check with Gargaroz or Jatill about it.
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Next

Return to Development

Who is online

Users browsing this forum: No registered users and 2 guests


Who is online

In total there are 2 users online :: 0 registered, 0 hidden and 2 guests (based on users active over the past 10 minutes)
Most users ever online was 287 on 31 Mar 2019, 04:11

Users browsing this forum: No registered users and 2 guests

Login Form