Draft Development in ML 3.0
Discuss Upcoming Releases, Coding New Cards, Etc.
PLEASE DO NOT REPORT BUGS HERE!
PLEASE DO NOT REPORT BUGS HERE!
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
Re: Draft Development in ML 3.0
by Aswan jaguar » 27 Feb 2012, 13:41
CirothUngol about the list with cards and rarities there are some inconsistencies either in what the playdeck analyser reported or the csv.
The most obvious at least are:
Alpha series coded 274 of 295 printed cards
Beta series coded 288 of 302 printed cards
Unlimited coded 288 of 302 printed cards
Since alpha and beta-unlimited have the same cards plus 7 more for beta-unlimited the numbers don't fit.
The Dark set coded 122 of 119 printed cards !!!
From the Vault Exiled coded 16 of 15 printed cards
From the Vault Relics coded 16 of 15 printed cards
Is it possible and easy to make draft-set-decks for every available set with playdeck analyser?it would be great if you could do so.
-@foolosopher shouldn't the rarity not be enforced in singleton like it was before because now although some sets have sufficient number of cards 120 and more rarity makes them unplayable at least the error report says so.
EDIT-foolosopher wrote:
Singleton isn't working meaning that 2 copies of a single card are drafted many cases I had 2 of a kind and sometimes opponent even had the same card.
In Singleton you should make the draft check first the decks with fewest cards coded 120 and above then if sets have same cards the ones with most should replace the duplicate cards with others so more sets are available.
The most obvious at least are:
Alpha series coded 274 of 295 printed cards
Beta series coded 288 of 302 printed cards
Unlimited coded 288 of 302 printed cards
Since alpha and beta-unlimited have the same cards plus 7 more for beta-unlimited the numbers don't fit.
The Dark set coded 122 of 119 printed cards !!!
From the Vault Exiled coded 16 of 15 printed cards
From the Vault Relics coded 16 of 15 printed cards
Is it possible and easy to make draft-set-decks for every available set with playdeck analyser?it would be great if you could do so.
-@foolosopher shouldn't the rarity not be enforced in singleton like it was before because now although some sets have sufficient number of cards 120 and more rarity makes them unplayable at least the error report says so.
EDIT-foolosopher wrote:
The button existed in Limited-tools (as the deckbuilder is) it was the only version that draft worked but as we used constructed? for Manalink 3.0 it got lost unless it was gone with the changes made to Manalink 3.0.As for the button, this bit of functionality is a script, and shouldn't have changed (I didn't change it) so I guess I will check with Gargaroz or Jatill about it.
Singleton isn't working meaning that 2 copies of a single card are drafted many cases I had 2 of a kind and sometimes opponent even had the same card.
In Singleton you should make the draft check first the decks with fewest cards coded 120 and above then if sets have same cards the ones with most should replace the duplicate cards with others so more sets are available.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: Draft Development in ML 3.0
by foolosopher » 29 Feb 2012, 11:59
For cleaning the draft decks, we will either need to add a button if possible, or I might add it as an option when draft starts.
About singleton, there is a posibillity that a card appears twice (maybe even more) in case that card is reprinted in various sets and these reprints have different card IDs, since only card_id is checked so far. Any idea what should be done for card reprints, wanted.
About singleton, there is a posibillity that a card appears twice (maybe even more) in case that card is reprinted in various sets and these reprints have different card IDs, since only card_id is checked so far. Any idea what should be done for card reprints, wanted.
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Re: Draft Development in ML 3.0
by CirothUngol » 29 Feb 2012, 14:09
Thanx for pointing that out. I had made a error parsing the fields from the Manalink.csv in that routine, it's fixed now (and I replaced the chart in my previous post).about the list with cards and rarities there are some inconsistencies...
Sure. Please take a look at the attached PlayDecks and see if you can spot anything wrong with 'em. If you do, mention it in the PDAnalyser thread so I can try to fix it.Is it possible and easy to make draft-set-decks for every available set with playdeck analyser?
Thanx again for spotting my glaring error, otherwise I may have never noticed.
- Attachments
-
- DraftSets_20120128_1stAttempt.zip
- DraftSets for Manalink 20120128 Update - 1st Attempt
- (133.16 KiB) Downloaded 303 times
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-
CirothUngol - Programmer
- Posts: 431
- Joined: 13 May 2009, 21:34
- Location: Gulf Coast, Texas, USA
- Has thanked: 106 times
- Been thanked: 106 times
Re: Draft Development in ML 3.0
by foolosopher » 29 Feb 2012, 19:12
Hey CirothUngol, is it possible that you post your stats as a csv file?
And, guys, the cards of Standard sets are checked directly from the dat-csv, no need to add the relevant .dck files in draft-sets. The dck files are only needed for custom sets.
Also, rarity in not used in Singleton.
And, guys, the cards of Standard sets are checked directly from the dat-csv, no need to add the relevant .dck files in draft-sets. The dck files are only needed for custom sets.
Also, rarity in not used in Singleton.
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Re: Draft Development in ML 3.0
by CirothUngol » 01 Mar 2012, 13:53
...something like this?
- Code: Select all
Expansion Name;Land;Common;Uncommon;Rare;Mythic;Total;UnCoded
Limited Edition Alpha;5;73;94;114;0;286;3
etc.
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-
CirothUngol - Programmer
- Posts: 431
- Joined: 13 May 2009, 21:34
- Location: Gulf Coast, Texas, USA
- Has thanked: 106 times
- Been thanked: 106 times
Re: Draft Development in ML 3.0
by Aswan jaguar » 01 Mar 2012, 14:35
Foolosopher wrote:
I asked CirothUngol for those and kindly made them to be able to make then custom sets to play, combining into 1 custom set some of the sets with small number of cards and thus making them playable.And, guys, the cards of Standard sets are checked directly from the dat-csv, no need to add the relevant .dck files in draft-sets. The dck files are only needed for custom sets.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: Draft Development in ML 3.0
by foolosopher » 01 Mar 2012, 23:12
@CirothUngol: That 'd be great.
@Aswan jaguar: Ah, now I see what you mean, nice thinking. I could also add random cards from all coded cards or certain sets, but this way you save me some trouble. Makes the checks a bit obsolete, but better be on the safe side
Anyone any idea how to handle reprinted cards?
@Aswan jaguar: Ah, now I see what you mean, nice thinking. I could also add random cards from all coded cards or certain sets, but this way you save me some trouble. Makes the checks a bit obsolete, but better be on the safe side
Anyone any idea how to handle reprinted cards?
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Re: Draft Development in ML 3.0
by CirothUngol » 02 Mar 2012, 05:54
Here ya go.
- Attachments
-
- 20120128_ExpRarity.zip
- Manalink 20120128 Update Expansion Rarity .txt and .csv
- (4.68 KiB) Downloaded 282 times
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-Lucilde Fiksdotter
Shandalar 2012 Revisited
Magic: The Gathering Abandonware
-
CirothUngol - Programmer
- Posts: 431
- Joined: 13 May 2009, 21:34
- Location: Gulf Coast, Texas, USA
- Has thanked: 106 times
- Been thanked: 106 times
Re: Draft Development in ML 3.0
by Gargaroz » 03 Mar 2012, 14:09
Guys, I want to release a patch during next week : apart form the code, what files I need to attach among the ones you posted ? There's anything final ?
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
- Gargaroz
- Programmer
- Posts: 7097
- Joined: 06 Nov 2009, 11:11
- Has thanked: 82 times
- Been thanked: 595 times
Re: Draft Development in ML 3.0
by foolosopher » 06 Mar 2012, 09:58
Hi, Gargaroz,
In the latest patch I uploaded, there is Singleton and num players (6-8) options added and working as far as I tested it.
When choosing 6 players will allow sets with at least 90 different coded cards.
In the clean draft.c version most of the error and debugging messages are removed, otherwise one can use the other draft.c file, but also create a vagtest.txt file in the C:\Magic\Program
folder, for the messages to be written. The manalinkEh.dll I include is made with the clean draft.c
You can also include the draftsets, posted by CirothUngol to be used, but we need to clarify what kind of cards are added, in a set to be playable.
One more thing, not all sets can be added in the draft-sets.txt, cause the buffer size is 500 bytes. Anyway if one puts more than it fits and blows, you can just delete a few lines of sets and it should work.
I don't know if I will make your release date for rotiserie, sorry guys but I'm busy these days.
Where will bugs for draft, be posted?
Oh, and CirothUngol, thanks for posting your csv
In the latest patch I uploaded, there is Singleton and num players (6-8) options added and working as far as I tested it.
When choosing 6 players will allow sets with at least 90 different coded cards.
In the clean draft.c version most of the error and debugging messages are removed, otherwise one can use the other draft.c file, but also create a vagtest.txt file in the C:\Magic\Program
folder, for the messages to be written. The manalinkEh.dll I include is made with the clean draft.c
You can also include the draftsets, posted by CirothUngol to be used, but we need to clarify what kind of cards are added, in a set to be playable.
One more thing, not all sets can be added in the draft-sets.txt, cause the buffer size is 500 bytes. Anyway if one puts more than it fits and blows, you can just delete a few lines of sets and it should work.
I don't know if I will make your release date for rotiserie, sorry guys but I'm busy these days.
Where will bugs for draft, be posted?
Oh, and CirothUngol, thanks for posting your csv
- Attachments
-
- draft-2012-03-6.rar
- (587.47 KiB) Downloaded 294 times
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Re: Draft Development in ML 3.0
by jatill » 13 Mar 2012, 18:25
Can you tell me if this code was integrated into the latest release?
I tried drafting using a custom set, but the cards that appear are not at all the cards in my deck file that I just created.
Thanks.
I tried drafting using a custom set, but the cards that appear are not at all the cards in my deck file that I just created.
Thanks.
Apps by jatill: http://www.slightlymagic.net/wiki/Other_Apps_by_jatill
Re: Draft Development in ML 3.0
by foolosopher » 14 Mar 2012, 22:56
Hi jatill,
AFAIK from what Gargaroz said, the code is included in the 10 March 2012 : Dark Ascension update. But the load_custom_set code is mostly the same, I just store the extracted card_ids in a different table and worked fine as far as I tested it. Did you update the card_IDs of the custom set with the latest release, because I read that many cards'IDs were shifted about 170 positions?
You can check the draft.c if you want too. I know I will...
AFAIK from what Gargaroz said, the code is included in the 10 March 2012 : Dark Ascension update. But the load_custom_set code is mostly the same, I just store the extracted card_ids in a different table and worked fine as far as I tested it. Did you update the card_IDs of the custom set with the latest release, because I read that many cards'IDs were shifted about 170 positions?
You can check the draft.c if you want too. I know I will...
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Re: Draft Development in ML 3.0
by Gargaroz » 16 Mar 2012, 00:12
I included the latest code before making the release, but you couldn't really ask me to playtest limited, I don't like it
And yes, with Dark Ascension all cards from M10, M11 and M12 were shifteed.
And yes, with Dark Ascension all cards from M10, M11 and M12 were shifteed.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
- Gargaroz
- Programmer
- Posts: 7097
- Joined: 06 Nov 2009, 11:11
- Has thanked: 82 times
- Been thanked: 595 times
Re: Draft Development in ML 3.0
by jatill » 19 Mar 2012, 19:57
Here's the line that needs to change to make custom sets work:
if( set > 7 ){ -- change from 13
load_custom_set(num_set,set);
return;
}
if( set > 7 ){ -- change from 13
load_custom_set(num_set,set);
return;
}
Apps by jatill: http://www.slightlymagic.net/wiki/Other_Apps_by_jatill
Re: Draft Development in ML 3.0
by foolosopher » 20 Mar 2012, 15:36
Ah.. you 're right, I was looking into the functionality of loading the cards and forgot all about that , thanks!!
BTW do you (or anyone) have any idea how to expand the window which shows the available sets?
Does anyone know if Harry P. did anything with sealed?
BTW do you (or anyone) have any idea how to expand the window which shows the available sets?
Does anyone know if Harry P. did anything with sealed?
I long for the time where one man could make a difference...
- foolosopher
- Posts: 189
- Joined: 19 May 2010, 20:53
- Location: Greece
- Has thanked: 13 times
- Been thanked: 17 times
Who is online
Users browsing this forum: No registered users and 18 guests