Page 20 of 39

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 11 Jan 2018, 08:19
by aidscoi168
Rival of Ixalan update in json data file, i'm uploading 123 new artworks for this set and in process finding other 89 artworks

Mtgdb.Gui v3.0.9.6

PostPosted: 12 Jan 2018, 07:20
by hidalgo
New RIX Rivers of Ixalan set.

Mtgdb.Gui v3.1.0.0 alignment in Search result and Deck

PostPosted: 14 Jan 2018, 04:19
by hidalgo
That was bothering me since the very beginning. The problem of laying out cards depending on available horizontal or vertical space.
The solution had to serve two conflicting purposes:

  • reduce large empty horizontal or vertical space when it's just not enough to show one more row or column
  • text or image truncated when the space is considered enough to display almost-entirely-fitting row or column of cards

I was never able to come up with a solution good enough so I would say "that's the right way to do this!".
Eventually I did what I did because I've come to believe ther will be no such silver bullet.

align_before.jpg
the top right card is truncated

align_after.jpg
after hitting align button if is fully displayed

align_center.jpg
When there is excessive space to display the cards, they are aligned by center
center

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 14 Jan 2018, 15:39
by aidscoi168
Thanks you for this good new feature, i'm alway got mad about change setting for display to show the 2nd card without lose bottom part ( the number of copy in deck/collection is hard to see ) but nothing working, atleast with align feature i can choose how to display cards and thier infomations for my specific purposes ( copy card's name for naming artwork or check copy number/collection to build deck from real cards pool ). Also i notice that after update with ver 3.0.9.6 and now 3.1 the app lost infomation about collection that i think include in all the history files, i have to manual add collection with the file i save before and re-add the new cards at the momment. Do you think we better split collection list into 1 individual file that not affect when update to new version of Mtgdb.Gui ?

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 15 Jan 2018, 01:16
by hidalgo
after update with ver 3.0.9.6 and now 3.1 the app lost infomation about collection
I am really sorry for that bug!
Fixed in 3.1.0.1, thank you for reporting this and other bugs too, your help is invaluable!

Do you think we better split collection list into 1 individual file
Recently I was thinking about the problem of tracking collection and other non-tab-local
settings (language, show/hide tooltips) in the same history files with settings relative to
one tab only.

While separarting collection to its own file is better solution than the present one, it would
still not solve the problem of bugs like you just reported, when collection is not loaded from
history on program startup.

No matter where the collection is stored, there is still a need to undo/redo the changes you make to it.
If so, then the history file must contain a reference to a collection state, if not the state itself like it does now.

Suppose you have history\collection.json
Code: Select all
{
  "states": [
    {"some card id": 4, "some other id": 1, ...},
    {...},
    ...
  ]
}
then in history\0.json (1st tab history file) you would have
Code: Select all
 {
  "SettingsHistory": [
    { "Collection": 0, "Language": "en", ... },
    { "Collection": 1, ... },
    ...
  ],
  "SettingsIndex": 10
}
where "Collection": 1 tells you to look at collection.json, find the state #1 and load it.

So in principle the problem does not go away: as long as you are allowed to undo/redo collection changes, the program must use 0.json to figure out what is your collection, no matter if the actual collection state is stored in 0.json or in a separate file collection.json.

Then still there is a possibility for me to screw the code so that it forgets to load the collection state from history when starting the program.

Anyway, I believe I will eventually separate the collection, as well other settings not relative to a specific tab to a separate file,
because it is a more correct way to storing them and may prevent some other errors in the future.

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 04 Feb 2018, 15:52
by aidscoi168
Hi, i already update to newest version but it look like the app not save the most recent history. whenever i open the app, result is not recent but days before ( maybe before 3.1.0.5 )

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 05 Feb 2018, 01:08
by hidalgo
aidscoi168 wrote:Hi, i already update to newest version but it look like the app not save the most recent history. whenever i open the app, result is not recent but days before ( maybe before 3.1.0.5 )
Hi, I cannot reproduce this on my PC

For example, I:
open Mtgdgb.Gui
add a card to deck
restart Mtgdb.Gui
The added card is in the deck

My current version is v3.1.0.5

0. Make sure the link you are using is pointing to the last version:
Right-click the shortcut Mtgdb.Gui.lnk, in context menu choose `Properties`, choose `Shortcut` tab.
`Target` and `Start in` fields should contain `v3.1.0.5`
1. Make sure Mtgdb.Gui process actually ends after you close the application:
Start Mtgdb.Gui, wait until the loading is complete.
Open windows Task Manager (default) or any other program you have to monitor running processes.
Find mtgdb.Gui.exe in a list of running processes.
Close Mtgdb.Gui window
See if Mtgdb.Gui process disappears from the list of running processes as expected.
2. Please send me .zip files with \logs and \history directories

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 23 Feb 2018, 02:46
by aidscoi168
Hi, i notice the card count status in same main tab not consistent between main deck and side deck. As in real life we bring both decks and if the main deck have all the available cards of specific card from the collection, the side deck won't able to add these card until them available again, it's just need to affect cards in the collection, other cards can set as 4 copy maximum from both main and side deck. It's make collection management and deck building close to real life as possible.

Every feature quite easy to use but setting up the app still can make normal peoples confuse, can we make a setting panel that have browsing option so user can customize if need ( as HQ cards images take lot of space, maybe need store in different disk, in my case after got issue with antivirus software the folder for artworks folder and app not same place as before) by point to and choose folder for card images or artworks ..ect then the app will automatic write that link to xml file. And mark option for :
WatchFile Mode
SuggestImageDownloader Enabled
AllowPartialCards
ShowTextualFields
ShowDeck
TransparentCornersWhenNotZoomed

other option with value like Undo MaxDepth and CacheCapacity we have default value but still give user chance to custom by type number they prefer due to their need. As from 3.1.0.8 we have hide show filter i don't think card and zoom size will need to customable ( and i really love this update, no more using align feature to both check card available in collection and their name ). Other setting for link to app download, card images and artwork, data file is hidden and untouchable. :D

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 23 Feb 2018, 12:35
by hidalgo
it's just need to affect cards in the collection, other cards can set as 4 copy maximum from both main and side deck
I think whether the card is in collection or not is not relevant.
The important thing that needs to be fixed, is that Mtgdb.Gui does not help you notice
when cards from the main deck and sidboard in total exceed 4.

I will add some kind of visual indication, similar to when the card is illegal in selected match format.
Just not letting you add these cards is inconvenient, because it would force you to
first delete the cards in sideboard
then add to main deck
The user should be able to remove / add in either order he prefers.

the app still can make normal peoples confuse
...
As from 3.1.0.8 we have hide show filter i don't think card and zoom size will need to customable
They are not customizable anymore. You still see them in your config because it does not get overriden when installing new version to preserve your
custom settings.

If you open etc\Mtgdb.Gui.xml from downloaded .zip you will see they are gone.

what is still there:
Code: Select all
<SuggestImageDownloader Enabled="True" /> : easy to change
<Undo MaxDepth="1000" /> : easy to change
<ImageCache CacheCapacity ="900"/> : easy to change
<ImageLocations ... > : comlicated, requires a lot of attention and practice
With easy settings such as SuggestImageDownloader, It's not a big deal to type the new value in text editor,
considering that a `normal` user does not really have a need to change it.

With difficult settings such as `ImageLocations` I feel like whatever UI I can come
up with is either incomplete or costs me too much more effort.

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 15:04
by aidscoi168
Hi, is that forge deck format (*.dck) not allow 100 cards deck ( commander deck ) ? i try to save deck to forge by mtgdb.gui but nothing happen.

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 15:22
by aidscoi168
if you can fix the limited in save as file, maybe fix the limited in load deck from clipboard feature too ? :D

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 15:22
by hidalgo
Hi, I tried to save this one
And it worked ok, see attached file.

Please send me your deck (Use Ctrl+C to copy the deck as a text)
and the logs.

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 15:32
by aidscoi168
Already update to newest version but don't know why i can use the Ctr+C funtion to copy deck to text, just send you the json file that i the only one format i can save, also the log file to find out what wrong

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 17:55
by hidalgo
The Deck data structure somehow became corrupted. It's not easy to figure out how exactly it has happened.
I would like to know how the deck was created. Did you load it from file, drag-n-dropped or pasted it from
somewhere or created it manually by right clicking the cards?

Re: Mtgdb.Gui: search MTG cards, build decks, manage collect

PostPosted: 26 Feb 2018, 17:57
by aidscoi168
I just drag and dropped cards from current sets, trying to make a commander deck by mtgdb.Gui