Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers Programming Talk
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers Programming Talk
Overload at 95%
Moderator: CCGHQ Admins
Overload at 95%
by braquio » 18 Aug 2014, 11:59
Hi People!
I'm back with overload, i have a Cyclonic Rift aproximation at 95%.
The minor problem is that u can always play the spell at normal cost when it supose that u need a valid target, but if u do it nothing hapens so its ok.
And the real problem is that when u play it at normal cost the trigger fire 2 times instead 1, and i dont know why, cuase have <CLEANUP fire_once="1" />.
Except these problems works well.
some ideas to resolve the trigger fire?
I'm back with overload, i have a Cyclonic Rift aproximation at 95%.
- | Open
The minor problem is that u can always play the spell at normal cost when it supose that u need a valid target, but if u do it nothing hapens so its ok.
And the real problem is that when u play it at normal cost the trigger fire 2 times instead 1, and i dont know why, cuase have <CLEANUP fire_once="1" />.
Except these problems works well.
some ideas to resolve the trigger fire?
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by thefiremind » 18 Aug 2014, 12:13
You are creating the delayed trigger in a filter-based RESOLUTION_TIME_ACTION, so you are creating one for each filtered card. What you want to do is probably the following:
- Code: Select all
<RESOLUTION_TIME_ACTION filter_id="1">
if LinkedDC():Get_Int(50) == 1 and FilteredCard() ~= nil then
FilteredCard():PutInHand()
end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
if LinkedDC():Get_Int(50) ~= 1 then
MTG():CreateDelayedTrigger(2, nil) -- you can pass nil if you don't need any DC
end
</RESOLUTION_TIME_ACTION>
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 721 times
Re: Overload at 95%
by braquio » 18 Aug 2014, 12:24
Oh Great!
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by braquio » 18 Aug 2014, 12:50
Well now we can play with OVERLOAD cards!
May be not at fully work, but at least at 98%.
i see another minor problem, is that cause u do the target after the spell is resolved, if u want to counterspell it u have to do it without known the target.
May be not at fully work, but at least at 98%.
i see another minor problem, is that cause u do the target after the spell is resolved, if u want to counterspell it u have to do it without known the target.
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by braquio » 18 Aug 2014, 12:53
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by NeoAnderson » 21 Aug 2014, 14:30
braquio wrote:Well now we can play with OVERLOAD cards!
May be not at fully work, but at least at 98%.
i see another minor problem, is that cause u do the target after the spell is resolved, if u want to counterspell it u have to do it without known the target.
Cannot use Counterspell properly is not minor bug, it could be fatal during the game. Anyway this bug can be fixed.braquio wrote:Here the complete code:
I have made a revised version who fixes some bugs, but it still encounters some issues.
Fixes :
1. Now you can Counterspell the card after Target declared.
2. Partial fixed the issue about the normal cast without target :
---Now you can cast it if there is at least one no-land targetable permanent without shroud or hexproof.
---The problem is if you have enough mana to cast overload, it still give you the possibility to choose normal cast also if there are no targetable permanents.
3. The main effect is applied into Spell block.
Known bugs still unsolved :
1. If you use a Copy spell like : Increasing Vengeance the copy will not allow you to select a target.
- Cyclonic Rift - NeoRev. 0.1 | Open
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Overload at 95%
by braquio » 21 Aug 2014, 15:22
Well this go better 
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by RiiakShiNal » 23 Aug 2014, 12:59
I can't see any way to fix the problem with not being able to select new targets for the copy as the only way to fix that is to put the TARGET block in the SPELL_ABILITY, but that causes other problems for overload.
Well, Cyclonic rift still has problems:
I don't see any way to resolve all the problems, so as I said before making overload properly (even with an approximation) can't be done. There are just too many interaction problems that are created by any approximation we can come up with.
Well, Cyclonic rift still has problems:
- (Easy fix) The filters are set wrong, it will also consider/return invisible tokens (such as the planeswalker manager, mana tokens, etc...) to their owner's hands (at which point they will cease to exist). You should instead do a positive check for all card types except land instead of the negative check for land.
- Normal casting will not trigger effects that depend on a spell targeting a creature (such as Heroic, Avoid Fate, etc...). The only way to fix this is to put the TARGET block into the SPELL_ABILITY, but this causes other problems for overload.
- If the target becomes illegal before the spell resolves (such as gaining Shroud, Hexproof, or some other effect) then it should counter a normal cast Cyclonic Rift, but with your code that won't happen. Again, the only way to fix this is to put the TARGET block in the SPELL_ABILITY, but this causes other problems for overload.
- (Easy Fix) Due to protecting the card pointer targeted in the delayed trigger it will even affect cards that have left the battlefield (for example if the opponent sacrificed them to another effect, they would still effectively end up in their hand again). To fix simply remove the Protect_CardPtr() call.
I don't see any way to resolve all the problems, so as I said before making overload properly (even with an approximation) can't be done. There are just too many interaction problems that are created by any approximation we can come up with.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Overload at 95%
by braquio » 23 Aug 2014, 17:31
I'll see to fix.RiiakShiNal wrote:
- (Easy fix) The filters are set wrong, it will also consider/return invisible tokens (such as the planeswalker manager, mana tokens, etc...) to their owner's hands (at which point they will cease to exist). You should instead do a positive check for all card types except land instead of the negative check for land.
- (Easy Fix) Due to protecting the card pointer targeted in the delayed trigger it will even affect cards that have left the battlefield (for example if the opponent sacrificed them to another effect, they would still effectively end up in their hand again). To fix simply remove the Protect_CardPtr() call.
I don't think this is a problem, cause the target can becomes illegal after the spell is resolved and before the triggers do it, so the spell is not countered but it's effect yes.[*]If the target becomes illegal before the spell resolves (such as gaining Shroud, Hexproof, or some other effect) then it should counter a normal cast Cyclonic Rift, but with your code that won't happen. Again, the only way to fix this is to put the TARGET block in the SPELL_ABILITY, but this causes other problems for overload.
I'm with you in this point, i dont see any way to fix this except to put the TARGET block into the SPELL_ABILITY.[*]Normal casting will not trigger effects that depend on a spell targeting a creature (such as Heroic, Avoid Fate, etc...). The only way to fix this is to put the TARGET block into the SPELL_ABILITY, but this causes other problems for overload.
So seems that overload keep in approximation until new news.
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by RiiakShiNal » 24 Aug 2014, 21:46
Actually, there isn't much point in giving a creature Shroud or Hexproof in response until it is actually targeted (in other words the triggered ability has already triggered and captured the card pointer) and since it is stored then used by another ability it is not cleared and the spell countered by the engine like a normal spell would be in that case. So I believe this is still a problem.braquio wrote:I don't think this is a problem, cause the target can becomes illegal after the spell is resolved and before the triggers do it, so the spell is not countered but it's effect yes.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Overload at 95%
by braquio » 24 Aug 2014, 23:41
Oh yes!, this happens in this new version, in my old version the effect of the spell without overload was in the trigger so didn't has this problem.
Well anyway, we keep this card as aproximation, a good one in my opinion, but not fully work.
Well anyway, we keep this card as aproximation, a good one in my opinion, but not fully work.
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by braquio » 26 Aug 2014, 10:53
Here the new version:
Is there any code to check protection from a color?
So at the moment, Known bugs:
- Don't trigger effects that depend on a spell targeting like Heroic ability or spells like Avoid Fate.
- If you use a Copy spell like Increasing Vengeance the copy will not allow you to select a target.
- if you have enough mana to cast overload, it still give you the possibility to choose normal cast also if there are no targetable permanents.
- If the target gets protection from blue before the spell is resolved, don't avoid the effect.
- Cyclonic Rift v2.0 | Open
All fixedRiiakShiNal wrote:Well, Cyclonic rift still has problems:
- (Easy fix) The filters are set wrong, it will also consider/return invisible tokens (such as the planeswalker manager, mana tokens, etc...) to their owner's hands (at which point they will cease to exist). You should instead do a positive check for all card types except land instead of the negative check for land.
- (Easy Fix) Due to protecting the card pointer targeted in the delayed trigger it will even affect cards that have left the battlefield (for example if the opponent sacrificed them to another effect, they would still effectively end up in their hand again). To fix simply remove the Protect_CardPtr() call.
Partially fixed, now checks in resolution for shroud or hexproof, and if target is still on battlefield.[*]If the target becomes illegal before the spell resolves (such as gaining Shroud, Hexproof, or some other effect) then it should counter a normal cast Cyclonic Rift, but with your code that won't happen. Again, the only way to fix this is to put the TARGET block in the SPELL_ABILITY, but this causes other problems for overload.
Is there any code to check protection from a color?
Can't be fixed[*]Normal casting will not trigger effects that depend on a spell targeting a creature (such as Heroic, Avoid Fate, etc...). The only way to fix this is to put the TARGET block into the SPELL_ABILITY, but this causes other problems for overload.
So at the moment, Known bugs:
- Don't trigger effects that depend on a spell targeting like Heroic ability or spells like Avoid Fate.
- If you use a Copy spell like Increasing Vengeance the copy will not allow you to select a target.
- if you have enough mana to cast overload, it still give you the possibility to choose normal cast also if there are no targetable permanents.
- If the target gets protection from blue before the spell is resolved, don't avoid the effect.
Last edited by braquio on 26 Aug 2014, 15:32, edited 1 time in total.
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by braquio » 26 Aug 2014, 14:42
I'm realized that in this case is only a bug for spells like Avoid Fate not for Heroic ability cause Cyclonic Rift can only target permanents you don't control so Heoric abilities never could be trigger with this spell even if the spell is 100% fine coded.braquio wrote:So at the moment, Known bugs:
- Don't trigger effects that depend on a spell targeting like Heroic ability or spells like Avoid Fate.
____________________________________________________________________________________________________________________________
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Braquio Dotp2014 DLC
Alternative Sealed Campaigns for DotP 2014
Re: Overload at 95%
by RiiakShiNal » 27 Aug 2014, 00:09
You may not have to worry about Heroic for Cyclonic Rift and some others, but you would for other overload spells like Dragonshift and Dynacharge so it is still a problem with the overload approximation.braquio wrote:I'm realized that in this case is only a bug for spells like Avoid Fate not for Heroic ability cause Cyclonic Rift can only target permanents you don't control so Heoric abilities never could be trigger with this spell even if the spell is 100% fine coded.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Overload at 95%
by NeoAnderson » 27 Aug 2014, 00:28
To avoid Heroic issue, (You must use my Heroic version) you could use this code, just before targetting :RiiakShiNal wrote:You may not have to worry about Heroic for Cyclonic Rift and some others, but you would for other overload spells like Dragonshift and Dynacharge so it is still a problem with the overload approximation.braquio wrote:I'm realized that in this case is only a bug for spells like Avoid Fate not for Heroic ability cause Cyclonic Rift can only target permanents you don't control so Heoric abilities never could be trigger with this spell even if the spell is 100% fine coded.
- Code: Select all
local refplayer = Object():GetPlayer()
local Chest_Id = Object():GetRef()
local chest = refplayer:PlayerDataChest():Make_Chest(Chest_Id)
chest:Set_CardPtr(1, Object())
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Who is online
Users browsing this forum: No registered users and 24 guests