Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers Programming Talk
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers Programming Talk
Question about Mana pool (Kruphix, God of Horizons)
Moderator: CCGHQ Admins
15 posts
• Page 1 of 1
Question about Mana pool (Kruphix, God of Horizons)
by NeoAnderson » 26 Aug 2014, 20:02
Need a suggestion to check amount of mana inside the mana pool. I think that GetTotalMana() returns also the mana still not tapped.
I would try to code : Kruphix, God of Horizons
I always use manual mana, so probably is just necessary count the mana tokens before the end of each step?
I am looking to Riiak Manual Mana Functions and i found this one RSN_CountColourManaInPlayerPool.
So i think we could use something like :
I would try to code : Kruphix, God of Horizons
I always use manual mana, so probably is just necessary count the mana tokens before the end of each step?
I am looking to Riiak Manual Mana Functions and i found this one RSN_CountColourManaInPlayerPool.
So i think we could use something like :
- Code: Select all
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, Player )
local subfilter = filter:AddSubFilter_Or()
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_C" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_B" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_U" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_G" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_R" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_W" )
local AvailableMana = filter:Count()
Last edited by NeoAnderson on 27 Aug 2014, 03:04, edited 1 time in total.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool
by gorem2k » 26 Aug 2014, 21:57
NeoAnderson wrote:I am looking to Riiak Manual Mana Functions and i found this one RSN_CountColourManaInPlayerPool.
So i think we could use something like :
- Code: Select all
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, Player )
local subfilter = filter:AddSubFilter_Or()
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_C" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_B" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_U" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_G" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_R" )
subfilter:Add( FE_CARD_NAME, OP_IS, "RSN_TOKEN_MANA_W" )
local AvailableMana = filter:Count()
nevermind, it's for unused mana
you could replace all these filteredcard with a RSN_TOKEN_MANA_C
and I think there's already a card that does prevent from emptying mana pool. I think it's in sumomole mod.
but wait, does it empty? it's only saying it becomes colorless. doesn't say it stay in your pool.. what's the use for this?
ok, I,ve read the card ruling. it stays as long as it's in play. Riiak will surely help you with this
Re: Question about Mana pool
by NeoAnderson » 26 Aug 2014, 22:51
gorem2k wrote:yes it counts the mana tokens but what if a land is not tapped, then the token is not in play yet.
nevermind, it's for unused mana
you could replace all these filteredcard with a RSN_TOKEN_MANA_C
and I think there's already a card that does prevent from emptying mana pool. I think it's in sumomole mod.
but wait, does it empty? it's only saying it becomes colorless. doesn't say it stay in your pool.. what's the use for this?
ok, I,ve read the card ruling. it stays as long as it's in play. Riiak will surely help you with this
1. I was thinking to read how many tokens are in play before they are going to be exiled during the end of steps, save the value into a register (LinkedDC) then make a trigger at beginning of each step produce with notrigger X(stored value) colorless mana tokens.
2. Another way is to read how many tokens are in play before they are going to be exiled during the end of steps, then use a modified colorless mana token who will not expire at end of each step.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool
by gorem2k » 27 Aug 2014, 00:20
this is how sumomole coded Omnath, Locus of Mana in DotP 2013
- Code: Select all
<TRIGGERED_ABILITY internal="1" pre_trigger="1">
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Green mana doesn’t empty from your mana pool as steps and phases end.]]></LOCALISED_TEXT>
<TRIGGER value="ZONECHANGE_CONSIDERED" simple_qualifier="objectyoucontrol" to_zone="ZONE_ANY" from_zone="ZONE_IN_PLAY">
if ( TriggerObject():GetCardName() == "_TOKEN_G_624998" ) and ( TriggerObject():Tapped() == 0 ) then
override = true
return true
end
return false
</TRIGGER>
</TRIGGERED_ABILITY>
Re: Question about Mana pool
by RiiakShiNal » 27 Aug 2014, 00:23
To prevent unused mana from leaving the battlefield you would use a ZONECHANGE_CONSIDERED trigger and check to see if the card a mana token and is untapped then simply override the event. You can look at Shizuko, Caller of Autumn (RSN_SHIZUKO_CALLER_OF_AUTUMN_74436) in my mod to see how I prevented mana from leaving play. Do note though that you can't use a delayed trigger for this (it eventually leads to a crash condition).
To change mana to colourless if it would empty from the pool you would still do the trigger above, but you would only override the event if it is a colourless token, otherwise you would allow it to change zones and simply replace it with a colourless mana token.
So overall this is not a very difficult ability (certainly simpler than other abilities you've worked on). No need for custom tokens, don't need to mess with a LinkedDC() or triggers to produce at each step. You don't need to know how much mana is in the pool as you don't care. You need only deal with untapped mana tokens trying to leave play and that can be done as I explained.
To change mana to colourless if it would empty from the pool you would still do the trigger above, but you would only override the event if it is a colourless token, otherwise you would allow it to change zones and simply replace it with a colourless mana token.
So overall this is not a very difficult ability (certainly simpler than other abilities you've worked on). No need for custom tokens, don't need to mess with a LinkedDC() or triggers to produce at each step. You don't need to know how much mana is in the pool as you don't care. You need only deal with untapped mana tokens trying to leave play and that can be done as I explained.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 496 times
Re: Question about Mana pool
by NeoAnderson » 27 Aug 2014, 02:54
Thanks guys, I think to have finally get a working version, as suggested by Riiak i made it without any LinkedDC or Delayed Trigger.
Here you can find my code (Please someone could make some tests on it, will be helpful, i would avoid any trouble as like game crashed...)
Here you can find my code (Please someone could make some tests on it, will be helpful, i would avoid any trouble as like game crashed...)
- Kruphix, God of Horizons Neo Rev 1.0 | Open
- Neo Devotion functions | Open
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by RiiakShiNal » 27 Aug 2014, 10:53
You're going to have some problems with your version unless you fix some things.
- TOKEN_REGISTRATION needs to be in the card not in the ability. So you need to move it outside of the TRIGGERED_ABILITY otherwise you will have crashes.
- You should not produce mana in a TRIGGER (no way to prevent duplicate tokens or properly clean up.
- You need to return true for all untapped tokens trying to leave play, but only override the event for colourless tokens. You can also set an EffectDC() register at this point to keep from having to check the card name if you want (I recommend doing this as it will make later checks a bit easier). Only return false if it is not a mana token.
- You don't need replacement_query or linked_ability_group since you don't ask the user a question and you aren't using LinkedDC().
- Since this is a TRIGGERED_ABILITY you don't need RSN_MarkManaAbilityStart() or RSN_MarkManaAbilityEnd().
- In a RESOLUTION_TIME_ACTION you will check to see if the card is not a colourless token (or check the EffectDC() register if you set it in the trigger) and if it isn't create a colourless token using RSN_ProduceNoTrigger() (like you are).
- In a second RESOLUTION_TIME_ACTION you will need to first check if it is a colourless token (or check the EffectDC() register) then if not use RSN_EliminateExtraManaTokens() to prevent any extra tokens that may have been created from hanging around (like from Doubling Season).
- You will need another TRIGGERED_ABILITY to clear the produced mana like this:
- Code: Select all
<TRIGGERED_ABILITY forced_skip="1" replacement_effect="1">
<TRIGGER value="BEGINNING_OF_STEP" pre_trigger="1" />
<RESOLUTION_TIME_ACTION>
RSN_ClearProducedMana()
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 496 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by gorem2k » 27 Aug 2014, 12:23
- test | Open
How can you produce mana outside of a triggered_ab/activated_ab or spell_ab ?
oops, I misread trigger with triggered. ok so you put RTAs after the </TRIGGER>.
- where do I put an EffectDC() to skip name check? | Open
- like this? | Open
- ok this works: | Open
Last edited by gorem2k on 27 Aug 2014, 13:12, edited 7 times in total.
Re: Question about Mana pool (Kruphix, God of Horizons)
by NeoAnderson » 27 Aug 2014, 12:49
Thanks for you kind attention my friend. You're the master of Mana!RiiakShiNal wrote:You're going to have some problems with your version unless you fix some things.
- TOKEN_REGISTRATION needs to be in the card not in the ability. So you need to move it outside of the TRIGGERED_ABILITY otherwise you will have crashes.
- You should not produce mana in a TRIGGER (no way to prevent duplicate tokens or properly clean up.
- You need to return true for all untapped tokens trying to leave play, but only override the event for colourless tokens. You can also set an EffectDC() register at this point to keep from having to check the card name if you want (I recommend doing this as it will make later checks a bit easier). Only return false if it is not a mana token.
- You don't need replacement_query or linked_ability_group since you don't ask the user a question and you aren't using LinkedDC().
- Since this is a TRIGGERED_ABILITY you don't need RSN_MarkManaAbilityStart() or RSN_MarkManaAbilityEnd().
- In a RESOLUTION_TIME_ACTION you will check to see if the card is not a colourless token (or check the EffectDC() register if you set it in the trigger) and if it isn't create a colourless token using RSN_ProduceNoTrigger() (like you are).
- In a second RESOLUTION_TIME_ACTION you will need to first check if it is a colourless token (or check the EffectDC() register) then if not use RSN_EliminateExtraManaTokens() to prevent any extra tokens that may have been created from hanging around (like from Doubling Season).
- You will need another TRIGGERED_ABILITY to clear the produced mana like this:
- Code: Select all
<TRIGGERED_ABILITY forced_skip="1" replacement_effect="1">
<TRIGGER value="BEGINNING_OF_STEP" pre_trigger="1" />
<RESOLUTION_TIME_ACTION>
RSN_ClearProducedMana()
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
Here you can find the modified trigger :
- Code: Select all
<TRIGGERED_ABILITY replacement_effect="1">
<TRIGGER value="ZONECHANGE_CONSIDERED" simple_qualifier="objectyoucontrol" to_zone="ZONE_ANY" from_zone="ZONE_BATTLEFIELD" pre_trigger="1">
if (TriggerObject() ~= nil) and (TriggerObject():IsTapped() == false) then
EffectDC():Set_Int(20, 0)
if (TriggerObject():GetCardName() == "TOKEN_MANA_C") then
MTG():OverrideEvent()
return true
elseif (TriggerObject():GetCardName() == "TOKEN_MANA_W") or (TriggerObject():GetCardName() == "TOKEN_MANA_U") or (TriggerObject():GetCardName() == "TOKEN_MANA_U") or (TriggerObject():GetCardName() == "TOKEN_MANA_R") or TriggerObject():GetCardName() == "TOKEN_MANA_B") or (TriggerObject():GetCardName() == "TOKEN_MANA_G") then
EffectDC():Set_Int(20, 1)
return true
end
end
return false
</TRIGGER>
<RESOLUTION_TIME_ACTION>
local value = EffectDC():Get_Int(20)
if value == 1 then
RSN_ProduceNoTrigger( "{1}", 1 )
end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local value = EffectDC():Get_Int(20)
if value == 1 then
RSN_EliminateExtraManaTokens()
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY forced_skip="1" replacement_effect="1">
<TRIGGER value="BEGINNING_OF_STEP" pre_trigger="1" />
<RESOLUTION_TIME_ACTION>
RSN_ClearProducedMana()
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_C" />
<HELP title="MORE_INFO_BADGE_TITLE_8" body="MORE_INFO_BADGE_BODY_8" zone="ZONE_ANY" />
<SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
<SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
<AI_BASE_SCORE score="1500" zone="ZONE_BATTLEFIELD" />
</CARD_V2>
- Kruphix, God of Horizons Neo Rev 2.0 | Open
Last edited by NeoAnderson on 28 Aug 2014, 05:38, edited 1 time in total.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by RiiakShiNal » 28 Aug 2014, 00:20
Yep, still inside the TRIGGERED_ABILITY so that they actually run.gorem2k wrote:I know it's not fixing everything RSN said but it's getting there...
- test | Open
How can you produce mana outside of a triggered_ab/activated_ab or spell_ab ?
oops, I misread trigger with triggered. ok so you put RTAs after the </TRIGGER>.
Actually, I meant something more like this:
- Code: Select all
<TRIGGER value="ZONECHANGE_CONSIDERED" simple_qualifier="objectyoucontrol" to_zone="ZONE_ANY" from_zone="ZONE_BATTLEFIELD" pre_trigger="1">
if (TriggerObject() ~= nil) and (TriggerObject():IsTapped() == false) then
local mtName = TriggerObject():GetCardName()
if (mtName == "TOKEN_MANA_C") then
MTG():OverrideEvent()
EffectDC():Int_Set(50, 1)
return true
elseif string.match( mtName, "TOKEN_MANA_" ) and mtName ~= "TOKEN_MANA_C" then
return true
end
end
return false
</TRIGGER>
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 496 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by NeoAnderson » 28 Aug 2014, 01:28
RiiakShiNal wrote:Yep, still inside the TRIGGERED_ABILITY so that they actually run.gorem2k wrote:I know it's not fixing everything RSN said but it's getting there...
- test | Open
How can you produce mana outside of a triggered_ab/activated_ab or spell_ab ?
oops, I misread trigger with triggered. ok so you put RTAs after the </TRIGGER>.Actually, I meant something more like this:That way you only have to check an int and don't have to worry about card pointers.
- Code: Select all
<TRIGGER value="ZONECHANGE_CONSIDERED" simple_qualifier="objectyoucontrol" to_zone="ZONE_ANY" from_zone="ZONE_BATTLEFIELD" pre_trigger="1">
if (TriggerObject() ~= nil) and (TriggerObject():IsTapped() == false) then
local mtName = TriggerObject():GetCardName()
if (mtName == "TOKEN_MANA_C") then
MTG():OverrideEvent()
EffectDC():Int_Set(50, 1)
return true
elseif string.match( mtName, "TOKEN_MANA_" ) and mtName ~= "TOKEN_MANA_C" then
return true
end
end
return false
</TRIGGER>
But why you are setting the EffectDC():Int_Set(50, 1) when it found the colourless untapped token? You should move into elseif when he found an untapped coloured mana token.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by gorem2k » 28 Aug 2014, 02:07
I think he meant to put it after the elseif like you did.
- Code: Select all
<TRIGGER value="ZONECHANGE_CONSIDERED" simple_qualifier="objectyoucontrol" to_zone="ZONE_ANY" from_zone="ZONE_BATTLEFIELD" pre_trigger="1">
if (TriggerObject() ~= nil) and (TriggerObject():IsTapped() == false) then
local mtName = TriggerObject():GetCardName()
EffectDC():Int_Clear(-23528937598792834)
if (mtName == "TOKEN_MANA_C") then
MTG():OverrideEvent()
return true
elseif string.match( mtName, "TOKEN_MANA_" ) and mtName ~= "TOKEN_MANA_C" then
EffectDC():Int_Set(-23528937598792834, 1)
return true
end
end
return false
</TRIGGER>
<RESOLUTION_TIME_ACTION>
if EffectDC():Get_Int(-23528937598792834) == 1 then
RSN_ProduceNoTrigger( "{1}", 1 )
end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
if EffectDC():Get_Int(-23528937598792834) == 1 then
RSN_EliminateExtraManaTokens()
end
</RESOLUTION_TIME_ACTION>
Re: Question about Mana pool (Kruphix, God of Horizons)
by NeoAnderson » 28 Aug 2014, 02:31
OMG my eyes probably are gone!!!gorem2k wrote:hey Neo, your Kruphix, God of Horizons is checking for red and white color devotion while it should check for green and blue.
Fixed into the Full pack! Thanks a lot my friend!- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by RiiakShiNal » 28 Aug 2014, 23:08
It doesn't matter on which one you put it. If you set it for colourless then you just do a negative check:NeoAnderson wrote:But why you are setting the EffectDC():Int_Set(50, 1) when it found the colourless untapped token? You should move into elseif when he found an untapped coloured mana token.
- Code: Select all
if (EffectDC():Int_Get(50) ~= 1) then
- Code: Select all
if (EffectDC():Int_Get(50) == 1) then
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2185
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 496 times
Re: Question about Mana pool (Kruphix, God of Horizons)
by NeoAnderson » 29 Aug 2014, 04:55
You're right is obvious that if you invert the if condition will be ok, anyway please could you come to see the other topic about overload? Your help, also the help Firemind will be really appreciated we are really close to have a good approximation, i have just to make a little fix!RiiakShiNal wrote:It doesn't matter on which one you put it. If you set it for colourless then you just do a negative check:NeoAnderson wrote:But why you are setting the EffectDC():Int_Set(50, 1) when it found the colourless untapped token? You should move into elseif when he found an untapped coloured mana token.If you set it for other mana tokens then you do a positive check:
- Code: Select all
if (EffectDC():Int_Get(50) ~= 1) thenRegardless because you only return true in the trigger for mana tokens you don't have to worry about any other cards.
- Code: Select all
if (EffectDC():Int_Get(50) == 1) then
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
15 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 26 guests