It is currently 27 Apr 2024, 07:56
   
Text Size

Report cards error here

Moderator: CCGHQ Admins

Re: Report cards error here

Postby zwastik » 26 Sep 2010, 05:37

gaea's blessing didn't made me draw a card
zwastik
 
Posts: 31
Joined: 30 Aug 2010, 11:48
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby kevlahnota » 26 Sep 2010, 10:05

Gaea's Blessing FIXED @ SVN R353
zwastik wrote:gaea's blessing didn't made me draw a card
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby zwastik » 26 Sep 2010, 14:53

-Load save
-Don't mulligan
-AI will play Kird Ape
-Counter that spell with Force of Will, discard any blue card in your hand
-Kird Ape won't be countered

DOTP-save.rar
Profile and save state
(5.63 KiB) Downloaded 365 times
zwastik
 
Posts: 31
Joined: 30 Aug 2010, 11:48
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby zwastik » 26 Sep 2010, 15:39

There is a problem with kismet and non-basic lands. When you tap a non-basic land for generating mana, kismet triggers and mana generated this way is lost. I believe that this does not happens in real magic.
zwastik
 
Posts: 31
Joined: 30 Aug 2010, 11:48
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby kevlahnota » 26 Sep 2010, 17:24

FIXED @ SVN R357
zwastik wrote:-Load save
-Don't mulligan
-AI will play Kird Ape
-Counter that spell with Force of Will, discard any blue card in your hand
-Kird Ape won't be countered

DOTP-save.rar
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby Clark » 27 Sep 2010, 14:12

@Kev

It seems BOJUKA_BOG would keep opponent's graveyard clean instead of exile all card only when its entering battlefield.

I think this feature should not be implemented in tag <STATIC_ABILITY.>, but in <TRIGGERED_ABILITY/> :)
Clark
 
Posts: 64
Joined: 21 Aug 2010, 16:07
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby kevlahnota » 27 Sep 2010, 14:45

In my tests, it will only trigger once then all the cards in the target players graveyard are exiled (no repetition even in static ability because of register check).

if you try to put the code in "TRIGGER_ABILITY", it will work but only one card will be removed. maybe you have another work around :lol:

if you looked at Orim's Chant code (I've modified it), I put the ability also on "Static"

Clark wrote:@Kev

It seems BOJUKA_BOG would keep opponent's graveyard clean instead of exile all card only when its entering battlefield.

I think this feature should not be implemented in tag <STATIC_ABILITY.>, but in <TRIGGERED_ABILITY/> :)
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby Clark » 27 Sep 2010, 16:30

kevlahnota wrote:In my tests, it will only trigger once then all the cards in the target players graveyard are exiled (no repetition even in static ability because of register check).

if you try to put the code in "TRIGGER_ABILITY", it will work but only one card will be removed. maybe you have another work around :lol:

if you looked at Orim's Chant code (I've modified it), I put the ability also on "Static"
Will below codes work for such case :mrgreen: ?
Code: Select all
      <TRIGGERED_ABILITY layer="0" >
       <TRIGGER value="COMES_INTO_PLAY">
         return SelfTriggered()
       </TRIGGER>
         <FILTER> 
            return OwnedByAnOpponent() and InGraveyard() and (SubjectType() == SUBJECT_OBJECT)
         </FILTER>
         <EFFECT>
            if Subject() ~= nil then
               Subject():RemoveFromGame()
           end
         </EFFECT>
      </TRIGGERED_ABILITY>
Clark
 
Posts: 64
Joined: 21 Aug 2010, 16:07
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby kevlahnota » 27 Sep 2010, 17:02

for example we have 3 cards in graveyard.

lets check it:

1)comes into play - good
<TRIGGER value="COMES_INTO_PLAY">
return SelfTriggered()
</TRIGGER>
2)filter - it must be target player not owned by opponent

3)card/s in graveyard - good

4)subject type = object - good

<FILTER>
return OwnedByAnOpponent() and InGraveyard() and (SubjectType() == SUBJECT_OBJECT)
</FILTER>
5)subject is not nil - good

6)the top card in graveyard will be removed from the game - good

7)end of effect

<EFFECT>
if Subject() ~= nil then
Subject():RemoveFromGame()
end
</EFFECT>
now there will be 2 more cards in the graveyard right?
it will not loop because the card( Bojuka Bog ) is already in play after the "comes into play" effect triggers.


Clark wrote:Will below codes work for such case :mrgreen: ?
Code: Select all
      <TRIGGERED_ABILITY layer="0" >
       <TRIGGER value="COMES_INTO_PLAY">
         return SelfTriggered()
       </TRIGGER>
         <FILTER> 
            return OwnedByAnOpponent() and InGraveyard() and (SubjectType() == SUBJECT_OBJECT)
         </FILTER>
         <EFFECT>
            if Subject() ~= nil then
               Subject():RemoveFromGame()
           end
         </EFFECT>
      </TRIGGERED_ABILITY>
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby kevlahnota » 27 Sep 2010, 17:42

Fixed KISMET @ SVN R366 please test. :D

zwastik wrote:There is a problem with kismet and non-basic lands. When you tap a non-basic land for generating mana, kismet triggers and mana generated this way is lost. I believe that this does not happens in real magic.
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby zwastik » 28 Sep 2010, 00:16

Playing with Progenitus conflux deck, I cast Lim-Dul's Vault and Dotp crashes.

crash.jpg
Dotp app crash screenshot
zwastik
 
Posts: 31
Joined: 30 Aug 2010, 11:48
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby kevlahnota » 28 Sep 2010, 03:16

Fixed Lim-Dul's Vault, Conflux and Cruel Ultimatum @ SVN R367. Please test again :)

The crash of Lim-Dul's Vault I think is where the effect will trigger. I've modified it. I tested it by playing 5 games. No crashes on me now. If ever you have crashes, can you post the content of MOTHER.txt (it's on the install directory of DOTP), if there's a conflict or error, it will have some error codes generated. :D

zwastik wrote:Playing with Progenitus conflux deck, I cast Lim-Dul's Vault and Dotp crashes.

crash.jpg
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Report cards error here

Postby Clark » 28 Sep 2010, 11:27

@Kev
Thanks for the clarification
Clark
 
Posts: 64
Joined: 21 Aug 2010, 16:07
Has thanked: 0 time
Been thanked: 0 time

Re: Report cards error here

Postby Bog Wraith » 29 Sep 2010, 00:26

The change that was made to Natural Balance has broken the card. Now, when I cast it, I get to choose the lands I want but the lands are then put on top of the deck instead of into the game. Only 1 of the land is put into play with the rest going on top of the deck. The AI player however does get the lands put into play.
'Twas in the bogs of Cannelbrae
My mate did meet an early grave
'Twas nothing left for us to save
In the peat-filled bogs of Cannelbrae.
User avatar
Bog Wraith
Global Mod 1 (Ret)
 
Posts: 1108
Joined: 28 May 2008, 22:40
Location: Shandalar
Has thanked: 425 times
Been thanked: 153 times

Re: Report cards error here

Postby zwastik » 29 Sep 2010, 01:11

-AI cast Diabolic Edict.
-Sacrificed creature seems to be exiled, it does not goes to graveyard.

save2010-09-28.rar
profile and save file
(23.27 KiB) Downloaded 354 times
zwastik
 
Posts: 31
Joined: 30 Aug 2010, 11:48
Has thanked: 0 time
Been thanked: 0 time

PreviousNext

Return to Programming Talk

Who is online

Users browsing this forum: No registered users and 22 guests


Who is online

In total there are 22 users online :: 0 registered, 0 hidden and 22 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 22 guests

Login Form