Card Creation Request Thread

[RiiakShiNal]

Well, it could be the @ symbol in the artist tag. I noticed a long time ago that the artist tag does not allow much in the way of characters (unless they are html encoded, "&" instead of "&", etc...).

[BloodReyvyn]

nope, still crashing.

Also, is there a way to stop the player from drawing card(s) at the beginning of their turn?

[RiiakShiNal]

I just tested the code you posted and while it doesn't work, it also doesn't crash. Are you sure that Lich is what is causing your game to crash?

[BloodReyvyn]

NVM, I got the game working. My SCRIPT_LOG got bloated (?), I got the game running again, but yeah, it's still got issues.

Life total does not set to 0 still.

Player draws cards and gains life.

No idea whether the sac feature works just yet.

Seems like the only 100% working parts are; it does make you lose the game if Lich gets put into the grave from the battlefield and you can't lose the game for having 0 or less life.

[thefiremind]

Life total does not set to 0 still.

Player draws cards and gains life.

It seems I'm a bit blind because it took me too long to see that:

• The enters-the-battlefield trigger is missing its trigger condition. A trigger without trigger condition obviously does... nothing.
• The trigger that should substitute life gain with card drawing isn't set to internal="1" pre_trigger="1" so it has no chance to override anything.

Summing up, here's how the 2 triggers should be:

Code: Select all

  <TRIGGERED_ABILITY internal="1" pre_trigger="1" active_zone="ZONE_TRANSITION">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[As Lich enters the battlefield, you lose life equal to your life total.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_TRANSITION" simple_qualifier="self" to_zone="ZONE_IN_PLAY" />
    <RESOLUTION_TIME_ACTION>
    local life_total = EffectController():GetLifeTotal()
    if life_total &gt; 0 then
       EffectController():SetLifeTotal(0)
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

Code: Select all

  <TRIGGERED_ABILITY internal="1" pre_trigger="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[If you would gain life, draw that many cards instead.]]></LOCALISED_TEXT>
    <TRIGGER value="PLAYER_GAINED_LIFE" simple_qualifier="controller">
    if TriggerPlayer() ~= nil then
       override = true
       return true
    end
    return false
    </TRIGGER>
    <RESOLUTION_TIME_ACTION>
    local NumCards = GetAmount()
    while (NumCards &gt; 0) do
       NumCards = NumCards - 1
       EffectController():DrawCard()
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

[BloodReyvyn]

Wow, I can't believe I missed that all the times I read through it. I guess triggering the event would be useful.

That got it working great.

Thanks guys for all your help.

Fully functional Lich here: https://www.dropbox.com/s/0degedv9yii7y ... ip?v=0rc-s

Now if I can just finish Solitary Confinement, I'll be set. Is there any way to stop a player from drawing on their turn though?

Also, wasn't Repay in Kind in Sorin's deck in DotP2012? I don't have that one, but I would like the card if anyone could convert it.

[thefiremind]

Now if I can just finish Solitary Confinement, I'll be set. Is there any way to stop a player from drawing on their turn though?

You can avoid the draw with the code I wrote here, but you can't skip the whole draw step, so the card can't be 100% exact (Maralen of the Mornsong, for example, would still trigger, while she shouldn't).

Also, wasn't Repay in Kind in Sorin's deck in DotP2012? I don't have that one, but I would like the card if anyone could convert it.

The code doesn't seem to need conversion...

Code: Select all

  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Each player’s life total becomes the lowest life total among all players.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Le total de points de vie de chaque joueur devient le total de points de vie le plus bas parmi tous les joueurs.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Der Lebenspunktestand aller Spieler wird zum Lebenspunktestand des Spielers mit den wenigsten Lebenspunkten.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El total de vidas de cada jugador es igual al menor del total de vidas entre todos los jugadores.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[I punti vita di ogni giocatore diventano pari ai punti vita più bassi tra tutti i giocatori.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[各プレイヤーのライフの総量は、すべてのプレイヤーの中で最も低いライフの総量になる。]]></LOCALISED_TEXT>
    <RESOLUTION_TIME_ACTION>
    local iMin = EffectController():GetLifeTotal()
    for i=0,MTG():GetNumberOfPlayers()-1 do
       local currentPlayer = MTG():GetNthPlayer( i )
       
       if (currentPlayer ~= nil and currentPlayer:GetLifeTotal() &lt; iMin) then
         iMin = currentPlayer:GetLifeTotal()
       end
    end
    for i=0,MTG():GetNumberOfPlayers()-1 do
       local currentPlayer = MTG():GetNthPlayer( i )
       
       if (currentPlayer ~= nil) then
         currentPlayer:SetLifeTotal(iMin)
       end
    end
    </RESOLUTION_TIME_ACTION>
    <SFX text="GLOBAL_DEATH_PLAY" />
    <AI_BASE_SCORE score="900" zone="hand" />
  </SPELL_ABILITY>

I changed Object():GetPlayer() with EffectController() just for the sake of coherence and updated the SFX string, the rest should work as it is.

[BloodReyvyn]

Awesome, thanks again.

Here's my code for Solitary Confinement and everything seems to be working right. Or as well as it can with the lack of an actual draw step.

Solitary Confinement:

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2>
  <FILENAME text="SOLITARY_CONFINEMENT_34769" />
  <CARDNAME text="SOLITARY_CONFINEMENT" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Solitary Confinement]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Mitard]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Incomunicación]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Einzelzelle]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Isolamento]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Solitary Confinement]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Solitary Confinement]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Solitary Confinement]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Confinamento Solitário]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="34769" />
  <ARTID value="A34769" />
  <ARTIST name="Scott M. Fischer" />
  <CASTING_COST cost="{2}{W}" />
  <TYPE metaname="Enchantment" />
  <EXPANSION value="JUD" />
  <RARITY metaname="R" />
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of your upkeep, sacrifice Solitary Confinement unless you discard a card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Au début de votre entretien, sacrifiez le Mitard à moins que vous ne vous défaussiez d’une carte de votre main.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Al comienzo de tu mantenimiento, sacrifica la Incomunicación a menos que descartes una carta de tu mano.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Opfere die Einzelzelle zu Beginn deines Versorgungssegments, falls du nicht eine Karte aus deiner Hand abwirfst.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[All’inizio del tuo mantenimento, sacrifica l’Isolamento a meno che tu scarti una carta.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[At the beginning of your upkeep, sacrifice Solitary Confinement unless you discard a card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[At the beginning of your upkeep, sacrifice Solitary Confinement unless you discard a card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[At the beginning of your upkeep, sacrifice Solitary Confinement unless you discard a card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[No início de sua manutenção, sacrifique Confinamento Solitário a menos que você descarte um card de sua mão.]]></LOCALISED_TEXT>
    <TRIGGER value="BEGINNING_OF_STEP" simple_qualifier="controller">
    return ( EffectController():MyTurn() ~= 0 ) and ( MTG():GetStep() == STEP_UPKEEP )
    </TRIGGER>
    <COST type="generic" qualifier="conditional">
      <TARGET_DETERMINATION>
      local filter = Object():GetFilter()
      filter:Clear()
      filter:SetZone( ZONE_HAND )
      filter:SetPlayer( EffectController() )
      filter:NotTargetted()
      local total = (filter:Count())
      if total &gt; 1 then
         return 1
      else
         return 0
      end
      </TARGET_DETERMINATION>
      <RESOLUTION_TIME_ACTION>
      local player = EffectController()
      if player ~= nil then
         local filter = Object():GetFilter()
         filter:Clear()
         filter:SetZone( ZONE_HAND )
         filter:SetPlayer( player )
         filter:NotTargetted()
         player:SetTargetCount( 1 )
         for i=0,2-1 do
            player:SetTargetPrompt( i, "CARD_QUERY_CHOOSE_CARD_TO_DISCARD_2" )
         end
         player:ChooseTargets( NO_VALIDATION, EffectDC():Make_Targets(1) )
      end
      </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
      local player = EffectController()
      if player ~= nil then
         for i = 0,(2-1) do
            local target_card = EffectDC():Get_Targets(1):Get_CardPtr(i)
            if target_card ~= nil  then
               target_card:Discard()
            end
         end
      end
      </RESOLUTION_TIME_ACTION></COST>
    <RESOLUTION_TIME_ACTION conditional="else">
    local creature = EffectSource()
    if creature ~= nil then
       creature:Sacrifice(EffectController())
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
  <TRIGGERED_ABILITY internal="1" pre_trigger="1" priority="-10">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Skip your draw step.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Sautez votre étape de pioche.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Sáltate tu paso de robar.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Übergehe dein Ziehsegment.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Salta la tua acquisizione.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Skip your draw step.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Skip your draw step.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Skip your draw step.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Pule sua etapa de compra.]]></LOCALISED_TEXT>
    <TRIGGER value="DREW_CARD" simple_qualifier="controller">
    if MTG():GetStep() == STEP_DRAW and EffectController():MyTurn() ~= 0 then
       override = 1
       return true
    end
    return false
    </TRIGGER>
  </TRIGGERED_ABILITY>
  <STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[You have shroud.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Vous ne pouvez pas être la cible de sorts ou de capacités.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[No puedes ser objetivo de hechizos o habilidades.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Du kannst nicht das Ziel von Zaubersprüchen oder Fähigkeiten sein.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Tu hai velo.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[You have shroud.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[You have shroud.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[You have shroud.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Você não pode ser alvo de mágicas ou habilidades.]]></LOCALISED_TEXT>
    <CONTINUOUS_ACTION layer="8">
    if EffectController() ~= nil then
       local characteristics = EffectController():GetCurrentCharacteristics()
       if characteristics ~= nil then
          characteristics:Bool_Set( PLAYER_CHARACTERISTIC_HAS_SHROUD, 1 )
       end
    end
    </CONTINUOUS_ACTION>
  </STATIC_ABILITY>
  <STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Prevent all damage that would be dealt to you.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Prévenez toutes les blessures qui devraient vous être infligées.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Prevén todo el daño que se te fuera a hacer.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Verhindere allen Schaden, der dir zugefügt werden würde.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Previeni tutto il danno che ti verrebbe inflitto.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Prevent all damage that would be dealt to you.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Prevent all damage that would be dealt to you.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Prevent all damage that would be dealt to you.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Previna todo o dano que seria causado a você.]]></LOCALISED_TEXT>
    <CONTINUOUS_ACTION>
      local player = EffectController()
      if player ~= nil then
        local characteristics = player:GetCurrentCharacteristics()
        characteristics:Bool_Set(PLAYER_CHARACTERISTIC_CANT_TAKE_COMBAT_DAMAGE, 1)
        characteristics:Bool_Set(PLAYER_CHARACTERISTIC_CANT_TAKE_NONCOMBAT_DAMAGE, 1)
        player:AddBadge(PLAYER_BADGE_ICON_PREVENTION, "PLAYER_PREVENTION_ICON")
      end
    </CONTINUOUS_ACTION>
  </STATIC_ABILITY>
</CARD_V2>

[sumomole]

Awesome, thanks again.
Here's my code for Solitary Confinement and everything seems to be working right. Or as well as it can with the lack of an actual draw step.

I remember Reanimate not only target the graveyard card but also target the owner, if a player has shroud, you will not be able to target his graveyard cards.

[BloodReyvyn]

Why the heck would they target the player? Some of this game's logic is illogical....

[BloodReyvyn]

Anyways, on topic, I am going to go ahead and request Stuffy Doll and Magus of the Mirror since I will be at work most of the next 4-5 days. Here's hoping to see them soon. lol

Thanks again for all your help and for the cards in advance.

[Master Necro]

Hi, could anyone provide me these cards:

Shrine of Loyal Legions
Chancellor of the Annex
Fuel for the Cause
Shrine of Piercing Vision
Gremlin Mine
Invader Parasite
Chancellor of the Tangle
Shrine of Boundless Growth
Burn the Impure

[thefiremind]

I remember Reanimate not only target the graveyard card but also target the owner, if a player has shroud, you will not be able to target his graveyard cards.

I can't see anything in the Reanimate code that refers to the graveyard's owner. Do you mean that PLAYER_CHARACTERISTIC_HAS_SHROUD is bugged? I see that there's also a PLAYER_CHARACTERISTIC_CANT_BE_TARGETTED, which should basically mean the same, but maybe it's handled differently... if something goes wrong I'd suggest to try with the other characteristic.

[sumomole]

Hi, could anyone provide me these cards:

Shrine of Loyal Legions
Chancellor of the Annex
Fuel for the Cause
Shrine of Piercing Vision
Gremlin Mine
Invader Parasite
Chancellor of the Tangle
Shrine of Boundless Growth
Burn the Impure

Test these cards and tell me if there is any problem. Change mana token to yours.

[Master Necro]

Hi, could anyone provide me these cards:

Shrine of Loyal Legions
Chancellor of the Annex
Fuel for the Cause
Shrine of Piercing Vision
Gremlin Mine
Invader Parasite
Chancellor of the Tangle
Shrine of Boundless Growth
Burn the Impure

Test these cards and tell me if there is any problem. Change mana token to yours. I will upload arts soon.

No need to do the art I can at least do is my self. Thanks man! Althou they are for various decks I'm making so testing is going to be slow.