Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels)
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels)
Card Creation Request Thread
Moderator: CCGHQ Admins
Re: Card Creation Request Thread
by Master Necro » 27 May 2013, 07:23
Also could someone help me code this activated ability and triggered ability:
"
: Draw a card, then discard a card. If a creature card is discarded this way, untap (the creature with this ability)..."
and
"At the beginning of your end step, if {creature with this trigger) didn't attack this turn, tap {creature with this trigger)"
"
: Draw a card, then discard a card. If a creature card is discarded this way, untap (the creature with this ability)..."and
"At the beginning of your end step, if {creature with this trigger) didn't attack this turn, tap {creature with this trigger)"
-
Master Necro - Posts: 259
- Joined: 24 Apr 2013, 18:25
- Has thanked: 83 times
- Been thanked: 21 times
Re: Card Creation Request Thread
by sumomole » 27 May 2013, 08:21
I found EvaluateObjects can't be used to SetZone( ZONE_STACK ), perhaps there is no way to determine which spell is targeting you, I expect a good idea too.Blue Ghost wrote:Is the third option of Dawn Charm possible to implement? I couldn't find anything similar.
1. discard a card. If a creature card is discarded this way, untap it.Master Necro wrote:Also could someone help me code this activated ability and triggered ability:
"
and
"At the beginning of your end step, if {creature with this trigger) didn't attack this turn, tap {creature with this trigger)"
- Code: Select all
<RESOLUTION_TIME_ACTION>
local player = EffectController()
local filter = Object():GetFilter()
filter:Clear()
filter:SetZone( ZONE_HAND )
filter:SetPlayer( player )
filter:NotTargetted()
player:SetTargetCount( 1 )
player:SetTargetPrompt( 0, "CARD_QUERY_CHOOSE_CARD_TO_DISCARD" )
player:ChooseTargets( NO_VALIDATION, EffectDC():Make_Targets(0) )
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local target_card = EffectDC():Get_Targets(0) and EffectDC():Get_Targets(0):Get_CardPtr(0)
if target_card ~= nil then
if target_card:GetCardType():Test( CARD_TYPE_CREATURE ) ~= 0 and EffectSource() ~= nil then
EffectSource():Untap()
end
target_card:Discard()
end
</RESOLUTION_TIME_ACTION>
- Code: Select all
if EffectSource() ~= nil and EffectSource():NumAttacksThisTurn() == 0 then
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Re: Card Creation Request Thread
by thefiremind » 27 May 2013, 08:25
I don't know what you did, but my last version works fine for me.BloodReyvyn wrote:BTW thefiremind, the Stuffy Doll still doesn't deal damage dealt to it to the chosen player...
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Card Creation Request Thread
by Master Necro » 27 May 2013, 08:45
Thank you!sumomole wrote:I found EvaluateObjects can't be used to SetZone( ZONE_STACK ), perhaps there is no way to determine which spell is targeting you, I expect a good idea too.Blue Ghost wrote:Is the third option of Dawn Charm possible to implement? I couldn't find anything similar.1. discard a card. If a creature card is discarded this way, untap it.Master Necro wrote:Also could someone help me code this activated ability and triggered ability:
"
and
"At the beginning of your end step, if {creature with this trigger) didn't attack this turn, tap {creature with this trigger)"2. If a creature didn't attack this turn.
- Code: Select all
<RESOLUTION_TIME_ACTION>
local player = EffectController()
local filter = Object():GetFilter()
filter:Clear()
filter:SetZone( ZONE_HAND )
filter:SetPlayer( player )
filter:NotTargetted()
player:SetTargetCount( 1 )
player:SetTargetPrompt( 0, "CARD_QUERY_CHOOSE_CARD_TO_DISCARD" )
player:ChooseTargets( NO_VALIDATION, EffectDC():Make_Targets(0) )
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local target_card = EffectDC():Get_Targets(0) and EffectDC():Get_Targets(0):Get_CardPtr(0)
if target_card ~= nil then
if target_card:GetCardType():Test( CARD_TYPE_CREATURE ) ~= 0 and EffectSource() ~= nil then
EffectSource():Untap()
end
target_card:Discard()
end
</RESOLUTION_TIME_ACTION>
- Code: Select all
if EffectSource() ~= nil and EffectSource():NumAttacksThisTurn() == 0 then
-
Master Necro - Posts: 259
- Joined: 24 Apr 2013, 18:25
- Has thanked: 83 times
- Been thanked: 21 times
Re: Card Creation Request Thread
by gorem2k » 27 May 2013, 11:17
I request Thundercloud Shaman. I've made Sunrise Sovereign and Stinkdrinker Daredevil but this one, I can't figure. Thanks !
I've made Sunrise Sovereign and Stinkdrinker Daredevil but this one, I can't figure. Thanks !Re: Card Creation Request Thread
by thefiremind » 27 May 2013, 11:49
It's not really difficult, if you copy from Chain Reaction.gorem2k wrote:I request Thundercloud Shaman.
I optimized it a bit more (it counts how many Giants you control only once) but it wasn't necessary.
- Attachments
-
THUNDERCLOUD_SHAMAN_139738.zip- Fixed and tested
- (2.66 KiB) Downloaded 455 times
Last edited by thefiremind on 27 May 2013, 14:15, edited 1 time in total.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Card Creation Request Thread
by RiiakShiNal » 27 May 2013, 12:40
You're right, good catch. You also shouldn't be able to respond to choosing a player" and the last to abilities should have been marked dangerous and LKI_shield_effect_source.sumomole wrote:Stuffy Doll doesn't have target.
- Stuff Doll | Open
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Card Creation Request Thread
by gorem2k » 27 May 2013, 13:22
That was quick! appreciate the comments in xml and all but it didn't work 100%. I had 4 changeling creatures (all types) in play with 1 giant and no damage dealt to anyone.thefiremind wrote:It's not really difficult, if you copy from Chain Reaction.gorem2k wrote:I request Thundercloud Shaman.
I optimized it a bit more (it counts how many Giants you control only once) but it wasn't necessary.
Nice lightning effect though.
also I have another card I'd like to fix:
Runed Stalactite.
- Code: Select all
<STATIC_ABILITY filter_zone="ZONE_IN_PLAY">
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Equipped creature gets +1/+1 and is every creature type.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[La créature équipée gagne +1/+1 et a tous les types de créature.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[La criatura equipada obtiene +1/+1 y es de todos los tipos de criatura.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Die ausgerüstete Kreatur erhält +1/+1 und hat alle Kreaturentypen.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[La creatura equipaggiata prende +1/+1 e ha tutti i tipi di creatura.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[装備しているクリーチャーは＋１/＋１の修整を受けるとともにすべてのクリーチャー・タイプである。]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Equipped creature gets +1/+1 and is every creature type.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Снаряженное существо получает +1/+1 и обладает всеми типами существ.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[A criatura equipada recebe +1/+1 e é de todos os tipos de criatura.]]></LOCALISED_TEXT>
<CONTINUOUS_ACTION layer="6">
local parent = Object():GetParent()
if parent ~= nil then
parent:GetCurrentCharacteristics():Characteristic_Set( CHARACTERISTIC_CHANGELING, 1 )
end
</CONTINUOUS_ACTION>
<CONTINUOUS_ACTION layer="7C">
local parent = Object():GetParent()
if parent ~= nil then
parent:GetCurrentCharacteristics():Power_Add( 1 )
parent:GetCurrentCharacteristics():Toughness_Add( 1 )
end
</CONTINUOUS_ACTION>
</STATIC_ABILITY>
<ACTIVATED_ABILITY sorcery_time="1" filter_zone="ZONE_IN_PLAY">
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Equip {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Équipement {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Equipar {2}.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Ausrüsten {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Equipaggiare {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[装備 {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Equip {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Снарядить {2}]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Equipar {2}]]></LOCALISED_TEXT>
<COST type="Mana" cost="{2}" />
<TARGET_DEFINITION id="0">
local filter = Object():GetFilter()
filter:Clear()
filter:AddCardType( CARD_TYPE_CREATURE )
filter:SetZone( ZONE_IN_PLAY )
filter:SetController( EffectController() )
-- AI 'cannot reequip' exemption
local parent = Object():GetParent()
if parent ~= nil and EffectController():IsAI() ~= 0 then
filter:SetCardInstance(parent)
filter:AddExtra(FILTER_EXTRA_FLIP_CARD_INSTANCE)
end
</TARGET_DEFINITION>
<TARGET_DETERMINATION>
return AtLeastOneTargetFromDefinition(0)
</TARGET_DETERMINATION>
<PLAY_TIME_ACTION target_choosing="1">
EffectController():ChooseTarget( 0, "CARD_QUERY_CHOOSE_CREATURE_TO_EQUIP", EffectDC():Make_Targets(0) )
</PLAY_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local target_card = EffectDC():Get_Targets(0):Get_CardPtr(0)
if (target_card ~= nil and EffectSource() ~= nil) then
EffectSource():Attach( target_card )
end
</RESOLUTION_TIME_ACTION>
<AI_AVAILABILITY type="equip" />
</ACTIVATED_ABILITY>
Re: Card Creation Request Thread
by Master Necro » 27 May 2013, 13:33
I need help with this one, it doesn't pick up the trigger at the start of the upkeep:
- Attachments
-
- screeching bat.rar
- Help :)
- (2.72 KiB) Downloaded 281 times
-
Master Necro - Posts: 259
- Joined: 24 Apr 2013, 18:25
- Has thanked: 83 times
- Been thanked: 21 times
Re: Card Creation Request Thread
by sumomole » 27 May 2013, 14:01
Has all creature types doesn't mean has the changeling keyword ability. The following code is used to Mutavault, the official card has 222 creature types(not 221gorem2k wrote:also I have another card I'd like to fix: Runed Stalactite
), and I add Germ as 1222, if you add new creature types, should change 1222 to the amount of your creature types.- Code: Select all
<CONTINUOUS_ACTION layer="4">
if EffectSource() ~= nil then
local characteristics = EffectSource():GetCurrentCharacteristics()
characteristics:SubType_GetWritable(EffectSource()):Clear()
for i = 1000,1222 do
characteristics:SubType_GetWritable(EffectSource()):Add( i , EffectSource() )
end
end
</CONTINUOUS_ACTION>
Last edited by sumomole on 27 May 2013, 15:12, edited 2 times in total.
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Re: Card Creation Request Thread
by RiiakShiNal » 27 May 2013, 14:08
If you don't mind including my choose creature type LOLs then you can use the constants to get all of the creature types (all 228, including Germ, Hippogriff, Siren, Surrakar, Townsfolk, Hyena, and Noggle, which were not included in the base game, but cards use them with current Oracle text):sumomole wrote:Has all creature types doesn't mean has the changeling keyword ability. The following code is used to Mutavault, the official card has 221 creature types, and I add Germ to 222, if you add new creature types, should change 1222 to the amount of your creature types.
_CREATURE_TYPE_FIRST
_CREATURE_TYPE_LAST
Also most people added Germ as 1221 (the 222nd type) because it is 0 based not 1 based.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Card Creation Request Thread
by sumomole » 27 May 2013, 14:26
Ah~ I see a lot of errors, I suggest you do some simply card first, When you are familiar with the rules and code, You can create complex card without error, of course, this is just my suggestion, I hope you don't mind..Master Necro wrote:I need help with this one, it doesn't pick up the trigger at the start of the upkeep:
And there is Screeching Bat firemind has coded.
- cards.zip
- Screeching Bat
- (2.79 KiB) Downloaded 275 times
NEMESiS wrote:Anybody has Tooth and Nail?
- Tooth and Nail.zip
- (118.66 KiB) Downloaded 294 times
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Re: Card Creation Request Thread
by thefiremind » 27 May 2013, 14:29
It appears that the game didn't like my optimization. That made me discover something strange that will be food for thought in a Programming Talk topic very soon. Anyway, you can redownload the ZIP, without optimization it works.gorem2k wrote:That was quick! appreciate the comments in xml and all but it didn't work 100%. I had 4 changeling creatures (all types) in play with 1 giant and no damage dealt to anyone.
That doesn't depend on me, I just selected the same effect as Chain Reaction.gorem2k wrote:Nice lightning effect though.
I can't see anything wrong in your code... are you sure that there weren't other effects around?gorem2k wrote:bug: equipped Goblin gets +1/+1 and all types but other unequipped Goblin creature in play receive changeling as well. Don't know if you see what I mean..
Adding changeling is still an acceptable approximation in my opinion, since changeling itself probably suffers some approximations as I wrote here. Adding all creature types manually could potentially bring more problems than it solves, because in DotP2012 it led to strange effects (I can't remember exactly what happened, I think some other cards stopped working while the card with all creature types was in play, even if they were apparently unrelated).sumomole wrote:Has all creature types doesn't mean has the changeling keyword ability. The following code is used to Mutavault, the official card has 221 creature types, and I add Germ to 222, if you add new creature types, should change 1222 to the amount of your creature types.
My version was able to transform only once. BlindWillow found a workaround but I have never been able to understand it completely, that's why I abandoned transform cards in DotP2013.sumomole wrote:And there is Screeching Bat firemind has coded.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Return to New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels)
Who is online
Users browsing this forum: No registered users and 6 guests