Page 55 of 102

Re: Card Creation Request Thread

PostPosted: 15 May 2013, 05:54
by sumomole
Vasht wrote:Hi,

could someone code Soul's Majesty ? thx

Edit: wanted to add Tribal Flames to my request (if possible)

Re: Card Creation Request Thread

PostPosted: 15 May 2013, 14:16
by nivmizzet1
sumomole wrote:
nivmizzet1 wrote:Can someone create Cradle of Vitality? I didn't think it would be hard, but then I tried and failed miserably.
Yes, it's easy to code, you can copy "you may pay {1}{W}. If you do," from Sigil of the New Dawn, "put +1/+1 counter on target creature" from Decree of Savagery, "Whenever you gain life" and “for each 1 life you gained" from False Cure. These are the official card. :wink:
I tried using sigil of the new dawn (official) + well of lost dreams (official) + death's presence (from a community mod) but I couldn't get it to work, it was just a bit too complicated for me. I managed to get the trigger working, and selecting a target to get the counters, and asking the player if they want to pay or not (although the question to pay came after the targetting), but after all that the mana doesn't tap and the counters don't get added, so there's something clearly wrong with my code, and I'm not surprised. Where can I find False Cure?

The first M14/D14 card

PostPosted: 16 May 2013, 03:17
by sumomole
Archangel of Thune.jpg

Archangel of Thune.zip
(102.76 KiB) Downloaded 159 times

Re: Card Creation Request Thread

PostPosted: 16 May 2013, 04:55
by Kieran
Thanks sumomole! I actually just watched the video. Either way, can I request Death Cloud, Past in Flames,
Virulent Swipe, Lavaball Trap, Counterlash, Dark Temper, and Into the Core.

Edit: I just finished Virulent Swipe and Into the Core.

Edit: This is off-topic but does anyone have the art for Punish the Enemy by Slawomir Maniak? I'd love to make that my title screen and wallpaper.

Re: Card Creation Request Thread

PostPosted: 16 May 2013, 09:48
by sumomole
nivmizzet1 wrote:I tried using sigil of the new dawn (official) + well of lost dreams (official) + death's presence (from a community mod) but I couldn't get it to work, it was just a bit too complicated for me. I managed to get the trigger working, and selecting a target to get the counters, and asking the player if they want to pay or not (although the question to pay came after the targetting), but after all that the mana doesn't tap and the counters don't get added, so there's something clearly wrong with my code, and I'm not surprised. Where can I find False Cure?
Cradle of Vitality | Open
Code: Select all
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Whenever you gain life, you may pay {1}{W}. If you do, put a +1/+1 counter on target creature for each 1 life you gained.]]></LOCALISED_TEXT>
    <TRIGGER value="PLAYER_GAINED_LIFE" simple_qualifier="controller" />
    <TARGET_DEFINITION id="0">
    local filter = Object():GetFilter()
    filter:Clear()
    filter:AddCardType( CARD_TYPE_CREATURE )
    filter:SetZone( ZONE_IN_PLAY )
    filter:SetHint( HINT_ALLIED_ONLY, EffectController() )
    </TARGET_DEFINITION>
    <TARGET_DETERMINATION>
    return AtLeastOneTargetFromDefinition(0)
    </TARGET_DETERMINATION>
    <PLAY_TIME_ACTION target_choosing="1">
    EffectController():ChooseTarget( 0, "CARD_QUERY_CHOOSE_CREATURE_TO_GET_LIFE_GAINED_PLUS1_PLUS1_COUNTER", EffectDC():Make_Targets(0) )
    </PLAY_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    local player = EffectController()
    if target ~= nil and player ~= nil then   
       if player:CanAfford("{1}{W}") == 1 then
         player:SetCustomQueryInstructionCardPtr( target )
          player:BeginNewMultipleChoice()   
          player:AddMultipleChoiceAnswer( "CARD_QUERY_DO_NOTHING" )   
          player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_PAY_1W" )   
          player:AskMultipleChoiceQuestion( "CARD_QUERY_MC_CRADLE_OF_VITALITY" )
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    local player = EffectController()
    if target ~= nil and player ~= nil then   
      local decision = Object():GetMultipleChoiceResult()
       if player:CanAfford("{1}{W}") == 1 then
          if decision ~= 0 then
            player:TapLand("{1}{W}")
           target:AddCounters( MTG():PlusOnePlusOneCounters(), GetAmount() )
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
Some cards need functions, you can download from here.
Past in Flames has the same problem with Snapcaster Mage, if you don't know what wrong with it, please see here.
cards.zip
(549.17 KiB) Downloaded 127 times

Re: Card Creation Request Thread

PostPosted: 16 May 2013, 11:33
by nivmizzet1
sumomole wrote:
Cradle of Vitality | Open
Code: Select all
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Whenever you gain life, you may pay {1}{W}. If you do, put a +1/+1 counter on target creature for each 1 life you gained.]]></LOCALISED_TEXT>
    <TRIGGER value="PLAYER_GAINED_LIFE" simple_qualifier="controller" />
    <TARGET_DEFINITION id="0">
    local filter = Object():GetFilter()
    filter:Clear()
    filter:AddCardType( CARD_TYPE_CREATURE )
    filter:SetZone( ZONE_IN_PLAY )
    filter:SetHint( HINT_ALLIED_ONLY, EffectController() )
    </TARGET_DEFINITION>
    <TARGET_DETERMINATION>
    return AtLeastOneTargetFromDefinition(0)
    </TARGET_DETERMINATION>
    <PLAY_TIME_ACTION target_choosing="1">
    EffectController():ChooseTarget( 0, "CARD_QUERY_CHOOSE_CREATURE_TO_GET_LIFE_GAINED_PLUS1_PLUS1_COUNTER", EffectDC():Make_Targets(0) )
    </PLAY_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    local player = EffectController()
    if target ~= nil and player ~= nil then   
       if player:CanAfford("{1}{W}") == 1 then
         player:SetCustomQueryInstructionCardPtr( target )
          player:BeginNewMultipleChoice()   
          player:AddMultipleChoiceAnswer( "CARD_QUERY_DO_NOTHING" )   
          player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_PAY_1W" )   
          player:AskMultipleChoiceQuestion( "CARD_QUERY_MC_CRADLE_OF_VITALITY" )
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    local player = EffectController()
    if target ~= nil and player ~= nil then   
      local decision = Object():GetMultipleChoiceResult()
       if player:CanAfford("{1}{W}") == 1 then
          if decision ~= 0 then
            player:TapLand("{1}{W}")
           target:AddCounters( MTG():PlusOnePlusOneCounters(), GetAmount() )
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
You are a champion!

Re: Card Creation Request Thread

PostPosted: 16 May 2013, 14:02
by nivmizzet1
I would like to request Martyr of Sands, if I may. It's the last card I need for my lifegain deck!

Re: Card Creation Request Thread

PostPosted: 16 May 2013, 14:55
by thefiremind
nivmizzet1 wrote:I would like to request Martyr of Sands, if I may. It's the last card I need for my lifegain deck!
While it's true that I'm very likely to remember when I already coded a card for a request, while other people probably can't, it's also true that using the search function on this thread takes less than one minute... :roll: :wink:
viewtopic.php?f=64&t=4557&p=115645#p115654

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 00:00
by nivmizzet1
thefiremind wrote:
nivmizzet1 wrote:I would like to request Martyr of Sands, if I may. It's the last card I need for my lifegain deck!
While it's true that I'm very likely to remember when I already coded a card for a request, while other people probably can't, it's also true that using the search function on this thread takes less than one minute... :roll: :wink:
viewtopic.php?f=64&t=4557&p=115645#p115654
I have every card from your DLC, and sumomole's DLC, and Blindwillow's DLC, and "the community" DLC. If a card isn't in there, I assume it hasn't been made. I'll start searching here before I post in future though (although I was doing that before, and the cards I wanted were never here, so I stopped). Thanks for pointing me in the right direction.

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 00:09
by thefiremind
Just to be clear, I didn't want to be harsh, and I'm sorry if I seemed so. It's just much more practical for you (and for everyone else) if you can fetch the cards you need without having to wait for someone else to do the search. :)

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 04:28
by nivmizzet1
thefiremind wrote:Just to be clear, I didn't want to be harsh, and I'm sorry if I seemed so. It's just much more practical for you (and for everyone else) if you can fetch the cards you need without having to wait for someone else to do the search. :)
Thanks for clarifying. Sometimes things can slip through the net though; e.g. I have sumomoles mod, and after searching the forums AND the cards I have I couldn't find Guttersnipe, so I made it. Later I was searching for my own guttersnipe and sumomole's appeared in the search also. :roll:

On another note; Martyr of Sands was coded slightly wrong -- it had "tap self" as part of the cost for the activated ability when it shouldn't (it's one of the things that actually makes the card great instead of just OK, imo).

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 09:13
by thefiremind
nivmizzet1 wrote:Sometimes things can slip through the net though;
[...]
On another note; Martyr of Sands was coded slightly wrong -- it had "tap self" as part of the cost for the activated ability when it shouldn't (it's one of the things that actually makes the card great instead of just OK, imo).
It also appears that many many times, errors slip through my cards... #-o I probably copied that part from another card and forgot to remove the TapSelf. :lol:

About finding filled requests, I made something useful here, check it out:
viewtopic.php?f=64&t=4557&p=93923#p93923

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 09:24
by Scion of Darkness
I need some help here, i tried to code the izzet charm but its giving me some problems can someone take a look please? its the last piece for my hive mind deck =P

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 09:38
by thefiremind
Scion of Darkness wrote:I need some help here, i tried to code the izzet charm but its giving me some problems can someone take a look please? its the last piece for my hive mind deck =P
This is strange, SCRIPT_LOG.TXT says that your first call to AddMultipleChoiceAnswer has the wrong number of parameters, but it doesn't... :? unless there's something that I didn't notice. Could someone else take a look?

Re: Card Creation Request Thread

PostPosted: 17 May 2013, 09:53
by sumomole
Scion of Darkness wrote:I need some help here, i tried to code the izzet charm but its giving me some problems can someone take a look please? its the last piece for my hive mind deck =P
You copy the code from two different "charm" cards? I suggest you only follow the code of official "charm" card. :)

Code: Select all
EffectDC():Set_Int( 2, Object():GetMultipleChoiceResult() )
and
Code: Select all
local decision = Object():GetMultipleChoiceResult()
EffectDC():Set_Int(1, decision)