Request for Cards/Source Code

[Yoichi]

I've found a some cards I'd like to use that aren't implemented:

• Sharding Sphinx (Set: Shards of Alara)
• Baleful Strix (Set: Planechase 2012)
• Parasitic Strix (Set: Conflux)
• Tainted Isle (Set: Torment)

I'm fairly confident this wouldn't be a big deal if I could just pull the source code and build my own version with these added, but since your google code page got DMCAed, is there somewhere else read-only access to the source code is available?

Actually, I guess pretty much all the PCH2 stuff needs adding?

[noxx]

You may get sources here:

Code: Select all

https://github.com/magefree/mage

I may add these cards by myself, they are easy to implement, but if you want you may code them by yourself.

[Yoichi]

Cheers for that. Well, I plan to have a play around just to learn how the codebase works, at least, even if you do end up adding those cards soonish anyway.

I'm having some trouble building from (unmodified) source though - mvn install is building everything from Root through to Server Console just fine but failing most of the tests - I'm seeing a lot of "java.lang.IllegalArgumentException: Couldn't load deck, deck size=7". Specifically, it is failing all the tests it does not skip, and all of them are throwing the same error.

Oh, and I'm using Maven 3.0.4 and JDK 1.7.0.

[noxx]

I use maven 2.2.1 and JRE 1.6.0_30 on Win7
and maven 3.0.3 and JRE 1.6.0_31 on Mac OS X

On both environments tests work.

Code: Select all

Results :
Tests run: 272, Failures: 0, Errors: 0, Skipped: 21

[jeffwadsworth]

Hello. I use JDK 1.6 also, 1.7 may be causing the issue for you. Everything builds fine and all tests pass. Have you tried using an IDE client? Netbeans 7.1.1 here.

[Yoichi]

Still having issues, with both JDK1.6 and 1.7, and both from the command line and in Netbeans. Clearly the problems are specific to me, so no doubt I've screwed something somewhere.

[jeffwadsworth]

Still having issues, with both JDK1.6 and 1.7, and both from the command line and in Netbeans. Clearly the problems are specific to me, so no doubt I've screwed something somewhere.

Try modifying the line
protected static boolean testmode;
Located in main.java under Mage.server.
protected static boolean testmode = true;

[Yoichi]

Sadly, it still explodes during the testing phase of the build. FWIW I'm also seeing java.lang.reflect.InvocationTargetException and null pointer exceptions. Not a clue what is going on - tomorrow I will try on a different machine.

[noxx]

First of all, please try to update to most recent version, I've commited some jars that may affect running tests.

Secondly, maybe something bad with the jars in your maven repository.
Try to remove them manually (the whole folder):

Code: Select all

.m2\repository\org\mage\

Inform if it doesn't help.

[North]

This skips the tests.

Code: Select all

mvn install -DskipTests

You can install the 3rd party libs from the repository directory if you haven't done so already. The batch file didn't work for me the last time so I copied the contents of the directory into my maven repository manually.

Eclipse is known to cause issues, if this is what you are using. I don't think anyone from the team uses it anymore. Noxx may tell you more on this. Netbeans and InteliJ have no problem with this.

PS: I hope this minor impediment won't stop you from joining our project as a developer. I'll be looking forward to welcoming you aboard.

[Yoichi]

So, after creating a fresh clone of the repo, and running the commands in repository/install-maven.bat manually, everything works fine now (without skipping the tests). Woot.

Also, FYI I am not using Eclipse.

[North]

I'm glad to hear this.
You can find some helpful information no the wiki. The Developers Getting Started and Developer Notes pages are what you will be interested in. There is an easy way to test the cards you are working on. This is explained in there.

[dragon5911]

i hope im posting in the correct topic, sorry if i am not.
I would like to use the following cards:
teferi's puzzle box
mindmoil
patron wizard
drowner of secrets
anvil of bogardan
kederekt parasite
spiteful visions
walking archive
greatbow doyen
brigid, heor of kinsbaile
lys alana bowmaster
azami, lady of scrolls
supreme inquisitor
fallowsage
surgespanner
ghostway
day of the dragons
momentary blink
boon refelction
furnace of rath
rage reflection
there are more but i didn't want to overdo it more than i already have
thank you for your time.

[Backfir3]

Hi, in the next days i'll have same free time to dedicate to Mage, i've already done some cards but i need to test them. When I'll post the code, do you prefer java files or a git patch file? I used to send java files to BetaSteward but he seems to be gone ...

Bye
Backfir3

[noxx]

I'm glad that more and more people get interested in Mage.
And I remember you already programmed some cards for it.

You may attach files in any format here (java or git patch). I'll take a look at them.

Best Regards,
Noxx