Adding new cards with Groovy

[ShawnieBoy]

Having a problem with defining tokens. I wasn't expecting that the definitions are updated for all tokens if the definition changes. With the code below, if more Ooze tokens are created, the older Oozes become the new X/X values.

How best can I sneak the value x into the MagicPlayTokensAction?

Code: Select all

[
    new MagicSpellCardEvent() {
        @Override
        public MagicEvent getEvent(final MagicCardOnStack cardOnStack,final MagicPayedCost payedCost) {
            final int x=payedCost.getX();
            return new MagicEvent(
                cardOnStack,
                this,
                "Put "+x+" "+x+"/"+x+" green Ooze creature tokens onto the battlefield."
            );
        }
        @Override
        public void executeEvent(final MagicGame game, final MagicEvent event) {
            final MagicPlayer player=event.getPlayer();
            final MagicCardDefinition oozeDef = TokenCardDefinitions.get("green Ooze creature token");
            int x = event.getCardOnStack().getX();
            oozeDef.setPowerToughness(x,x);
            game.doAction(new MagicPlayTokensAction(
                player,
                oozeDef,
                x
            ));
        }
    }
]


and the token bare-bones script

Code: Select all

name=green Ooze creature token
token=Ooze
image=http://magiccards.info/extras/token/shards-of-alara/ooze.jpg
value=2
type=Creature
subtype=Ooze
color=g
cost={0}


Will also help for Miming Slime, Mystic Genesis, Ooze Flux, Ooze Garden and Slime Molding

[melvin]

MagicCardDefinition is shared among all the cards with the same definition, so it is not a good idea to modify it. The best way to accomplish the X/X Oooze is to use MagicAddStaticAction to add a MagicStatic that sets the pt to X/X. So the steps are:
1) create the action MagicPlayTokenAction as a variable, i.e. final MagicPlayTokenAction act = new MagicPlayTokenAction(...). This variable is needed to retrieve the permanent created later with getPermanent().
2) create the token by calling doAction, i.e. game.doAction(act)
3) game.doAction(new MagicAddStaticAction(act.getPermanent(), new MagicStatic(MagicLayer.SetPT) { <see Elvish_Branchbender.groovy> }))

[ShawnieBoy]

Thanks so much for that, that'll work perfect for the other cards, however I've hit a snag.

the getPermanent() only returns one Permanent. Would it be worth adding a getPermanents<Collection>() specific to the MagicPlayTokensAction (plural) instead of the default from MagicPutIntoPlayAction()?

[melvin]

Sure, sounds logical to have a getPermanents method to MagicPlayTokens action so it is possible to retrieve the permanents created later. Go ahead and add it, just post here if you run into any issues.

[ember hauler]

I'm a bit confused with given_ability= and enchant= - which one to use and when?

For example, here is Rancor:

Code: Select all

name=Rancor
url=http://magiccards.info/arc/en/67.html
image=http://mtgimage.com/card/rancor.jpg
value=4.582
rarity=C
type=Enchantment
subtype=Aura
cost={G}
given_pt=2/0
given_ability=trample
timing=aura
enchant=trample,pos creature
ability=dies effect Return SN from the graveyard to its owner's hand.


Both given_ability= and enchant= are present.

And here is Spirit Link:

Code: Select all

name=Spirit Link
url=http://magiccards.info/10e/en/45.html
image=http://mtgimage.com/card/spirit%20link.jpg
value=4.024
rarity=U
type=Enchantment
subtype=Aura
cost={W}
timing=aura
enchant=lifelink,creature
requires_groovy_code


Only enchant= is present.

What is the correct way?

Also, what is the difference between "creature" and "pos creature"?

[ember hauler]

Ok, I figured out that given_ability=lifelink is missing in Spirit Link to make correct calculation of life gained in groovy code. But why enchant=lifelink is still there?

[melvin]

given_ability=<ability> means enchanted permanent gains <ability>

enchant=<hint1>,<hint2 target> give the AI some hints as to how to pick a target, there are custom heuristics for trample, first strike, and a few other common auras. pos and neg is to hint to the AI whether to prioritize its own permanents (pos) or the opponents (neg).

[ShawnieBoy]

Sorry to rain on your parade, but Spirit Loop doesn't give Lifelink, it does "when enchanted creature deals damage, you gain that much life." Very similar but different. Lifelink is a state based effect which doesn't use the stack and is an ability which doesn't stack with itself. The second option uses the stack (so you can die if it's on the stack and you have 0 life), and stacks with Lifelink and other damage/lifegain options.

[ember hauler]

given_ability=<ability> means enchanted permanent gains <ability>

enchant=<hint1>,<hint2 target> give the AI some hints as to how to pick a target, there are custom heuristics for trample, first strike, and a few other common auras. pos and neg is to hint to the AI whether to prioritize its own permanents (pos) or the opponents (neg).

Ok, thanks!
I guess the script for Spirit Loop which I submitted should be corrected again:

enchant=lifelink,pos creature

(as a hint for AI).

[ember hauler]

Sorry to rain on your parade, but Spirit Loop doesn't give Lifelink, it does "when enchanted creature deals damage, you gain that much life." Very similar but different. Lifelink is a state based effect which doesn't use the stack and is an ability which doesn't stack with itself. The second option uses the stack (so you can die if it's on the stack and you have 0 life), and stacks with Lifelink and other damage/lifegain options.

Cool, it's good to know the difference.
Thanks!

[melvin]

Ok, thanks!
I guess the script for Spirit Loop which I submitted should be corrected again:

enchant=lifelink,pos creature

(as a hint for AI).

This line was in your original submission and is currently in the card script. Now that I think about it the "pos" hint should be removed, to make it the same as Spirit Link. The reason is that this card can also be used to disable the opponent's creature as it is the controller of the enchantment that gains life, unlike lifelink where the controller of the creature gains life.

[hong yie]

wants to know the script of dark banishing before been simplified. i mean every line of code in it. or where i can look for it. thank's.

[melvin]

wants to know the script of dark banishing before been simplified. i mean every line of code in it. or where i can look for it. thank's.

The earliest version is this one: https://code.google.com/p/magarena/sour ... 45ad469b55

If you're interested in what the groovy script looks like for such as effect, you could look at Death Mutation's script from https://code.google.com/p/magarena/sour ... ion.groovy

[ember hauler]

Now that I think about it the "pos" hint should be removed, to make it the same as Spirit Link. The reason is that this card can also be used to disable the opponent's creature as it is the controller of the enchantment that gains life, unlike lifelink where the controller of the creature gains life.

Please note that Spirit Loop can only enchant the creature you control, not opponent's creature.

[melvin]

Please note that Spirit Loop can only enchant the creature you control, not opponent's creature.

Thanks for the reminder, I missed that. In that case the enchant line should be:

Code: Select all

enchant=lifelink,creature you control


Fixed in https://code.google.com/p/magarena/sour ... 09e4047b57