Page 1 of 8

Project Firemind is back

PostPosted: 05 Aug 2014, 15:28
by mike
The break I was forced to take is now finally over.

This means firemind.ch is fixed, updated and has all the new cards in its database.

I'm sorry for all the trouble the delay has caused with submitting card scripts!

I've also collected a number of smaller issues and features that I'll hopefully be able to work on soon.

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 05:23
by melvin
Glad to have you back, mike :)

Like to request for an update of the card templates to use the ones in Magarena/scripts_missing

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 09:55
by mike
Just replaced them with the ones from the current repo clone.

When testing it I just noticed that I'm missing some of the name encoding to find the proper file. (Karona's Zealot -> Karona_s_Zealot.txt for example) Could you point me to the code that does this for magarena so I can do it the same way here?

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 10:14
by Lodici
I think this is what you are looking for...
getScriptFilename() in src\magic\data\CardDefinitions.java?

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 10:30
by mike
I think this is what you are looking for...
getScriptFilename() in src\magic\data\CardDefinitions.java?
Exactly. Thanks Lodici.

It's implemented now.

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 11:48
by Lodici
Is there any value, interest or even possibility of trying to better integrate Magarena with Firemind? Submitting scripts directly, for example, springs immediately to mind. Also, there is a kind of after-thought feature in the duel decks screen where you can run sample duels for the player deck against the AI deck. But doesn't Firemind do that and better? Just thinking aloud, but might as well put the idea out there! :)

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 14:43
by ShawnieBoy
Lodici wrote:Is there any value, interest or even possibility of trying to better integrate Magarena with Firemind? Submitting scripts directly, for example, springs immediately to mind. Also, there is a kind of after-thought feature in the duel decks screen where you can run sample duels for the player deck against the AI deck. But doesn't Firemind do that and better? Just thinking aloud, but might as well put the idea out there! :)
I'd also add being able to import/export decks. Would be nice to be able to import the top decks of Firemind while in Magarena.

Re: Project Firemind is back

PostPosted: 06 Aug 2014, 15:14
by mike
Is there any value, interest or even possibility of trying to better integrate Magarena with Firemind? Submitting scripts directly, for example, springs immediately to mind.
It seems to me like this would require quite a bit of code on the Magarena side for very little gain in usability. If I read correctly there is already the option to open card scripts in a text editor from Magarena. Copy&Pasting those to firemind seems simple enough. It's probably even easier because in the Browser one is already logged in to firemind while Magarena would have to handle the login from scratch.

A link to the card submission page from inside Magarena would be handy though.

Also, there is a kind of after-thought feature in the duel decks screen where you can run sample duels for the player deck against the AI deck. But doesn't Firemind do that and better?
I'd be happy to provide an API for creating duels automatically. It would still require a login though. Since it seems pretty time-consuming adding a JSON API Client on Magarena that supports logging in on firemind I'd recommend a simpler solution where Magarena can export a text file describing the params of the duel (both deck lists, number of rounds, etc.) which can than be uploaded to firemind.ch through the browser with an active user session. If someone wants to work on the Magarena side of that just tell me so we can work out the details.

I'd also add being able to import/export decks. Would be nice to be able to import the top decks of Firemind while in Magarena.
Firemind already supports the exporting part of that and since Magarena decks are just files too this requires nothing more than a wget from Magarena. If there is a desire for an API call to get the top decks from firemind as json/xml I'd be happy to provide one.

Re: Project Firemind is back

PostPosted: 07 Aug 2014, 07:19
by Lodici
Thanks mike. I agree that if a login is required then it is not worth the effort since I don't think your average Magarena player would be prepared to go through that process (unless there was a clear benefit to their playing experience).

mike wrote:A link to the card submission page from inside Magarena would be handy though.
I can add a link on the scripts viewer screen.

mike wrote:Firemind already supports the exporting part of that and since Magarena decks are just files too this requires nothing more than a wget from Magarena. If there is a desire for an API call to get the top decks from firemind as json/xml I'd be happy to provide one.
If you can provide a public json feed that would be cool. Maybe something like -
Code: Select all
{
  "<deck name>": {
    "description" : <deck description>
    "author": "<deck author>",
    "link": "<link to firemind deck page>",
    "rating": "<firemind rating>",
    "releaseDate": "<YYYYMMDD>",
    "cards": [
      {
        "name": "<card name>",
        "quantity": "<quantity>",
      },
      {
        "name": "<card name>",
        "quantity": "<quantity>",
      },...
    ]
  },
  "<deck name>": {
     ...
  }
}
Only the deck name, card name and quantity are mandatory.

Re: Project Firemind is back

PostPosted: 08 Aug 2014, 06:19
by mike
The JSON structure looks good. Thanks.

I'll include it in the next release and post the URL here.

Re: Project Firemind is back

PostPosted: 08 Aug 2014, 08:20
by mike
The JSON export is live now and can be accessed at: http://www.firemind.ch/decks/top.json

I grouped the ratings by format (standard, modern, etc.) so the context of the rating is correct and it actually means something.

Re: Project Firemind is back

PostPosted: 08 Aug 2014, 08:38
by Lodici
Awesome - thanks Mike. I have added it to the TODO list as issue 643.

Re: Project Firemind is back

PostPosted: 09 Aug 2014, 22:52
by PalladiaMors
Guys, I'm sorry to hijack the topic, but I'd like to ask a couple questions about Firemind and it looks like nobody has posted a comment in there for months, so I though maybe this would be a better place to do that.

a) Is it possible to delete decks? I've looked at every corner of the screen at every page in there and I can't find a delete button anywhere.

b) Why does Firemind use the Vegas AI? The AI comparison article in the Magarena wiki seems to strongly indicate that Monte Carlo is significantly stronger. This is in no way meant as criticism, to me it really makes no big difference, I was just curious as to why one is used over the other?

c) Any chance that the new cards in the 1.53 build can already be included in there?

Re: Project Firemind is back

PostPosted: 10 Aug 2014, 02:16
by mike
Hi, dev of firemind here.

First of all, thanks for the feedback. Firemind is developed by this once guy who just came back from a 5 month forced break so it is definately possible that something no longer makes sense or was bad from the beginning. I do appreciate all feedback on Project Firemind and am willing to shape it in the interests of the community.

To answer your questions:

a) I disabled deleting decks because it would have made it almost impossible to get consistently game results if decks vanished all the time. By now I should have enough results to re-enanble it or at least allow users to hide them.

b) no clue. Over a year ago when I coded the ai worker it must have made sense then. Now things seem to have changed. Maybe a quick feedback from the magarena devs on the bot settings I should use?

c) updating the magarena version for firemind is still a manual process that I only do with stable magarena releases to prevent problems with the site. But this request touched on something that is on my feature list for magarena: a separate ai worker that has the latest magarena release available and runs the card submissions in duels to determine weather they work or not. Maybe this separate workers can be made available to users to run duels on.

Re: Project Firemind is back

PostPosted: 10 Aug 2014, 14:38
by PalladiaMors
I'd also be very interested in hearing what Lodici, Melvin and Shawnie think about what advantages there would be in using one AI over the other for Firemind. I have very limited understanding of these things, but my opinion is that in the end it makes little difference since it is the same AI for everyone and therefore I don't see how it interferes in determining how competitive a deck is, which I guess is the main interest people have in Firemind. Then again, if I understood correctly, the wiki explains that Monte Carlo is the strongest of the three available options and I suppose it would make sense to use it for the site?

About the delete option. In my opinion it really is necessary, I mean, suppose someone uses Firemind regularly and creates new decks all the time, he's gonna end up with a ton of decks and it'll be really difficult to sort out through the mess. I'm supposing you might be worried with stuff like people who will regularly delete decks that perform badly and how that will impact the rating system or something. I can see that being a problem, but still I just think that the ability to delete a deck is too important, even if there are drawbacks.

Thanks for creating Firemind and for taking to time to answer the questions!