Page 1 of 2

Bug Reports for Magarena 1.76

PostPosted: 28 Aug 2016, 13:33
by melvin
To help us in addressing bugs, the best way is to create an issue on the issue tracker. This lets us keep track each report separately and ensures it doesn't get lost.
https://github.com/magarena/magarena/issues (requires github account)

For game play bugs, please include a gameplay report zip file. You can create a gameplay report by opening the options menu (press Esc during a duel) and selecting the "Gameplay Report" menu item.

Less preferred is to post your report in this thread. (requires forum account)

You can report anonymously via gitreports, note that name/email if provided will be listed on the issue tracker.
https://gitreports.com/issue/magarena/magarena (no sign-up required, name/email optional)

Re: Bug Reports for Magarena 1.76

PostPosted: 29 Aug 2016, 15:40
by Byron
Two playable card images would not download, plus 66 unimplemented cards would not download.

I was going to include the clipboard copy of these errors, but this program said "Your post looks too spamy for a new user, please remove off-site URL's"

Re: Bug Reports for Magarena 1.76

PostPosted: 30 Aug 2016, 00:14
by ShawnieBoy
Byron wrote:Two playable card images would not download, plus 66 unimplemented cards would not download.

I was going to include the clipboard copy of these errors, but this program said "Your post looks too spamy for a new user, please remove off-site URL's"
Those cards will be the new ones from Conspiracy: Take the Crown. Magiccards.info doesn't have them up as yet (nor Eternal Masters for that matter) - Also I'm not sure if the HQ Pics forum has any of them yet. As for now, hold tight, and they should be available in the future :)

Another option would be to use Gatherer Extractor

Re: Bug Reports for Magarena 1.76

PostPosted: 30 Aug 2016, 20:45
by Byron
OK, thanks

Re: Bug Reports for Magarena 1.76

PostPosted: 04 Sep 2016, 01:18
by Huggybaby
Hello Melvin, would a crash.log file help?

Re: Bug Reports for Magarena 1.76

PostPosted: 04 Sep 2016, 03:21
by melvin
Huggybaby wrote:Hello Melvin, would a crash.log file help?
Absolutely! crash.png would be very useful as well if it has been generated. It is a screenshot the app at the point of crash.

Re: Bug Reports for Magarena 1.76

PostPosted: 04 Sep 2016, 03:37
by Huggybaby
OK, see attached. The png file doesn't look like what was on the screen when it crashed though.

Re: Bug Reports for Magarena 1.76

PostPosted: 04 Sep 2016, 09:54
by melvin
Huggybaby wrote:OK, see attached. The png file doesn't look like what was on the screen when it crashed though.
Thanks, this is a known issue but still good to capture a few different cases where it happens as we are not sure of the cause. Added the crash report to https://github.com/magarena/magarena/issues/685

Re: Bug Reports for Magarena 1.76

PostPosted: 05 Sep 2016, 09:04
by muppet
AI sacrificed Defense of the Heart and fetched Form of the Dragon.
SO either creature is not specified or Form of the Dragon is tagged as a creature.

Re: Bug Reports for Magarena 1.76

PostPosted: 05 Sep 2016, 16:45
by ShawnieBoy
melvin wrote:
Huggybaby wrote:OK, see attached. The png file doesn't look like what was on the screen when it crashed though.
Thanks, this is a known issue but still good to capture a few different cases where it happens as we are not sure of the cause. Added the crash report to https://github.com/magarena/magarena/issues/685
Couldn't this null-pointer be a 'download images on demand' error related to the first bug?

btw magiccards.info has been updated now, so this shouldn't occur again, if it is the problem.

Re: Bug Reports for Magarena 1.76

PostPosted: 05 Sep 2016, 16:51
by ShawnieBoy
muppet wrote:AI sacrificed Defense of the Heart and fetched Form of the Dragon.
SO either creature is not specified or Form of the Dragon is tagged as a creature.
Hmm, without a log, it's hard to say what's happening. Suffice to say that it's neither of those problems. Creatures are specified, and Form of the Dragon isn't a creature.

There must be something else going on. :? (Enchantments are creatures? AI actually cast it and didn't put it onto the battlefield from Defense of the Heart?)

Re: Bug Reports for Magarena 1.76

PostPosted: 06 Sep 2016, 00:23
by melvin
ShawnieBoy wrote:Couldn't this null-pointer be a 'download images on demand' error related to the first bug?
I feel that it is unlikely as the NPE bug has been around for a while. Do you have specific reasons for thinking they are related?

Re: Bug Reports for Magarena 1.76

PostPosted: 06 Sep 2016, 11:19
by ShawnieBoy
melvin wrote:
ShawnieBoy wrote:Couldn't this null-pointer be a 'download images on demand' error related to the first bug?
I feel that it is unlikely as the NPE bug has been around for a while. Do you have specific reasons for thinking they are related?
From the crash log:
Code: Select all
Caused by: java.lang.NullPointerException
   at java.text.Normalizer.normalize(Unknown Source)
   at magic.data.CardDefinitions.getASCII(CardDefinitions.java:164)
   at magic.model.MagicCardDefinition.getAsciiName(MagicCardDefinition.java:289)
   at magic.data.CardDefinitions.loadMissingCards(CardDefinitions.java:377)
   at magic.data.CardDefinitions.getMissingCards(CardDefinitions.java:457)
   at magic.ui.image.download.UnimplementedPanel.getCards(UnimplementedPanel.java:30)
   at magic.ui.image.download.ScanWorker.getImagesDownloadList(ScanWorker.java:23)
   at magic.ui.image.download.ScanWorker.doInBackground(ScanWorker.java:29)
   at magic.ui.image.download.ScanWorker.doInBackground(ScanWorker.java:8)
   at javax.swing.SwingWorker$1.call(Unknown Source)
   at java.util.concurrent.FutureTask.run(Unknown Source)
   at javax.swing.SwingWorker.run(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
To me that looks like the downloader was told to get something that wasn't there. It's a null pointer, but a different one :)

npe_everywhere.jpg


It was my bad for the image download errors, I completely forgot that magiccards.info had stuttered for a while. Going forward it may well be that we'll be ahead of them when it comes to releases.

Re: Bug Reports for Magarena 1.76

PostPosted: 06 Sep 2016, 12:03
by Lodici
@Huggybaby's crash log actually contains three exception reports. The issue raised here was related to the final report at the end of the file and looks very similar to reports in issue #685 as mentioned by @melvin. The first two were generated in 1.74 in July and may be related to the download on demand as suggested, although we would need confirmation from @Huggybaby as to whether the download-on-demand setting is enabled. My suspicion is it might be to do with running the images download dialog in the background while playing a game.

Re: Bug Reports for Magarena 1.76

PostPosted: 08 Sep 2016, 10:42
by muppet
ShawnieBoy wrote:
muppet wrote:AI sacrificed Defense of the Heart and fetched Form of the Dragon.
SO either creature is not specified or Form of the Dragon is tagged as a creature.
Hmm, without a log, it's hard to say what's happening. Suffice to say that it's neither of those problems. Creatures are specified, and Form of the Dragon isn't a creature.

There must be something else going on. :? (Enchantments are creatures? AI actually cast it and didn't put it onto the battlefield from Defense of the Heart?)
Sorry I think I figured out what must have happened it was odd it only got one card... So I think it got 2 creatures and sacced one to the other and got the form in that way. I'll keep a closer eye on it next time.