Page 2 of 4

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 15:10
by eidanyoson
Korath wrote:Two thoughts on that -
  1. If you've installed in your Program Files directory, you need to unzip (and indeed do anything else that changes files there) as an administrator, or the User Account Control misfeature of recent Windows versions will break things, usually with less obvious symptoms.
  2. An overenthusiastic virus scanner may be intercepting changes to all dll files. If it were properly designed, it would tell you when it did so, so you could do something about the source of the problem.
Thank you. I´ll try some new things.

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 18:00
by HarlequinCasts
Are these error reports new? They look fantastic! :D

(Just an example, I haven't bothered to look into this case yet)

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 18:14
by Korath
Please tell me I didn't break Primeval Titan.

Yes, those error messages are finally working in this release; they can be translated semi-automatically into an actually-usable backtrace like
Code: Select all
functions/show_backtrace.c:16:show_backtrace(...)
functions/engine.c:1378:get_card_instance(...)
functions/engine.c:1322:create_legacy_effect_exe(...)
functions/functions.c:1952:create_targetted_legacy_effect(...)
cards/legends.c:3673:card_subdue(...)
call_cards_function<eax>(card_data_t *cd<eax>, int player, int card, event_t event)
dispatch_event_to_single_card(int player, int card, event_t event, int new_attacking_card_controller, int new_attacking_card)
resolve_top_card_on_stack()
put_card_on_stack3(int player, int card)
put_card_on_stack2(int player, int card)
sub_475A30(int TENTATIVE_player, const char *srcstr)
sub_436B00(signed int a1, event_t event, const char *srcstr, int a4)
allow_response(int a1, int phase, const char *a3, int event_or_trigger_or_phase)
main_phase(int player, int a4, int a5)
switch_phase(int a3)
start_duel()
start_duel_thread(int a1)
0x7704336a
0x77a49f72
0x77a49f45
(That's not the trace from your screenshot; I don't feel up to typing all the addresses in by hand. That's why it asks you for the dump file.)

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 18:20
by HarlequinCasts
lol no Primeval Titan is working great, at least it appears to be. I'll keep an eye on it :D

EDIT FYI the dump is as follows, but I didn't mean to make this a bug report, just an example:

bad parameters
in_play(0, -1)
0: 0x02351C04
1: 0x0231708B
2: 0x02046D38
3: 0x00457E4A
4: 0x02318F6F
5: 0x004779D9
6: 0x004367C3
7: 0x02316D92
8: 0x00475CBF
9: 0x02317E3E
10: 0x004371CE
11: 0x00477B1A
12: 0x004B37D7
13: 0x0043CD3D
14: 0x004399BD
15: 0x0047902C
16: 0x004946E9
17: 0x758033AA
18: 0x77269EF2
19: 0x77269EC5

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 18:21
by Korath
(And ooh, and I hadn't realized my hack for Painter's Servant would make Dryad Arbor show up green.)

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 17 Feb 2014, 18:24
by HarlequinCasts
Yeah I noticed that too, I think these days it has a green "color indicator" on the card instead of the wording but that's cool. No clue if its intended to actually be green in manalink!

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 18 Feb 2014, 14:41
by shamaatae
my virus programs says theres a trojan in manalinkeh.dll
so now i had to delete it all because program wont work without it and i cant tell my virusprogram to leave the file alone.

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 18 Feb 2014, 15:03
by Fizanko
As my MSE wasn't detecting anything on my side, i submitted the to metascan and virustotal so it would be tested by multiple antivirus engines, you can test yourself :
https://www.virustotal.com/
https://www.metascan-online.com/

on metascans, 4 of 40 antivirus find it infected : bitdefender, lavasoft, emisoft and f-secure.

on virustotal, 6 of 50 antivirus find it infected : ad-aware, bitdefender, emisoft, f-secure, gdata and microworld-escan.

That's not much, and considering the big antivirus guns do not find anything suspicious, i would think this is really a case of false positive from the antivirus that report it infected.

Re: Manalink Update 2014/02/15: Born of the Gods

PostPosted: 18 Feb 2014, 15:57
by HarlequinCasts
shamaatae wrote:my virus programs says theres a trojan in manalinkeh.dll
so now i had to delete it all because program wont work without it and i cant tell my virusprogram to leave the file alone.
This comes up every patch. And while there is a tiny chance something could be infected before distributing, the infinitely more probable explanation is that any cautious virus scanner might flag the unknown dll as a trojan (after all dlls are supposed to interact with your operating system).

Frankly, I never even bother checking manalink files, and I've downloaded every major and minor patch for a while now all without incident. My advice to anyone is just download the game and play it and don't do every little thing your virus scanner tells you to :D

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 00:53
by Korath
v2 posted. This should be hopefully be more stable. Knock on wood.

Includes one new card, Leyline of Sanctity, per stassy's request; it happened to already have csv rows and artwork, so I could just enable it. The other bugfinding cards will show up in the next full patch.

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 01:32
by gmzombie
just effin sweet dude. i love the new dump file for errors. does this mean we dont need to give a savegame or is still the practice? neither bothers me by the way but just curious if this simplifies the process

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 01:40
by Nexhro
Henceforth, your name shall be Mr InstaCode, Korath. Goats left and right, mwahahahaha!

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 01:43
by Korath
Dump files are a piece of information, sometimes a very useful one, but they're not magic pixie dust. Most of the time we're still going to need to know what you were doing when the error occurred (screenshots help here); and the folks confirming bugs are still going to want save games.

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 02:06
by Fizanko
Thank you for the v2 update !

Re: Manalink Update 2014/02/18: Born of the Gods v2

PostPosted: 19 Feb 2014, 03:57
by BAgate
A request: could you tell us when a new patch is released if there were any changes to any .dat files? It's just kind of a pain to redo borders and settings after every install, so if we don't have to overwrite certain .dats it would be nice to know.