It is currently 23 Oct 2019, 10:41
   
Text Size

Manalink update : June 09 2011 aka Squashing bugs

The latest Manalink updates are posted here.
PLEASE DO NOT BUMP OLD UPDATES!

Moderators: BAgate, drool66, stassy, Aswan jaguar, gmzombie, CCGHQ Admins

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 11 Jun 2011, 14:01

The Archmage bug is strange, as I'm sure of having fixed it. Do you have the Rules Engine card in play when you play the deck with Archmage Ascension ?
The other bug is new, so plese post it in the Bug section.

Edit : I've checked Archmage Ascension and work perfectly for me. Are you using Limited or Custom ? In case you're using custom, check if you've the misspelled the card name, it's crucial for Rules Engine to work.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby 0rion79 » 11 Jun 2011, 14:26

Yes, just tried right now: no counters even if I draw as hell with Sylvan Library, Jace, Treasure Trove, Staff of Domination & co....
User avatar
0rion79
 
Posts: 1518
Joined: 24 Feb 2009, 18:33
Location: Italy
Has thanked: 94 times
Been thanked: 56 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 11 Jun 2011, 16:54

I really dunno what's happening. Perhaps it's another difference in the EXE like the one about Doran. Try askik Jatill.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby 0rion79 » 11 Jun 2011, 17:15

Gargaroz wrote:I really dunno what's happening. Perhaps it's another difference in the EXE like the one about Doran. Try askik Jatill.
No, it does nothing in Limited version too: even if I draw as hell, it doesn't add any counter.
User avatar
0rion79
 
Posts: 1518
Joined: 24 Feb 2009, 18:33
Location: Italy
Has thanked: 94 times
Been thanked: 56 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 11 Jun 2011, 17:42

This is the strangest thing... It works for me.
Post this in the bug section and let's hear the others.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby 0rion79 » 11 Jun 2011, 17:44

Gargaroz wrote:This is the strangest thing... It works for me.
Post this in the bug section and let's hear the others.
before doing that, may you copy here the code pointer that you are using for that card? Thanks
User avatar
0rion79
 
Posts: 1518
Joined: 24 Feb 2009, 18:33
Location: Italy
Has thanked: 94 times
Been thanked: 56 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Snacko » 11 Jun 2011, 22:07

Some c fixes attached as a diff.
you had == when = was needed
you can't compare c strings with == but with strcmp
don't know if you know that instance->targets[19].card should be instance->parent_card and that arrays in c start from 0 so targets only goes to 18.
Snacko
DEVELOPER
 
Posts: 826
Joined: 29 May 2008, 19:35
Has thanked: 4 times
Been thanked: 73 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 12 Jun 2011, 01:34

Sorry Snacko, I don't know how to use the attached file.
Could you upload the fixed .c files in a zip container ?
It would be really helpful to improve my coding skills.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Aswan jaguar » 12 Jun 2011, 10:35

Gargaroz do we have to make fresh install because we have installed firstly the G.Y mod and then manalink june v3 and you specifically mentioned to install first the June v3 then mod does this clobber things?
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester
 
Posts: 6590
Joined: 13 May 2010, 12:17
Has thanked: 541 times
Been thanked: 281 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 12 Jun 2011, 12:23

No, Aswan Jaguar,as there are not filename conflict.
My reminder was there only for making things clears for the newbies of Manalink.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby stassy » 14 Jun 2011, 12:12

Aww it's too bad Phyrexian Metamorph is not fully implemented, the infinite combo Phyrexian Metamorph + Leonin Relic-Warder + Soul Warden cannot be used XD
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby 0rion79 » 14 Jun 2011, 12:18

Nice combo :)
User avatar
0rion79
 
Posts: 1518
Joined: 24 Feb 2009, 18:33
Location: Italy
Has thanked: 94 times
Been thanked: 56 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Snacko » 18 Jun 2011, 12:29

Gargaroz wrote:Sorry Snacko, I don't know how to use the attached file.
Could you upload the fixed .c files in a zip container ?
It would be really helpful to improve my coding skills.
Only changed files then.
Snacko
DEVELOPER
 
Posts: 826
Joined: 29 May 2008, 19:35
Has thanked: 4 times
Been thanked: 73 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Gargaroz » 18 Jun 2011, 12:48

Thanx a lot, Snacko ;)
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: Manalink update : June 09 2011 aka Squashing bugs

Postby Snacko » 24 Jun 2011, 14:11

I actually run the source code trough static analysis tool and fixed a lot of errors mostly with handling sprintf. Nearly all files changed so I packed them all.
Attachments
MagicCDll-fixed.zip
(641.14 KiB) Downloaded 231 times
Snacko
DEVELOPER
 
Posts: 826
Joined: 29 May 2008, 19:35
Has thanked: 4 times
Been thanked: 73 times

PreviousNext

Return to Patches

Who is online

Users browsing this forum: No registered users and 3 guests


Who is online

In total there are 3 users online :: 0 registered, 0 hidden and 3 guests (based on users active over the past 10 minutes)
Most users ever online was 287 on 31 Mar 2019, 04:11

Users browsing this forum: No registered users and 3 guests

Login Form