It is currently 24 Jul 2021, 02:16
   
Text Size

[fixed] TYPE_NONCREATURE doesn't mean that

Moderators: BAgate, drool66, stassy, Aswan jaguar, gmzombie, CCGHQ Admins

[fixed] TYPE_NONCREATURE doesn't mean that

Postby Korath » 18 Jul 2021, 21:17

(Sorry for not using the form, it's a bad fit and I haven't actually tested this, or even built yet.)

Everything here also applies to the similarly-new TYPE_NONLAND.

Code: Select all
TYPE_NONCREATURE      = TYPE_LAND | TYPE_ENCHANTMENT | TYPE_ARTIFACT | TYPE_SPELL,
Defining TYPE_NONCREATURE like that, and then using it in a form that eventually becomes "type & TYPE_NONCREATURE" - as just about all current uses do - doesn't mean "is only one or more of land, enchantment, artifact, instant, interrupt, or sorcery", it means "is one or more of enchantment, artifact, instant, interrupt, or sorcery". That is, is_what(cardid, TYPE_NONCREATURE) will be true for Dryad Arbor, Lucent Liminid, Obsianus Golem, and Visitor from Planet Q. You really do have to end up using !(type & TYPE_CREATURE). Should be easiest to test with Fae of Wishes // Granted.
Last edited by drool66 on 21 Jul 2021, 21:31, edited 1 time in total.
Reason: fixed
User avatar
Korath
DEVELOPER
 
Posts: 3527
Joined: 02 Jun 2013, 05:57
Has thanked: 491 times
Been thanked: 1040 times

Re: [fixed] TYPE_NONCREATURE doesn't mean that

Postby drool66 » 21 Jul 2021, 21:32

Thanks, Korath
Fixed, currently checking full functionality.
User avatar
drool66
 
Posts: 633
Joined: 25 Nov 2010, 22:38
Has thanked: 150 times
Been thanked: 139 times


Return to Pending Reports

Who is online

Users browsing this forum: No registered users and 0 guests


Who is online

In total there are 0 users online :: 0 registered, 0 hidden and 0 guests (based on users active over the past 10 minutes)
Most users ever online was 1922 on 07 Jun 2021, 06:01

Users browsing this forum: No registered users and 0 guests

Login Form