[fixed] Wrong dynamic iids released at eot

by **Aswan jaguar** » 09 Jan 2023, 09:00

Describe the Bug:
I don't know if you can find anything from this error as it is from my dev, I have only a change on engine.c from what we have on git which doesn't seem to be the cause of this issue. I have no clue what is though, happened for AI as usual.

blue dump.txt: (272 Bytes) Downloaded 111 times

I am attaching the deck if you can't find from above, to play a bit.

Copy of Grand Illusion.txt: (574 Bytes) Downloaded 122 times

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Based on commit accf88a ("Recommit aaf84de which was reverted back by commit 6bdf6a2", 2023-01-05)/ Gauntlet

What exactly should be the correct behavior/interaction?

Are any other cards possibly affected by this bug?
-

by **drool66** » 10 Jan 2023, 04:30

Please attach ManalinkEh.dbg for the dump file to be useful.

by **Aswan jaguar** » 10 Jan 2023, 08:05

Try this savegame in gauntlet if it loads for you it will be more helpful and easier for you to debug.

blue deck dump.rar: (3.65 KiB) Downloaded 92 times

by **drool66** » 10 Jan 2023, 16:11

I'm getting a lot of CTDs but no dumps yet
[EDIT] Seems to be related to Phyrexian Metamorph and Phyrexian casting costs
[EDIT] Actually, has something to do with cloning

by **drool66** » 21 Jan 2023, 19:51

Fixed. ending_phase() was releasing the original_internal_iid's of everything instead of the current internal_card_id (the dynamic iids actually being used) so any dynamic iid not stored in a dummy3 was being improperly released. I made the same mistake in token_generation::resolve_iid()

EDIT: Fixed in commit 43cf98d ("Check current iids for dynamic iid release candidates", 2023-01-23)