[wait]Humble effects-as long as..creature get +x/+x clause

[stassy]

Sticky topic for this list as it seems each card needed to be recoded one by one.
Currently needed:

- coded spell that turn creature into X/X and make it lose all ability
Turn // Burn
Dragonshift
Ovinize
Snakeform
Titania's Song
Turn to Frog

- coded creatures with P/T mod and rules filtered with gets*+*long* or gets*-*long* string aka as long as something happen creature get +-X/+-Y
Sedge Troll as long as you control a swamp -fixed.
Giant Tortoise as long is untapped -fixed
Kird Ape - not affected.
Arcades Sabboth Each untapped creature you control gets +0/+2 as long as it's not attacking - not affected.
Beasts of Bogardan as long as an opponent controls a nontoken white permanent -fixed
Water Wurm as long as opponent controls an island-fixed
Wild Nacatl as long you control a plains or/and as long as you control a mountain.-not affected.
Gorilla Titan as long as there are no cards in your graveyard-fixed
Homarid As long as there is/are tide counter/s on Homarid -fixed
Skyshroud Elite as long as an opponent controls a nonbasic land - fixed
Thran Golem as long as is enchanted -fixed.
Mystic Enforcer Threshold ability -not affected.
Nimble Mongoose
Werebear
Putrid Imp
Seton's Scout
Fledgling Dragon
Leonin Den-Guard - not affected.
Auriok Glaivemaster -fixed
Konda's Hatamoto - not affected.
Descendant of Kiyomaro - not affected.
Flaring Flame-Kin
Gobhobbler Rats Hellbent ability -fixed.
Rakdos Pit Dragon
Slithering Shade
Sedge Sliver - fixed
Hedge Troll - not affected.
Gathan Raiders
Boggart Sprite-Chaser - fixed.
Kithkin Greatheart -fixed.
Vengeful Firebrand removes haste icon and ability? but still can attack the turn it came on board.
Isleback Spawn not properly affected by Humility with ability on it makes it a 2/2.
Divinity of Pride -fixed.
Court Homunculus - not affected.
Bant Sureblade -fixed.
Esper Stormblade -fixed.
Grixis Grimblade -fixed.
Jund Hackblade -fixed.
Naya Hushblade -fixed.
Guul Draz Specter -not affected.
Guul Draz Vampire -not affected.
Kitesail Apprentice as long as is equipped - fixed.
Loam Lion -not affected.
Ruthless Cullblade -not affected.
Champion's Drake -not affected.
Mul Daya Channelers -not affected.
Serra Ascendant -fixed.
Auriok Sunchaser Metalcraft -fixed
Carapace Forger
Chrome Steed
Ezuri's Brigade
Ghalma's Warden
Ardent Recruit
Razorfield Rhino
Spire Serpent
Griffin Rider -fixed.
Druid's Familiar Soulbond ability not affected.
Stonewright
Trusted Forcemage
Wildwood Geist -not affected.
Wolfir Silverheart
Arctic Aven -fixed
Crimson Muckwader -fixed.
Flinthoof Boar -fixed.
Harbor Bandit -fixed.
Jace's Phantasm -fixed.
Prized Elephant -fixed.
Blood Baron of Vizkopa -fixed.

[Korath]

I'm pretty sure it wasn't a list of cards that makes other cards lose abilities that was needed, but rather a list of cards whose abilities aren't properly suppressed. (Other than by Titania's Song, which will always work properly.)

Digressing a bit:

Titania's Song's approach is a lot more scalable than the way Humility and its lookalikes work in C. What it does is

• Send the card an EVENT_DISABLE_ABILITIES, in case it works by changing globals or flags on other cards as it enters or leaves play. The only card that ever responded to that was Library of Leng, and that only back before it was patched to not skip the discard phase entirely anymore; but many C cards make this kind of shortcut. (A warning flag in itself.)
• Create a new card type, overriding its type to Artifact Creature, power and toughness to the card's mana cost, color to colorless, and - importantly - extra_abilities bitfield to just EA_BECAME_CREATURE and code_pointer to a function that just returns 0.
• And attach a legacy which changes the attached-to card's type to that newly-created one, and sends EVENT_ENABLE_ABILITIES if the legacy leaves play.

This is much easier and much less error-prone than checking is_humiliated() in every single card's function. That's patently unsustainable.

We could probably implement "disable all activated abilities" with a similar approach, leaving the original code_pointer and most of the extra_abilities bitfield in place but removing EA_ACT_ABILITY and EA_ACT_INTERRUPT. Again, checking can_use_activated_abilities() in the function of every single card with activated abilities isn't scalable.

"Disable all non-mana abilities" is a bit harder, but can still be done by only doing a full disable if EA_MANA_SOURCE is unset, and checking with those cards' functions as is currently done.

As for the turn-to-X/X part of these effects, it breaks if more than one is applied. Sorceress Queen seems to work correctly, but I can't find the code for its effect card.

[HarlequinCasts]

Just checking in here, are we still doing anything with this thread and/or does it need to be stickied?

[Korath]

I don't know that it ever needed to be.

[stassy]

Well, let's get started again then

Humble + Crazed Goblin (attack if able ability)

[Gargaroz]

Update : we've almost recoded all the existing cards in C, so most of these bugs will probably fixed shortly.

[Aswan jaguar]

I have retested all cases above and tagged them.There are still a lot of cards that don't honour "loose all abilities" and "loose all abilities and become x/x creature" effect.
My tests were conducted with Humble.When I couldn't use Humble I used Humility which is quite bugged and Ovinize was used to test Blood Baron of Vizkopa.
Humility bugs: viewtopic.php?f=86&t=16292&p=174206&hilit=Humility#p168716
From the above list large groups/abilities that are still bugged are:
Threshold and Soulbond.
Also there are many cards that their lookalikes are working but they don't. e.g Kird Ape, Wild Nacatl don't work while Sedge Troll works.
Leonin Den-Guard doesn't work while Auriok Glaivemaster works.
There other cases also like that.