C[still bugged]If dealt damage this way would die, exile it

[Korath]

Describe the Bug:
If all the damage from a card stating "If a creature dealt damage this way would die this turn, exile it instead" is prevented, the creature's still exiled if it dies.

Which card did behave improperly ?
I noticed it on Yamabushi's Flame.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Post-FRF.

What exactly should be the correct behavior/interaction ?
Damage prevention is a replacement effect, so if all damage is prevented, the creature's not "dealt damage this way". It shouldn't get the exile effect.

Are any other cards possibly affected by this bug ?
All of them: Anger of the Gods, Annihilating Fire, Demonfire, Pillar of Flame, Red Sun's Zenith, Serpentine Spike, Touch of the Void, Yamabushi's Flame, Yamabushi's Storm.

I haven't tested, but I'm sure that if some or all of the damage is redirected, the creature it's redirected to doesn't get the effect, either.

Disintegrate is worth mentioning; it's templated differently, so the creature's affected whether or not damage is prevented or redirected.

I haven't checked the old cards, but it probably also happens with all "dealt damage this way" effects:

1. Attack if able: Aggravate
2. Can't cast: Aurelia's Fury
3. Can't regenerate: Flamebreak, Incinerate, Jaya Ballard, Task Mage,
4. Emblem: Chandra, Fire of Kaladesh // Chandra, Roaring Flame
5. Tap: Aurelia's Fury (again), Pathway Arrows

I included new cards since AFAIK the machinery to handle this properly doesn't exist yet in Manalink, and I don't plan to port it from Shandalar myself at this time. If someone else gets to it before me, in src/Shandalar/effects.cpp in NB or later (introduced in commit 0dc9f67), see the attach_when_deals_damage parameter in deal_damage() and its handling in targets[5].player of fx_damage_for_exe().

[BAgate]

Confirmed for old cards as well.

[Gargaroz]

Fixed for all the case you mentioned and Carbonize.
The funny part is that Korath already made almost everything needed for that, it only lacked the final implementation, maybe he forgot that

[Korath]

Carbonize is different from the cases above. Its target gets the effect whether damage is dealt or not, since it's templated the same way as Disintegrate.

[Gargaroz]

Yup! Fixed.

[BAgate]

Still not working: Red Sun's Zenith (effect before damage prevention)
Chandra, Fire of Kaladesh (transforms before damage prevention step on 3rd pt of damage)

[Gargaroz]

Red Sun's Zenith slipped past me and it's fixed.
Chandra, Fire of Kaladesh, on the other hand, it's more problematic...