[fixed]Path of Bravery gives extra +20 life at 1st trigger

by **Aswan jaguar** » 04 Apr 2017, 18:22

Describe the Bug:
Path of Bravery has again this bug:
viewtopic.php?f=110&t=13781&p=146707&hilit=path+of+bravery#p146690

Which card did behave improperly?
Path of Bravery

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 2016/08/27: Eldritch Moon v2, duel

What exactly should be the correct behavior/interaction?
Path of Bravery gain only life equal to attacking creatures.

Are any other cards possibly affected by this bug?
-

by **Korath** » 04 Apr 2017, 21:40

Was broken in 910722a, for absolutely no reason.

by **Aswan jaguar** » 24 Feb 2019, 17:08

Fixed/reverted to previous target value in commit f73dce8bc.
Where should I look for to get an idea what the targets "[x number]" does in get_card_instance(player, card)->targets[9].player?

by **Korath** » 25 Feb 2019, 00:16

You have to look everywhere. Every function and its brother misappropriates the targets array to stuff in its own data, when really nothing should be there at all except for a card's actual targets. This is one of the reasons Manalink is so very frustrating to work with.

In this case, there's nothing special about targets[9]; the problem was with targets[1], which is what 910722a changed it to. targets[1] is set and used by src/functions/functions.c:store_attackers(), as called by declare_attackers_trigger().