[fix/close]Restless Apparition no get pump p/t ability att/b

[Aswan jaguar]

Describe the Bug:
AI doesn't consider Restless Apparition pump p/t ability when deciding to attack or block.

Which card did behave improperly?
Restless Apparition - AI part

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 2016/08/27: Eldritch Moon v2, duel

What exactly should be the correct behavior/interaction?
AI when deciding to attack or block knows that the ability gives +3/+3 for every it pays.

Are any other cards possibly affected by this bug?
-

[stassy]

same behavior with Seal of Strength : AI use it as defensive ability when feeling overwhelmed by another pumping ability and will use it on overkill.

[Korath]

That's consistent with the reported bug.

The AI picks what creatures it uses to attack or block procedurally: it builds large tables of each potential attacker's and blocker's power and toughness, its current abilities, and - crucially - what abilities and power/toughness boosts those and other cards say they can apply. Those potential abilities and power/toughness modifications have to be programmed explicitly, using the Inflatable Power/Inflatable Toughness flags coupled with the EVENT_POW_BOOST/EVENT_TOU_BOOST events (for power/toughness changes a creature gives to itself); EVENT_CHECK_PUMP (for power/toughness changes an instant in the AI's hand or a permanent on the bf can give to any creature); or EVENT_CHECK_ABILITIES (for power, toughness, or ability changes a permanent on the bf can give to specific creatures, e.g. Pia Nalaar could only use this, not the simpler EVENT_CHECK_PUMP, since it can only pump artifact creatures).

The AI decides whether to activate a given ability by saving the game state, picking some random legal action, seeing what happens, restoring the game state, and repeating, so - once a given combat state has actually arisen - it can find activations like Seal of Strength's and Restless Apparition's without any more effort on our part than to make them activateable for the human. But these combat situations won't actually arise unless the AI would have been desperate enough to attack or block even if the cards weren't pumpable.

[Aswan jaguar]

Has already been fixed in dev. I merged effect cards in commit 542fccb.