[fixed]Protection vs. damage-can't-be-prevented effects

[Korath]

Describe the bug:
Silver Knight takes no damage from Earthquake despite an earlier-resolved Flaring Pain.

Which card behaved improperly?
effect_damage().

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Dev 3c9405a.

What exactly should be the correct behavior/interaction?
Protection actually prevents damage; it doesn't cause it not to be assigned (like Farrel's Zealot does), cause damage to not be marked on a card (like infect or wither do), or replace the damage without being prevention (like General's Regalia or Ghosts of the Innocent do); so an effect reading "damage can't be prevented" or "damage inflicted by [this creature] can't be prevented" or "[this card] deals [x] damage to target [whatever]. The damage can't be prevented" effects aren't affected by it. The last one still won't be able to target the creature with protection, of course.

702.16e Any damage that would be dealt by sources that have the stated quality to a permanent or player with protection is prevented.

About half the cards that make damage unpreventable have relevant rulings, whose wording and coverage vary greatly. The clearest and most complete I've seen is on Excruciator here.

Are any other cards possibly affected by this bug?
All the cards that approximate protection from anything except artifacts or colors? I know there's cards in Manalink with protection from creatures, like Beloved Chaplain; I can't recall any with protection from anything else offhand.

[Aswan jaguar]

Some other protection from * for reference:
Devoted Caretaker.
Diregraf Escort.
Elite Inquisitor.
Emrakul, the Aeons Torn.
Enemy of the Guildpact.
Guardian of the Guildpact.
Midnight Duelist.
Petrified Wood-Kin.
Polis Crusher.
Progenitus.
Runed Halo.
True-Name Nemesis.
Tsabo Tavoc.

Dragon Hunter - uncoded.

[Aswan jaguar]

Everything here seems to be fixed by drool66 in commit f900813 and in commit 2ce322b if I am not wrong, except Petrified Wood-Kin which wasn't changed to new protection functions.
Also from the cards coded Riders of Gavony didn't receive the treatment of new protection functions.

[drool66]

Huh. Protection from instants is a regular keyword ability and it should work. I wonder why Petrified Wood-Kin didn't have it

Thank you for pointing out Riders of Gavony, I missed that one. Done & will push soon.

[drool66]

Both fixed in 3aae19c