Page 1 of 1

[confirm]AI-Guardian Idol tap for mana then animate & untap

PostPosted: 17 Aug 2017, 07:34
by Aswan jaguar
Describe the Bug:
AI can tap Guardian Idol for mana pay 1 more mana to animate (correctly)but also untap it in the same time.This doesn't happen for player. fixed

Which card did behave improperly?
AI - Guardian Idol

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 2016/08/27: Eldritch Moon v2, duel

What exactly should be the correct behavior/interaction?
When AI animates a tapped Guardian Idol it doesn't untap.

Are any other cards possibly affected by this bug?
-

Re: AI-Guardian Idol tap for mana then animate & untap

PostPosted: 17 Aug 2017, 08:06
by Korath
Has nothing to do with what it pays the mana with or how it got tapped: when the AI, or remote player in multiplayer, activates the animation ability, it taps the card before charging mana and untaps it after. The right way to do this is
  1. Remove the player == AI check. (Same as everywhere else it exists. Check IS_AI(player) instead if you must, but that's not needed here.)
  2. Add STATE_NO_AUTO_TAPPING before charging mana, instead of STATE_TAPPED. This not only makes it do the right thing when the AI activates, but also when the human double-clicks for automatic mana payment.
  3. Remove STATE_NO_AUTO_TAPPING after charging mana, only if it wasn't there already when you added it earlier.

Re: [confirm]AI-Guardian Idol tap for mana then animate & un

PostPosted: 11 Mar 2019, 21:49
by Aswan jaguar
Fixed in commit b885fe4 in my tests seems to work fine for AI and human but I will leave it open for a fix at least for 3nd point above.