[fix]Dack Fayden control ability vs Magus of the Unseen eot

by **Aswan jaguar** » 17 Oct 2017, 16:18

Describe the Bug:
If Dack Fayden ability to steal an artifact is applied to an artifact already stolen by Magus of the Unseen at eot the artifact returns to owner.

Which card did behave improperly?
Dack Fayden? Magus of the Unseen? steal mechanism?

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel

What exactly should be the correct behavior/interaction?
If Dack Fayden ability to steal an artifact is applied to an artifact already stolen by Magus of the Unseen at eot the artifact remains to Dack Fayden 's controller.

Are any other cards possibly affected by this bug?
Possibly some of the permanent change control effects vs the change control till eot.

by **Aswan jaguar** » 11 Jan 2021, 15:10

Fixed in commit a3fe8d1.
Is there any reason or something I am overlooking not to change all cards using gain_control() to the better gain_control_permanently() which almost all of the former cards mean in fact "gain control permanently". Is there a case where gain_control() would be better? Otherwise all the cards using the former will have this issue unless they target only opponent cards.

by **Aswan jaguar** » 25 Mar 2021, 14:20

Fixed the rest cards and functions affected by this in commit efb1b0c ("Fixed gain control permanently targeting gain control till eot.", 2021-03-25)
I left gain_control() to 3,4 cards that target only opponent cards so they won't exhibit this bug.