[confirmed]Perpetual Timepiece ability costs wrong
Report wrong Card behavior to get it fixed.
PLEASE ADD SAVEGAMES TO YOUR TOPIC !
PLEASE ADD SAVEGAMES TO YOUR TOPIC !
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
[confirmed]Perpetual Timepiece ability costs wrong
by drool66 » 18 Oct 2017, 07:52
Describe the Bug:
Perpetual Timepiece charges for its first abilityfixed
Which card did behave improperly?
Perpetual Timepiece
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel
What exactly should be the correct behavior/interaction?
the cost for the first ability is
Are any other cards possibly affected by this bug?
-
Which card did behave improperly?
Perpetual Timepiece
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel
What exactly should be the correct behavior/interaction?
the cost for the first ability is
Are any other cards possibly affected by this bug?
-
- Attachments
-
- PerpetualTimepiece.zip
- (3.2 KiB) Downloaded 152 times
Last edited by Aswan jaguar on 06 Jun 2020, 17:16, edited 2 times in total.
Reason: confirmed-strikethrough fixed
Reason: confirmed-strikethrough fixed
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
Re: [confirmed]Perpetual Timepiece ability costs wrong
by Aswan jaguar » 20 Oct 2017, 13:23
2- Perpetual Timepiece 2nd ability doesn't shuffle any or all cards from your graveyard to library just shuffles library, it does get exiled.
Last edited by Aswan jaguar on 06 Jun 2020, 17:16, edited 1 time in total.
Reason: strikethrough fixed
Reason: strikethrough fixed
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: [confirmed]Perpetual Timepiece ability costs wrong
by Aswan jaguar » 06 Jun 2020, 17:15
Fixed activation issues of both abilities in commit 5fae5ca.
I don't understand how to fix the bug of 2nd ability that doesn't have an effect when it resolves.
I don't understand how to fix the bug of 2nd ability that doesn't have an effect when it resolves.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: [confirmed]Perpetual Timepiece ability costs wrong
by drool66 » 06 Jun 2020, 20:25
select_multiple_cards_from_graveyard (used in the activation) uses get_grave rather than graveyard_source, so the disconnect is between the activation & resolution referencing different data. Of all functions, this one is probably the one that would most benefit from using graveyard_source. Adding a graveyard_source of version of select_multiple_cards_from_graveyard (and therefore also turn_card_in_grave_face_up/down) is on my list of things to do, since I will need to do it for the Escape mechanic.
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
Re: [confirmed]Perpetual Timepiece ability costs wrong
by Aswan jaguar » 07 Jun 2020, 10:21
I saw your message on the code about this, can you enlighten the differences and why we need both versions and not only select_multiple_cards_from_graveyard with graveyard_source?drool66 wrote:select_multiple_cards_from_graveyard (used in the activation) uses get_grave rather than graveyard_source, so the disconnect is between the activation & resolution referencing different data. Of all functions, this one is probably the one that would most benefit from using graveyard_source. Adding a graveyard_source of version of select_multiple_cards_from_graveyard (and therefore also turn_card_in_grave_face_up/down) is on my list of things to do, since I will need to do it for the Escape mechanic.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: [confirmed]Perpetual Timepiece ability costs wrong
by drool66 » 08 Jul 2020, 21:12
Just seeing this reply now.
I'm sure you've seen the difference between get_grave & graveyard_source at the top of deck.c; the point is when cards are removed from the GY, get_grave changes but graveyard_source does not. select_multiple_cards_from_graveyard solves this by replacing each card selected with a 904 - face-down card, but only while the player is selecting. The problem arises when something removes cards from the GY between activation & resolution - int that case get_grave (and therefore select_multiple_cards_from_graveyard) will reference the wrong data and either return the wrong cards or glitch. My point is basically that with the functions we have you can't select multiple cards without using the mostly inferior get_grave, and the more cards you're selecting the greater chance for error.
The problem with Perpetual Timepiece is just that its activation uses select_multiple_cards_from_graveyard (ie. get_grave, via new_select_a_card) but its resolution uses validate_target_from_grave_source, that's all (at least I think so).
I'm sure you've seen the difference between get_grave & graveyard_source at the top of deck.c; the point is when cards are removed from the GY, get_grave changes but graveyard_source does not. select_multiple_cards_from_graveyard solves this by replacing each card selected with a 904 - face-down card, but only while the player is selecting. The problem arises when something removes cards from the GY between activation & resolution - int that case get_grave (and therefore select_multiple_cards_from_graveyard) will reference the wrong data and either return the wrong cards or glitch. My point is basically that with the functions we have you can't select multiple cards without using the mostly inferior get_grave, and the more cards you're selecting the greater chance for error.
The problem with Perpetual Timepiece is just that its activation uses select_multiple_cards_from_graveyard (ie. get_grave, via new_select_a_card) but its resolution uses validate_target_from_grave_source, that's all (at least I think so).
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
6 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 59 guests