Page 1 of 1

Hollowhenge Spirit not working with if attacked/blocked

PostPosted: 02 Dec 2017, 11:59
by Aswan jaguar
Describe the Bug:
1- Hollowhenge Spirit doesn't have flying.fixed
2- When Hollowhenge Spirit enters the battlefield, can't remove target blocking creature from combat - illegal target.(works only for attacking creature).
3- Hollowhenge Spirit etb ability can be cancelled although you have legal attacking or blocking creature targets.


Which card did behave improperly?
Hollowhenge Spirit

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel

What exactly should be the correct behavior/interaction?
1- Hollowhenge Spirit has flying.
2- When Hollowhenge Spirit enters the battlefield, can also remove target blocking creatures from combat not only attacking. See ruling below.
3- Hollowhenge Spirit etb ability can't be cancelled if you have legal attacking or blocking creature targets.

this ruling has to be considered when a blocking creature is removed:
1/22/2011 Removing a blocking creature from combat doesn’t cause the creature it was blocking to become unblocked. If no other creatures are blocking that attacking creature, it won’t assign combat damage (unless it has trample).
Are any other cards possibly affected by this bug?
-

Re: Hollowhenge Spirit no flying+etb cancellable+no blockers

PostPosted: 03 Dec 2017, 02:50
by Korath
Flying is a csv error, so it's in Shandalar too; it's fixed in 8816ad8.

Re: Hollowhenge Spirit etb cancellable+no blockers

PostPosted: 21 Apr 2019, 12:20
by Aswan jaguar
The remove blocking creature from combat is not working for all the cards that have it no matter if they leave attacking creature unblocked like Ydwen Efreet, False Orders do or not, like Hollowhenge Spirit does when the existing function "remove_state(player, card, STATE_BLOCKING)" is inserted of course.

Now Ydwen Efreet and False Orders target creature are not removed from combat (both visually and in function) and creatures they blocked don't become unblocked they still get and receive damage by blockers.
In False Orders in case you decide your blocker blocks another creature then it will receive and inflict damage to new attacker but the original blocked attacker doesn't become unblocked and inflict damage to player. Also if you choose opponent's blocker you never get asked if you want to assign it to block another attacker.

NOTE: Ydwen Efreet microprose version was working correctly it did remove the blocker from combat both visually and as an effect and the attacker did become unblocked and assigned combat damage if it wasn't blocked by another creature. I don't know if a hack was used as when was removed from combat it came in play tapped.

Re: Hollowhenge Spirit etb cancellable+no blockers

PostPosted: 21 Apr 2019, 22:13
by Korath
The part that card_ydwen_efreet() is missing is to set get_card_instance(player, card)->blocking = 0xff.

Though it should really, really, be factored out into a remove_from_combat() function instead of making the same bugs everywhere. Neither Ydwen Efreet nor Hollowhenge Spirit correctly set STATE_ATTACKED or STATE_BLOCKED either, for example, so its like the affected creatures never attacked or blocked at all - they won't be affected by things like Heat Stroke or Vizier of Deferment or Berserk.

Re: Hollowhenge Spirit etb cancellable+no blockers

PostPosted: 23 Apr 2019, 14:29
by Aswan jaguar
Fixed Hollowhenge Spirit and Ydwen Efreet.
I didn't fix False Orders and none will work correctly with cards like Heat Stroke or Vizier of Deferment or Berserk. I will leave this open for a proper fix the way you suggest.