[fixed]Three Dreams can tutor cards with the same name

[drool66]

Describe the Bug:
Three Dreams tutors three auras to the BF instead of to hand. Also, it does not enforce the "with different names" stipulation (although the prompt is correct).

Which card did behave improperly?
Three Dreams

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 0362fcdf version - duel

What exactly should be the correct behavior/interaction?
Three Dreams tutors three auras to hand instead of to the BF, and enforces that they have different names

Are any other cards possibly affected by this bug?
-

[Aswan jaguar]

Fixed the tutor destination in commit 9e813f9.
The other bug is also true for Saheeli Rai posted here:
viewtopic.php?f=86&t=21113&p=237495&hilit=Saheeli+Rai#p218776

[FastEddie]

new_global_tutor doesn't work properly when selecting same cards (or rather avoiding doing so). I have no clue why this is the case but using new_select_a_card and updating the array of chosen cards manually does the job.

I found four cards with such a mechanic, the other two worked (Gifts Ungiven and Uncage the Menagerie) because they use this workaround. To avoid further issues I added a comment to new_global_tutor just in case, diff is also attached.

This is the relevant code:

Code: Select all

   if (event == EVENT_RESOLVE_SPELL ){
      int chosen[3] = {-1, -1, -1};
      int num_chosen;

      test_definition_t test;
      default_test_definition(&test, TYPE_ENCHANTMENT);

      test.no_shuffle = 1;
      test.value_for_special_selection_function = (int)chosen;
      test.special_selection_function = test_not_in_array3;

      for (num_chosen = 0; num_chosen < 3; ++num_chosen){
         if (ai_is_speculating != 1){
            sprintf(test.message, "Select up to three Aura cards with different names. Card #%d of up to 3", num_chosen + 1);
         }
         
         int pos = new_select_a_card(player, player, TUTOR_FROM_DECK, 0, AI_MAX_VALUE, -1, &test);
         chosen[num_chosen] = deck_ptr[player][pos];
         if(pos == -1)
            break;
         chosen[num_chosen] = deck_ptr[player][pos];
         remove_card_from_deck(player, pos);
         add_card_to_hand(player, chosen[num_chosen]);
      }
      shuffle(player);

      kill_card(player, card, KILL_DESTROY);
   }


[Aswan jaguar]

Inserted above fix in commit 90a088b. Thanks, FastEddie.