[fixed]Wandering Fumarole change p/t can't be activated

[gnomefry]

Describe the Bug:

When activating Wandering Fumarole to become an elemental creature, it insists on tapping itself for mana during the activation -- even if sufficient mana was already paid from other sources. fixed


Which card behaved improperly?

Wandering Fumarole

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 5-2020 10bda4ca0 - gauntlet

What exactly should be the correct behavior/interaction?

Tapping itself for mana shouldn't be mandatory.

Are any other cards possibly affected by this bug?

No

[Aswan jaguar]

Wandering Fumarole fix adds mana when animated also fix animated land has lifelink & animated legacy is not cleared at eot in commit 599ffc6.
However activated ability of animated card still doesn't work.

[drool66]

It can't be activated because it uses create_targetted_legacy_effect() instead of create_targetted_legacy_activate(). But why don't we just add a third dialog option whose legality is contingent on is_what(player, card, TYPE_CREATURE), and use DLG_OMIT_ILLEGAL to hide it when Wandering Fumarole isn't a creature?

[Korath]

Off the top of my head?

• If another effect makes it a copy of another object else between activation and resolution of its animate ability (perhaps it's really a Thespian's Stage?), it should be an animated elemental version of that object that can switch power and toughness.
• If it loses all abilities between activation and resolution of its animate ability, it should have its power/toughness-switching ability (but not its mana or animation abilities) - the ability should have a timestamp independent of the Fumarole itself. Not that is_humiliated() honors timestamp order.
• Way more likely than either of those, lots of other effects besides its own animation ability can turn it into a creature.

[Aswan jaguar]

Animated ability can't be activated fixed in commit 16db32f.