[fixed]Spreading Seas / Mishra's Factory interaction

[gnomefry]

Describe the Bug:

Spreading Seas cast on a Mishra's Factory that has had its Assembly Worker effect activated causes it to remain a 2/2 island indefinitely.

Which card behaved improperly?

Spreading Seas or Mishra's Factory

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
version 8-2020 a62926f - gauntlet

What exactly should be the correct behavior/interaction?

Doing something to the original source of an already-activated 'until EOT' effect shouldn't keep the effect from wearing off at EOT.


Are any other cards possibly affected by this bug?

Possibly Evil Presence or Blood Moon type cards.

[drool66]

This is a known issue in change_lands_into_new_land_type();
from the_dark.c: #pragma message"Works fine except for animated lands : if a card that uses this function comes into play after an animated land is animated, it will remain animated forever"

[Aswan jaguar]

I searched and I couldn't find another bug report about this in forum so this stays and is confirmed of course.

[Korath]

src/shandalar/change_type.cpp, which feel free to adapt, does this correctly. (Well, at least it does this part of it correctly; it doesn't attempt to find dependencies any harder than Manalink does or MicroProse did.) The key part is to record the internal_card_id of the object it's changing, and to create_a_card_type() again if that id has changed.

[drool66]

Fixed (at least this interaction) in 5d3cb77. Also affects Phantasmal Terrain, Evil Presence, and other cards that call their function.