[fixed]Can't play draft - Mismatch Rarity.dat & cards.dat

[Blyfycyfyfyf]

I just downloaded "Proverbs, Myths & Fairy Tales v1.1 8cb1a18" and since I unpacked the files to my existing Manalink 3 location, I cannot play draft, I am getting the mentioned exception. Screenshot attached.

I have no custom mods, changes etc. apart of On previous version the draft was working correctly.

It happens no matter what packs and rariry mode I choose.

[Aswan jaguar]

I confirm this bug. Something to do with foolosopher's new gui selector drool66?
EDIT: It happens also in current 3f87c76 commit.

[Korath]

It's impossible for it not to give that message.

Code: Select all

   size_t tc = fread(&total_cards, 4, 1, f);
   if( total_cards != available_slots || tc != 4 ) {
      do_dialog(HUMAN, player, card, -1, -1, "Mismatch between Rarity.dat\nand cards.dat", 0);
      lose_the_game(HUMAN);
   }

fread() is asked to read one item, and then the popup happens if it doesn't claim to have read four.

Code: Select all

RETURN VALUE
       On  success,  fread()  and  fwrite() return the number of items read or
       written.  This number equals the number of bytes transferred only  when
       size  is 1.  If an error occurs, or the end of the file is reached, the
       return value is a short item count (or zero).

If that check somehow passed, it would inevitably go on to complain "Invalid Rarity.dat" for the exact same reason, then that "final fread failed for read_rarities()" for similar reasons (and also because |= doesn't mean inequality).

[drool66]

I fixed & stashed this a while ago when I included foolosopher's draftgui changes. I haven't committed them yet because the gui requires the user to download another package. I just did

Code: Select all

if( total_cards != available_slots || !tc )
...
if(!expansions || !exp)
...
if( !estc )

although the last one should probably be

Code: Select all

if( estc != total_cards )

There also need to be changes between lines ~750 and ~950 to get everything running.

[drool66]

Fixed since approx. 6566391