It is currently 16 Apr 2024, 19:35
   
Text Size

[fixed] Quarry Hauler adds/removes only one counter kind

Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins

[fixed] Quarry Hauler adds/removes only one counter kind

Postby Korath » 26 Nov 2021, 22:56

Describe the Bug:
Quarry Hauler prompts to add or remove a counter; then prompts for a single counter kind from among the kinds on it (allowing "cancel"), then adds or removes it.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 24315b234, edited locally to fix this bug.

What exactly should be the correct behavior/interaction?
Prompt for each kind of counter that's there; and for each kind, add or remove, but don't allow doing nothing. (In particular, if you've got a 1/1 creature with a -0/-1 counter on it and a +1/+1 counter on it, don't let it die after adding another -0/-1 counter but before you decide to add or remove a +1/+1 one.)

If you want to be extra fancy, list all the kinds that are there in a dialog, and allow toggling of each kind in any order; then add or remove them all at once when you pick "Done" at the end.

Are any other cards possibly affected by this bug?
Skyship Plunderer and Maulfist Revolutionary both do the same, though neither allows (nor should allow) you to pick "remove". They're easier than this; you can just call increment_all_counters() for them when they're targeting permanents.

None of them have a thing to do with proliferate, in any case, and shouldn't be calling proliferate-named functions just in case proliferate gets another round of arbitrary power-level errata.
Last edited by drool66 on 12 Dec 2021, 19:13, edited 1 time in total.
Reason: fixed
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: [fixed] Quarry Hauler adds/removes only one counter kind

Postby drool66 » 12 Dec 2021, 19:13

Fixed for all in b8e9a5a
Last edited by drool66 on 13 Dec 2021, 15:55, edited 1 time in total.
Reason: hash info
User avatar
drool66
Programmer
 
Posts: 1163
Joined: 25 Nov 2010, 22:38
Has thanked: 186 times
Been thanked: 267 times


Return to Archived Reports

Who is online

Users browsing this forum: No registered users and 22 guests


Who is online

In total there are 22 users online :: 0 registered, 0 hidden and 22 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 22 guests

Login Form