[fixed]Cytoshape kills targeted creature sometimes
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
[fixed]Cytoshape kills targeted creature sometimes
by Blyfycyfyfyf » 08 Jan 2022, 09:40
Describe the Bug:
Cytoshape targets legendary creature, but card text says it should not.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Holidays 2021, duel.
What exactly should be the correct behavior/interaction?
Legendary creature should not be targeted.
Are any other cards possibly affected by this bug?
No.
Cytoshape targets legendary creature, but card text says it should not.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Holidays 2021, duel.
What exactly should be the correct behavior/interaction?
Legendary creature should not be targeted.
Are any other cards possibly affected by this bug?
No.
- Attachments
-
- Cytoshape.zip
- (3.52 KiB) Downloaded 66 times
Last edited by drool66 on 20 Jan 2022, 19:09, edited 4 times in total.
Reason: fixed
Reason: fixed
- Blyfycyfyfyf
- Posts: 36
- Joined: 12 Nov 2021, 12:10
- Has thanked: 0 time
- Been thanked: 0 time
Re: Cytoshape targets legendary creature
by Aswan jaguar » 08 Jan 2022, 10:54
There is a bug here and Cytoshape kills the targeted creature sometimes. It can't chose Legendary creatures as it should. The card we see in the window is the target and it can be a Legendary creature and not what was chosen to be copied which can't be.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: [confirmed]Cytoshape kills targeted creature sometimes
by drool66 » 08 Jan 2022, 18:07
I think AI is targeting Rakdos the Defiler to copy Plaxcaster Frogling. Rakdos, having p/t of 0/0 and no +1/+1 counters dies to SBAs.
Cytoshape does need to be tweaked though - despite what the comment in Cytoshape says, I don't think there's any reason to store the first target in damage_target_player/_card since all targets are updated in gain_control_impl(). Also, the first creature isn't targeted ("Choose a nonlegendary creature...") so should have illegal_abilities = 0. It would be nice to have a popup so we know what was targeted too.
Committed these changes, unpushed
Cytoshape does need to be tweaked though - despite what the comment in Cytoshape says, I don't think there's any reason to store the first target in damage_target_player/_card since all targets are updated in gain_control_impl(). Also, the first creature isn't targeted ("Choose a nonlegendary creature...") so should have illegal_abilities = 0. It would be nice to have a popup so we know what was targeted too.
Committed these changes, unpushed
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
Re: [confirmed]Cytoshape kills targeted creature sometimes
by Aswan jaguar » 08 Jan 2022, 18:49
It uses base_target_definition so it doesn't really target but choose/select so no need for extra illegal_abilities = 0.drool66 wrote: Also, the first creature isn't targeted ("Choose a nonlegendary creature...") so should have illegal_abilities = 0.
Yes, this sounds correct, I missed that.drool66 wrote:I think AI is targeting Rakdos the Defiler to copy Plaxcaster Frogling. Rakdos, having p/t of 0/0 and no +1/+1 counters dies to SBAs.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8078
- Joined: 13 May 2010, 12:17
- Has thanked: 730 times
- Been thanked: 458 times
Re: [closed]Cytoshape kills targeted creature sometimes
by drool66 » 20 Jan 2022, 19:08
Fixed in 7fce8d8 (with unnecessary illegal_abilities = 0 :/ )
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
Re: [fixed]Cytoshape kills targeted creature sometimes
by Korath » 20 Jan 2022, 21:19
It stashed the copied creature in damage_target_player/card instead of targets[0] because it's not a target. Now copying a Skulking Ghost will cause it to be sacced, you can target it with things like Avoid Fate or Mistfolk when it's copying your creature/Mistfolk but only targeting your opponent's creature, and - if choosing new targets worked at all for it - something like Redirect would let you change what it copies, while something like Deflection can't target it at all.
The only actual bug here is that it picks the creature to copy at announcement, not resolution. So it doesn't need to be stored anywhere in the first place.
Also, commits after 0979bccc2 don't build.
The only actual bug here is that it picks the creature to copy at announcement, not resolution. So it doesn't need to be stored anywhere in the first place.
Also, commits after 0979bccc2 don't build.
-
Korath - DEVELOPER
- Posts: 3707
- Joined: 02 Jun 2013, 05:57
- Has thanked: 496 times
- Been thanked: 1106 times
Re: [fixed]Cytoshape kills targeted creature sometimes
by drool66 » 20 Jan 2022, 23:39
Gotcha - 2fa9ad2 and cf7296d
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
7 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 79 guests