[fixed]Cytoshape kills targeted creature sometimes

[Blyfycyfyfyf]

Describe the Bug:
Cytoshape targets legendary creature, but card text says it should not.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Holidays 2021, duel.

What exactly should be the correct behavior/interaction?
Legendary creature should not be targeted.

Are any other cards possibly affected by this bug?
No.

[Aswan jaguar]

There is a bug here and Cytoshape kills the targeted creature sometimes. It can't chose Legendary creatures as it should. The card we see in the window is the target and it can be a Legendary creature and not what was chosen to be copied which can't be.

[drool66]

I think AI is targeting Rakdos the Defiler to copy Plaxcaster Frogling. Rakdos, having p/t of 0/0 and no +1/+1 counters dies to SBAs.

Cytoshape does need to be tweaked though - despite what the comment in Cytoshape says, I don't think there's any reason to store the first target in damage_target_player/_card since all targets are updated in gain_control_impl(). Also, the first creature isn't targeted ("Choose a nonlegendary creature...") so should have illegal_abilities = 0. It would be nice to have a popup so we know what was targeted too.

Committed these changes, unpushed

[Aswan jaguar]

Also, the first creature isn't targeted ("Choose a nonlegendary creature...") so should have illegal_abilities = 0.

It uses base_target_definition so it doesn't really target but choose/select so no need for extra illegal_abilities = 0.

I think AI is targeting Rakdos the Defiler to copy Plaxcaster Frogling. Rakdos, having p/t of 0/0 and no +1/+1 counters dies to SBAs.

Yes, this sounds correct, I missed that.

[drool66]

Fixed in 7fce8d8 (with unnecessary illegal_abilities = 0 :/ )

[Korath]

It stashed the copied creature in damage_target_player/card instead of targets[0] because it's not a target. Now copying a Skulking Ghost will cause it to be sacced, you can target it with things like Avoid Fate or Mistfolk when it's copying your creature/Mistfolk but only targeting your opponent's creature, and - if choosing new targets worked at all for it - something like Redirect would let you change what it copies, while something like Deflection can't target it at all.

The only actual bug here is that it picks the creature to copy at announcement, not resolution. So it doesn't need to be stored anywhere in the first place.

Also, commits after 0979bccc2 don't build.

[drool66]

Gotcha - 2fa9ad2 and cf7296d