[fixed]Kinship ability crashes when it triggers.
Report wrong Card behavior to get it fixed.
PLEASE ADD SAVEGAMES TO YOUR TOPIC !
PLEASE ADD SAVEGAMES TO YOUR TOPIC !
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
[fixed]Kinship ability crashes when it triggers.
by Aswan jaguar » 21 May 2023, 13:15
Describe the Bug:
Kinship ability crashes when it triggers.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Based on latest commit 9338c07 ("Weaver of Lies up to as many targets and not target all.", 2023-05-20)
What exactly should be the correct behavior/interaction?
Are any other cards possibly affected by this bug?
Certainly bugged Call to the Kindred and possibly any card using shares_creature_subtype(-1,...) setting player as -1 ( Path of Ancestry and Descendants' Paths ).
Kinship ability crashes when it triggers.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Based on latest commit 9338c07 ("Weaver of Lies up to as many targets and not target all.", 2023-05-20)
What exactly should be the correct behavior/interaction?
Are any other cards possibly affected by this bug?
Certainly bugged Call to the Kindred and possibly any card using shares_creature_subtype(-1,...) setting player as -1 ( Path of Ancestry and Descendants' Paths ).
- Attachments
-
- Copy of dump2.txt
- (487 Bytes) Downloaded 70 times
-
- Copy of dump1.txt
- (441 Bytes) Downloaded 69 times
Last edited by Aswan jaguar on 23 May 2023, 13:37, edited 1 time in total.
Reason: fixed all
Reason: fixed all
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8080
- Joined: 13 May 2010, 12:17
- Has thanked: 732 times
- Been thanked: 458 times
Re: Kinship ability crashes when it triggers.
by Aswan jaguar » 21 May 2023, 20:11
Fixed Kinship, Path of Ancestry and Descendants' Paths in commit 56551e3.
Edit: I cant find how to fix Call to the Kindred , the bug will appear only if the top card is a creature.
Edit: I cant find how to fix Call to the Kindred , the bug will appear only if the top card is a creature.
Last edited by Aswan jaguar on 22 May 2023, 17:53, edited 2 times in total.
Reason: add hash commit and edit
Reason: add hash commit and edit
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8080
- Joined: 13 May 2010, 12:17
- Has thanked: 732 times
- Been thanked: 458 times
Re: Kinship ability crashes when it triggers.
by Aswan jaguar » 22 May 2023, 17:50
Also fixed same bug for Bloodline Shaman in commit f7b6d3e. So only Call to the Kindred still bugged.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8080
- Joined: 13 May 2010, 12:17
- Has thanked: 732 times
- Been thanked: 458 times
Re: Kinship ability crashes when it triggers.
by drool66 » 23 May 2023, 04:10
For Call to the Kindred, what about:
- Code: Select all
if( selected != -1 && shares_creature_subtype_by_iid(instance->damage_target_player, instance->damage_target_card, player, deck_ptr[player][selected]) ){
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
Re: Kinship ability crashes when it triggers.
by Aswan jaguar » 23 May 2023, 13:37
Fixed in commit a2289fc. The issue was that it didn't change both instances of shares_creature_subtype() in code.
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8080
- Joined: 13 May 2010, 12:17
- Has thanked: 732 times
- Been thanked: 458 times
Re: [fixed]Kinship ability crashes when it triggers.
by drool66 » 24 May 2023, 17:44
None of these functions should pass -1 to the player parameter though. has_subtype_by_id() for example, uses the player param for the cards Conspiracy, Arcane Adaptation, and soon Maskwood Nexus, maybe others.
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
6 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 13 guests